* ARM: domains: Possible regression in v7-M [not found] ` <55F06C55.5070205@vanguardiasur.com.ar> @ 2015-09-09 17:52 ` Russell King - ARM Linux 2015-09-09 18:25 ` Ariel D'Alessandro 0 siblings, 1 reply; 4+ messages in thread From: Russell King - ARM Linux @ 2015-09-09 17:52 UTC (permalink / raw) To: linux-arm-kernel On Wed, Sep 09, 2015 at 02:28:53PM -0300, Ariel D'Alessandro wrote: > Hi, > > I'm testing next-20150909 on a Hitex LPC4350 Evaluation Board, which has > an ARMv7 Cortex-M4 processor. > > There's a problem when booting using the attached config. Config is > lpc18xx_defconfig with dram setting for the Hitex Board. > > Doing a bisect I've observed that regression appears to be caused by: > > commit 1eef5d2f1b461c120bcd82077edee5ec706ac53b > Author: Russell King <rmk+kernel@arm.linux.org.uk> > Date: Wed Aug 19 21:23:48 2015 +0100 > > ARM: domains: switch to keeping domain value in register > > > Stacktrace paste below. > > [ 0.171071] Unhandled exception: IPSR = 00000006 LR = fffffff1 This looks to be ARMv7M, which is nommu... I guess what's causing this is this change in arch/arm/kernel/process.c: + /* + * Copy the initial value of the domain access control register + * from the current thread: thread->addr_limit will have been + * copied from the current thread via setup_thread_stack() in + * kernel/fork.c + */ + thread->cpu_domain = get_domain(); + which probably needs to be #ifdef'd out for !MMU. Can you try adding: #ifndef CONFIG_MMU ... #endif around that please? Thanks. -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. ^ permalink raw reply [flat|nested] 4+ messages in thread
* ARM: domains: Possible regression in v7-M 2015-09-09 17:52 ` ARM: domains: Possible regression in v7-M Russell King - ARM Linux @ 2015-09-09 18:25 ` Ariel D'Alessandro 2015-09-09 20:24 ` Russell King - ARM Linux 0 siblings, 1 reply; 4+ messages in thread From: Ariel D'Alessandro @ 2015-09-09 18:25 UTC (permalink / raw) To: linux-arm-kernel Russell, El 09/09/15 a las 14:52, Russell King - ARM Linux escribi?: > On Wed, Sep 09, 2015 at 02:28:53PM -0300, Ariel D'Alessandro wrote: >> Doing a bisect I've observed that regression appears to be caused by: >> >> commit 1eef5d2f1b461c120bcd82077edee5ec706ac53b >> Author: Russell King <rmk+kernel@arm.linux.org.uk> >> Date: Wed Aug 19 21:23:48 2015 +0100 >> >> ARM: domains: switch to keeping domain value in register >> >> >> Stacktrace paste below. >> >> [ 0.171071] Unhandled exception: IPSR = 00000006 LR = fffffff1 > > This looks to be ARMv7M, which is nommu... I guess what's causing this > is this change in arch/arm/kernel/process.c: > > + /* > + * Copy the initial value of the domain access control register > + * from the current thread: thread->addr_limit will have been > + * copied from the current thread via setup_thread_stack() in > + * kernel/fork.c > + */ > + thread->cpu_domain = get_domain(); > + > > which probably needs to be #ifdef'd out for !MMU. Can you try adding: > > #ifndef CONFIG_MMU I think you meant #ifdef CONFIG_MMU. > ... > #endif > > around that please? Thanks. > Yeah, that works! Added: #ifdef CONFIG_MMU ... #endif around that code block and it booted. Thanks, -- Ariel D'Alessandro, VanguardiaSur www.vanguardiasur.com.ar ^ permalink raw reply [flat|nested] 4+ messages in thread
* ARM: domains: Possible regression in v7-M 2015-09-09 18:25 ` Ariel D'Alessandro @ 2015-09-09 20:24 ` Russell King - ARM Linux 2015-09-09 22:06 ` Ariel D'Alessandro 0 siblings, 1 reply; 4+ messages in thread From: Russell King - ARM Linux @ 2015-09-09 20:24 UTC (permalink / raw) To: linux-arm-kernel On Wed, Sep 09, 2015 at 03:25:41PM -0300, Ariel D'Alessandro wrote: > Russell, > > El 09/09/15 a las 14:52, Russell King - ARM Linux escribi?: > > On Wed, Sep 09, 2015 at 02:28:53PM -0300, Ariel D'Alessandro wrote: > >> Doing a bisect I've observed that regression appears to be caused by: > >> > >> commit 1eef5d2f1b461c120bcd82077edee5ec706ac53b > >> Author: Russell King <rmk+kernel@arm.linux.org.uk> > >> Date: Wed Aug 19 21:23:48 2015 +0100 > >> > >> ARM: domains: switch to keeping domain value in register > >> > >> > >> Stacktrace paste below. > >> > >> [ 0.171071] Unhandled exception: IPSR = 00000006 LR = fffffff1 > > > > This looks to be ARMv7M, which is nommu... I guess what's causing this > > is this change in arch/arm/kernel/process.c: > > > > + /* > > + * Copy the initial value of the domain access control register > > + * from the current thread: thread->addr_limit will have been > > + * copied from the current thread via setup_thread_stack() in > > + * kernel/fork.c > > + */ > > + thread->cpu_domain = get_domain(); > > + > > > > which probably needs to be #ifdef'd out for !MMU. Can you try adding: > > > > #ifndef CONFIG_MMU > > I think you meant #ifdef CONFIG_MMU. > > > ... > > #endif > > > > around that please? Thanks. > > > > Yeah, that works! > > Added: > > #ifdef CONFIG_MMU > ... > #endif > > around that code block and it booted. Thanks. I've settled on using CONFIG_CPU_USE_DOMAINS here, as it only makes sense to save this value if that option is set, and it won't be set for noMMU platforms. Thanks for reporting this and confirming the problem site. If you're okay with it, I'll add: Reported-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar> to the commit to acknowledge your help in finding this. -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. ^ permalink raw reply [flat|nested] 4+ messages in thread
* ARM: domains: Possible regression in v7-M 2015-09-09 20:24 ` Russell King - ARM Linux @ 2015-09-09 22:06 ` Ariel D'Alessandro 0 siblings, 0 replies; 4+ messages in thread From: Ariel D'Alessandro @ 2015-09-09 22:06 UTC (permalink / raw) To: linux-arm-kernel El 09/09/15 a las 17:24, Russell King - ARM Linux escribi?: > On Wed, Sep 09, 2015 at 03:25:41PM -0300, Ariel D'Alessandro wrote: >> Russell, >> >> El 09/09/15 a las 14:52, Russell King - ARM Linux escribi?: >>> On Wed, Sep 09, 2015 at 02:28:53PM -0300, Ariel D'Alessandro wrote: >>>> Doing a bisect I've observed that regression appears to be caused by: >>>> >>>> commit 1eef5d2f1b461c120bcd82077edee5ec706ac53b >>>> Author: Russell King <rmk+kernel@arm.linux.org.uk> >>>> Date: Wed Aug 19 21:23:48 2015 +0100 >>>> >>>> ARM: domains: switch to keeping domain value in register >>>> >>>> >>>> Stacktrace paste below. >>>> >>>> [ 0.171071] Unhandled exception: IPSR = 00000006 LR = fffffff1 >>> >>> This looks to be ARMv7M, which is nommu... I guess what's causing this >>> is this change in arch/arm/kernel/process.c: >>> >>> + /* >>> + * Copy the initial value of the domain access control register >>> + * from the current thread: thread->addr_limit will have been >>> + * copied from the current thread via setup_thread_stack() in >>> + * kernel/fork.c >>> + */ >>> + thread->cpu_domain = get_domain(); >>> + >>> >>> which probably needs to be #ifdef'd out for !MMU. Can you try adding: >>> >>> #ifndef CONFIG_MMU >> >> I think you meant #ifdef CONFIG_MMU. >> >>> ... >>> #endif >>> >>> around that please? Thanks. >>> >> >> Yeah, that works! >> >> Added: >> >> #ifdef CONFIG_MMU >> ... >> #endif >> >> around that code block and it booted. > > Thanks. I've settled on using CONFIG_CPU_USE_DOMAINS here, as it only > makes sense to save this value if that option is set, and it won't be > set for noMMU platforms. OK, that makes sense. > > Thanks for reporting this and confirming the problem site. If you're > okay with it, I'll add: > > Reported-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar> > > to the commit to acknowledge your help in finding this. Sure. Thanks to you for the quick solution. -- Ariel D'Alessandro, VanguardiaSur www.vanguardiasur.com.ar ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-09-09 22:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <55F06797.3060706@gmail.com>
[not found] ` <55F06C55.5070205@vanguardiasur.com.ar>
2015-09-09 17:52 ` ARM: domains: Possible regression in v7-M Russell King - ARM Linux
2015-09-09 18:25 ` Ariel D'Alessandro
2015-09-09 20:24 ` Russell King - ARM Linux
2015-09-09 22:06 ` Ariel D'Alessandro
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox