From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] clocksource: rockchip: Make the driver more readability and compatible
Date: Thu, 17 Sep 2015 11:11:49 +0200 [thread overview]
Message-ID: <55FA83D5.9010504@linaro.org> (raw)
In-Reply-To: <1442476272-31723-2-git-send-email-wxt@rock-chips.com>
Hi Caesar,
On 09/17/2015 09:51 AM, Caesar Wang wrote:
> Build the arm64 SoCs (e.g.: RK3368) on Rockchip platform,
> There are some failure with build up on timer driver for rockchip.
>
> logs:
> ...
> drivers/clocksource/rockchip_timer.c:156:13: error: 'NO_IRQ' undeclared
I think the NO_IRQ definition is missing for ARM64.
> /tmp/ccdAnNy5.s:47: Error: missing immediate expression at operand 1 --
> `dsb`
> ...
>
> The problem was different semantics of dsb on btw arm32 and arm64,
> Here we can convert the dsb with insteading of dsb(sy).
What happens to ARM32 then ?
> Meanwhile, I change a bit to make the code more readability for driver
> when I check the code style.
>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2015-09-17 9:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 7:51 [PATCH 0/3] Support the timer on RK3368 SoC Caesar Wang
2015-09-17 7:51 ` [PATCH 1/3] clocksource: rockchip: Make the driver more readability and compatible Caesar Wang
2015-09-17 9:11 ` Daniel Lezcano [this message]
2015-09-17 9:28 ` Caesar Wang
2015-09-17 9:43 ` Heiko Stübner
2015-09-17 10:06 ` Daniel Lezcano
2015-09-17 10:19 ` Thomas Gleixner
2015-09-17 10:57 ` Daniel Lezcano
2015-09-17 21:13 ` Russell King - ARM Linux
2015-09-18 7:53 ` Daniel Lezcano
2015-09-17 10:19 ` Caesar Wang
2015-09-18 7:55 ` Daniel Lezcano
2015-09-18 8:22 ` Caesar Wang
2015-09-18 9:08 ` Russell King - ARM Linux
2015-09-17 7:51 ` [PATCH 2/3] arm64: Enable the timer on Rockchip architecture Caesar Wang
2015-09-17 7:51 ` [PATCH 3/3] arm64: dts: rockchip: Add the needed timer for rk3368 SoC Caesar Wang
2015-09-17 19:01 ` Heiko Stübner
2015-09-18 1:16 ` Caesar Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FA83D5.9010504@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).