From mboxrd@z Thu Jan  1 00:00:00 1970
From: robin.murphy@arm.com (Robin Murphy)
Date: Thu, 17 Sep 2015 16:53:08 +0100
Subject: [PATCH] iommu/io-pgtable-arm: Don't use dma_to_phys()
In-Reply-To: <20150917145216.GJ25634@arm.com>
References: <1c591836f1ec6e676a8889cdccd042650eadb73b.1442499554.git.robin.murphy@arm.com>
 <20150917145216.GJ25634@arm.com>
Message-ID: <55FAE1E4.4060009@arm.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On 17/09/15 15:52, Will Deacon wrote:
[...]
>> -static dma_addr_t __arm_lpae_dma_addr(struct device *dev, void *pages)
>> -{
>> -	return phys_to_dma(dev, virt_to_phys(pages));
>> -}
>
> Can we keep this helper kicking around, at least to contain the ugliness
> of the virt_to_phys + cast?

Can do for the sync and unmap cases - the alloc_pages one needs to avoid 
truncation in the comparison if dma_addr_t and phys_addr_t are different 
sizes, so can't safely cast one to the other either way. I can at least 
get rid of the u64 casts there though, as they seem superfluous after a 
bit of experimentation and another read of the good old "Usual 
arithmetic conversions". I'll fix up and repost.

Robin.

>
> Will
>