linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] devicetree: bindings: use input-event-codes.h for evdev codes
Date: Thu, 17 Sep 2015 15:00:47 -0500	[thread overview]
Message-ID: <55FB1BEF.4090107@kernel.org> (raw)
In-Reply-To: <55FB15E7.6080502@redhat.com>

On 09/17/2015 02:35 PM, Hans de Goede wrote:
> Hi,
> 
> On 09/17/2015 07:00 AM, Ian Campbell wrote:
>> On Wed, 2015-09-16 at 15:40 +0100, Ian Campbell wrote:
>>>> The intend of the symlink was that the conversion script would copy
>>>> the target,
>>>> rather then follow the symlink. This sorta assumes that there are
>>>> will be not
>>>> symlinks under dt-bindings which link to files inside dt-bindings
>>>> and thus
>>>> should be preserved as symlinks.
>>>>
>>>> If the copy done in the script will follow the symlink then nothing
>>>> should
>>>> really change for the split DT repo.
>>>
>>> Interesting idea. I'll see if I can make the conversion routine do that.
>>>
>>> TBH I have a horrid feeling that this is going to be beyond git rewrite
>>> -branch, at least in the mode it is used in today.
>>
>> It seems that it is possible, after a fashion.
>>
>> The downside is that either _all_ symlinks (which end up in the
>> output) get
>> flattened or some sort of black/whitelisting is needed in the conversion
>> scripts themselves (potentially leading to issues or discontinuities) as
>> new stuff arrives).
>>
>> It isn't possible AFAICT tell if a symlink points to something outside of
>> the converted set of paths and adjust, at least not without an
>> unreasonable
>> amount of overhead on each commit during the rewrite.
>>
>> Since this new file would be the first symlink in the converted repo I
>> took
>> the former approach in my lash up to try it out
> 
> Ack, sounds good.
> 
>> which was essentially to
>> insert the below script into the middle of the "git ls-files | rewrite
>> -paths.sed" pipeline which is called by git filter-branch --index-filter.
>> Not pretty but it does seem to work.
>>
>> I want to avoid switching to --tree-filter if at all possible because it
>> checks out the tree and is therefore a _little_ I/O intensive ;-)
> 
> Thanks for your work on this, so what does this mean for moving forward
> with the patch-set I posted. Can this be merged now ? And if not what
> are we waiting for ?

I thought you were sending another version using "linux-event-codes.h."

Anyway, for the series for DT:

Acked-by: Rob Herring <robh@kernel.org>

Rob

  reply	other threads:[~2015-09-17 20:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-12 13:26 [PATCH 0/3] input / dt-bindings: Unify defining of evdev codes Hans de Goede
2015-09-12 13:26 ` [PATCH 1/3] input: Add an input-event-codes header file Hans de Goede
2015-09-12 13:26 ` [PATCH 2/3] devicetree: bindings: use input-event-codes.h for evdev codes Hans de Goede
2015-09-15 11:24   ` Ian Campbell
2015-09-16 14:27     ` Hans de Goede
2015-09-16 14:40       ` Ian Campbell
2015-09-16 14:43         ` Hans de Goede
2015-09-17 11:00         ` Ian Campbell
2015-09-17 19:35           ` Hans de Goede
2015-09-17 20:00             ` Rob Herring [this message]
2015-09-17 20:04               ` Hans de Goede
2015-09-12 13:26 ` [PATCH 3/3] ARM: dts: sun4i: inet9f-rev03: Add support for game buttons / joysticks Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55FB1BEF.4090107@kernel.org \
    --to=robh@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).