From mboxrd@z Thu Jan 1 00:00:00 1970
From: daniel.lezcano@linaro.org (Daniel Lezcano)
Date: Fri, 18 Sep 2015 09:55:24 +0200
Subject: [PATCH 1/3] clocksource: rockchip: Make the driver more
readability and compatible
In-Reply-To: <55FA93B0.40504@gmail.com>
References: <1442476272-31723-1-git-send-email-wxt@rock-chips.com>
<1442476272-31723-2-git-send-email-wxt@rock-chips.com>
<55FA83D5.9010504@linaro.org> <55FA87AA.4040807@gmail.com>
<55FA9099.7000903@linaro.org> <55FA93B0.40504@gmail.com>
Message-ID: <55FBC36C.2090801@linaro.org>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org
On 09/17/2015 12:19 PM, Caesar Wang wrote:
>
>
> ? 2015?09?17? 18:06, Daniel Lezcano ??:
>> On 09/17/2015 11:28 AM, Caesar Wang wrote:
>>> Hi Daniel,
>>>
>>>
>>> ? 2015?09?17? 17:11, Daniel Lezcano ??:
>>>>
>>>> Hi Caesar,
>>>>
>>>>
>>>> On 09/17/2015 09:51 AM, Caesar Wang wrote:
>>>>> Build the arm64 SoCs (e.g.: RK3368) on Rockchip platform,
>>>>> There are some failure with build up on timer driver for rockchip.
>>>>>
>>>>> logs:
>>>>> ...
>>>>> drivers/clocksource/rockchip_timer.c:156:13: error: 'NO_IRQ'
>>>>> undeclared
>>>>
>>>> I think the NO_IRQ definition is missing for ARM64.
>>>
>>> Yep, Maybe better to compatible if we don't use the 'NO_IRQ',
>>
>> Hmm, after digging into drivers/of/irq.c and kernel/irq/irqdomain.c
>>
>> when there is an error it returns zero. So NO_IRQ and -1 are not
>> correct and on the other side zero can be a valid irq. That sounds a
>> little bit fuzzy to me.
>
> I believe the 'NO_IRQ' is better select if 'NO_IRQ' is defined on ARM64
> platform.
>
> irq = irq_of_parse_and_map(np, 0);
>
> if (irq == NO_IRQ)
> ...
> Also, that's ok if we instead of the 'irq < 0' or '!irq' , right?
Hi Caesar,
so regarding Thomas and Russel answers, let's replace NO_IRQ by '!irq'.
Thanks.
-- Daniel
--
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook |
Twitter |
Blog