From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH linux-next] usb: gadget: atmel_usba_udc: add ep capabilities support on device tree binding
Date: Fri, 18 Sep 2015 16:22:07 +0200 [thread overview]
Message-ID: <55FC1E0F.4070807@atmel.com> (raw)
In-Reply-To: <1441657171-15362-1-git-send-email-sylvain.rochet@finsecur.com>
Le 07/09/2015 22:19, Sylvain Rochet a ?crit :
> The recently added endpoint capabilities flags verification breaks Atmel
> USBA because the endpoint configuration was only added when the driver
> is bound using the legacy pdata interface.
>
> Convert endpoint configuration to new capabilities model when driver is
> bound to a device tree as well.
>
> Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
With this additional tag:
Fixes: 47bef3865115 ("usb: gadget: atmel_usba_udc: add ep capabilities support")
Felipe, Greg,
It is considered as a fix for 4.3. Can you please queue it for the "4.3-rc" phase?
Thanks, bye.
> ---
> drivers/usb/gadget/udc/atmel_usba_udc.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index 2cbbb46..c2ea5e1 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -2002,6 +2002,17 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev,
> ep->udc = udc;
> INIT_LIST_HEAD(&ep->queue);
>
> + if (ep->index == 0) {
> + ep->ep.caps.type_control = true;
> + } else {
> + ep->ep.caps.type_iso = ep->can_isoc;
> + ep->ep.caps.type_bulk = true;
> + ep->ep.caps.type_int = true;
> + }
> +
> + ep->ep.caps.dir_in = true;
> + ep->ep.caps.dir_out = true;
> +
> if (i)
> list_add_tail(&ep->ep.ep_list, &udc->gadget.ep_list);
>
>
--
Nicolas Ferre
next prev parent reply other threads:[~2015-09-18 14:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 20:19 [PATCH linux-next] usb: gadget: atmel_usba_udc: add ep capabilities support on device tree binding Sylvain Rochet
2015-09-18 14:22 ` Nicolas Ferre [this message]
2015-09-18 14:27 ` Felipe Balbi
2015-09-18 14:58 ` [PATCH] " Nicolas Ferre
2015-09-18 14:59 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FC1E0F.4070807@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox