From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0E83C46467 for ; Sat, 14 Jan 2023 11:04:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=leLM8+Cs4zxq+ovjt5AFYbwcnl9y3EJlL7wK+v40Yo0=; b=0BetZtyeZrleUW uU50kxi6NGswn6NyjvahacP4N+K4eG+Gnjii+hc43i8DFcwDJdxcQ5a5XX8e/GJgH7yBE+hMbMpJI lf9Mi/RCA4gc3sf7sl+FwgJ+VaUlKHQOyLyDGshAuR72NNkHVlJG1f8XeLgoxHjbfWoTWGbkvSNVP wdQK/NfXZqwam39hMth3RvGBOjkR7LvURqmXQwQVPdHYGnha+msQ3WRYWaodu+KyrL0NHCUGQ35H2 w86UXMI9HeKRbpKKhK6Hnm2ZlKi69zGnqCa0RSzViNNP1bOLLY8iMXHf0DOR3FwtTSKhplO3jTBG0 mpC/132Fmdty4dijw5LA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pGeJn-005g4V-NU; Sat, 14 Jan 2023 11:03:23 +0000 Received: from mout.kundenserver.de ([217.72.192.74]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pGeJj-005g3I-26; Sat, 14 Jan 2023 11:03:20 +0000 Received: from [192.168.1.139] ([37.4.248.41]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MEmAX-1pVoSk1PzP-00GGUj; Sat, 14 Jan 2023 12:03:09 +0100 Message-ID: <55a87b32-803a-ceb3-4c31-ac818fe69596@i2se.com> Date: Sat, 14 Jan 2023 12:03:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 2/4] pinctrl: bcm2835: Remove of_node_put() in bcm2835_of_gpio_ranges_fallback() Content-Language: en-US To: Andy Shevchenko , Bartosz Golaszewski , Dmitry Torokhov , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Cc: Linus Walleij , Bartosz Golaszewski , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list References: <20230113215352.44272-1-andriy.shevchenko@linux.intel.com> <20230113215352.44272-3-andriy.shevchenko@linux.intel.com> From: Stefan Wahren In-Reply-To: <20230113215352.44272-3-andriy.shevchenko@linux.intel.com> X-Provags-ID: V03:K1:Q7jwe0zd23pn63SPpBcaoz+2C1kRVrLVSYSrwaom5qa3JoHNVN9 36IOEe3aOYGi/q1SOOFknUgOaqHhASEgUWIvLtunSzbalX88EH5XEweU6tOH4E7olv2d/tC 8q698TSPQ7ZwGJDxoiDFIpr/3I4kp2PMo0teLRIc9s5LantdcHPo2YKhyjtr8a4bP5Vev7L l+iq783ufTgYuWLrelJVg== UI-OutboundReport: notjunk:1;M01:P0:QeP0a6yBzJs=;9pDOaVNDIwGGdcIS9DNPPS9SGHc a9ITmh9f35ejQ7549o1a/LR1zoWn0tyEdfNhLaGzJ+i0SQZ78rR3IDglZspPpBaJzyorfz4qc PI87K/ZLsb8cYtyJh6aZzOFRXnx0k4mYfmDbIEpTo55ZTJuoIS234aBXgJxGp8gFSM3fAnelV TPQQyIJc5mOm7TBVw2kTQaE8Kcbv7dJIZF+S6olIbkO4N7IDqkDYlUPSYAFcbG5rgoYfYzb3B uZD0m6RRw2KgNj8AdPOaSr7wv/i1N2YaKIf8gaK/q4o4erJMKf+DZQjZdAsi70E8S39frQ1ye 44yA/euzpbD4sFY0gyiu5nsVrlujVd6EJMkdoYS/zeNRZJJ8sobOVTDjfVxYY9e1yvAaPbkFg Loc4uufeGwsk6JA1Lvv0D32Jkc94htekcZH1VWEuhw2icJ8cfA/W76eUfLVuStMfr2yHVRUvq NLdQ1gDnOgQpAITzMiP1M/QhsRIYOWZ+ePi7escqsC/iGcbF5J9645NXhuIPmr5jW2SGYQr0y 1e/lnyD3it8YmtWEEQh6roNaWMBeWdVT0UCsglllN/tSY/CLS3m+UuaWYoVcWCHrPXuuHjJ9r 8IJo/XCZCw/Br1C0TbYIK2ITll2ZLbxjZOi1/mn9z8Isf9vV9hDfMcodLFZ3vQO8JbH4/7t3N bZ0XAZaWTlLgjsxvp3vVbxHcsBqDQs923QixmPn2Dw== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230114_030319_441905_86B331A5 X-CRM114-Status: GOOD ( 15.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andy, Am 13.01.23 um 22:53 schrieb Andy Shevchenko: > Remove wrong of_node_put() in bcm2835_of_gpio_ranges_fallback(), > there is no counterpart of_node_get() for it. > > Fixes: d2b67744fd99 ("pinctrl: bcm2835: implement hook for missing gpio-ranges") > Signed-off-by: Andy Shevchenko thanks for fixing. It seems that i got confused by function name and usage in other driver. Reviewed-by: Stefan Wahren > --- > drivers/pinctrl/bcm/pinctrl-bcm2835.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c > index 7857e612a100..c7cdccdb4332 100644 > --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c > +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c > @@ -363,8 +363,6 @@ static int bcm2835_of_gpio_ranges_fallback(struct gpio_chip *gc, > { > struct pinctrl_dev *pctldev = of_pinctrl_get(np); > > - of_node_put(np); > - > if (!pctldev) > return 0; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel