From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24FCCC433EF for ; Tue, 9 Nov 2021 22:15:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B337A611AD for ; Tue, 9 Nov 2021 22:15:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B337A611AD Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=akamai.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=VVF+ut7Ojf7T2kHdXkHrRlF1/e0clKX6nVGd6L3/GJg=; b=DB/eM1SSboNeFCdz/IrQ1/GWaD wnbjM8tPO6rmOQzttCe3TN9KVzhYvZSHM0S7l7WAD6sDqqCXdJCZty1bWbGAdP4B9j3oo4N9t5Bxo +LIqF39nZXsZFwLAC1avEfex/zzu2sUVcQTNGm7T/i+Bfj0sDpZgyTf4tjJoj/HMHkNNI7XnrsBud 6A+vy6BexHZzesgXMWq74zvXkZsDYCRh+ioD2VyfThBaCbHKoYSiEWS+9kyVHhjDOtZCglwnALghh 0Y+2qMJsu3yVdOVmAm6Nl34LYJk5HmetSOoWy8VtJQkhjIuVZ//AgCpid5w5UuMd7W0Tp6KIxqiJV 321xeOHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkZND-003KsI-LR; Tue, 09 Nov 2021 22:13:47 +0000 Received: from mx0b-00190b01.pphosted.com ([2620:100:9005:57f::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkZN9-003Krm-DF for linux-arm-kernel@lists.infradead.org; Tue, 09 Nov 2021 22:13:45 +0000 Received: from pps.filterd (m0122331.ppops.net [127.0.0.1]) by mx0b-00190b01.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1A9KiMMd022651; Tue, 9 Nov 2021 22:13:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akamai.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=jan2016.eng; bh=RELr9g3430pk0P/l4UsUiNTAvTTaZIuuN/G3QKPrB40=; b=RoRJqoZODWMzVi3PhscKunJ3D9W1nnqVn6bPXcDoteGBtJtUpuhbmOC1AlT97ik8c9Ot J9NJGHgjhvgxvF3A5OtkmpGIoa+7cxaiBUVr4mGryzztkXxv+xCsLG/NSCBbmiKiqOiT tHDpTo+1eHec1Js/VuePF1fSdF4Y7mXf4QSIFjcbDDlFXDQY6fJKk7+86E8hN3me2e77 2PAwTLMo7X+wny5024rDqA8j07cQIIx86YnJjAHCJT0F8QVslSw6LAUxkXGlJhwFBUkf AJu6gmiKhcNDz53zGcW+mnH2LJmLCiPr9RXj6wa/h4pBeimr3ko85YZLGr3mmlPPrP+0 Fw== Received: from prod-mail-ppoint5 (prod-mail-ppoint5.akamai.com [184.51.33.60] (may be forged)) by mx0b-00190b01.pphosted.com (PPS) with ESMTPS id 3c7sxat0vb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Nov 2021 22:13:14 +0000 Received: from pps.filterd (prod-mail-ppoint5.akamai.com [127.0.0.1]) by prod-mail-ppoint5.akamai.com (8.16.1.2/8.16.1.2) with SMTP id 1A9M4cYV002810; Tue, 9 Nov 2021 14:13:13 -0800 Received: from prod-mail-relay11.akamai.com ([172.27.118.250]) by prod-mail-ppoint5.akamai.com with ESMTP id 3c5qpbe9b8-1; Tue, 09 Nov 2021 14:13:13 -0800 Received: from [0.0.0.0] (prod-ssh-gw01.bos01.corp.akamai.com [172.27.119.138]) by prod-mail-relay11.akamai.com (Postfix) with ESMTP id 43F9427976; Tue, 9 Nov 2021 22:13:13 +0000 (GMT) Subject: Re: [PATCHv3 3/3] dynamic_debug: Add a flag for dynamic event tracing To: Steven Rostedt Cc: Sai Prakash Ranjan , Will Deacon , Catalin Marinas , quic_psodagud@quicinc.com, Marc Zyngier , gregkh@linuxfoundation.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, mingo@redhat.com, jim.cromie@gmail.com, seanpaul@chromium.org References: <3706af20bc64a320ff8f3ff8950738b988f4bdf5.1636452784.git.quic_saipraka@quicinc.com> <20211109104941.2d50eafc@gandalf.local.home> <20211109115951.1c2b5228@gandalf.local.home> <264b77dd-5509-60f9-248c-a93135b01aa9@quicinc.com> <20211109124046.2a772bcb@gandalf.local.home> <20211109165104.176b4cf9@gandalf.local.home> From: Jason Baron Message-ID: <55a9fe7b-5573-0f80-e075-758b377a6c47@akamai.com> Date: Tue, 9 Nov 2021 17:13:13 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20211109165104.176b4cf9@gandalf.local.home> Content-Language: en-US X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425, 18.0.790 definitions=2021-11-09_07:2021-11-08, 2021-11-09 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 suspectscore=0 mlxscore=0 phishscore=0 mlxlogscore=776 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111090119 X-Proofpoint-GUID: qZ_VL_UCgyoOVZNiQN1fngiQ7U9Ely9n X-Proofpoint-ORIG-GUID: qZ_VL_UCgyoOVZNiQN1fngiQ7U9Ely9n X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-09_07,2021-11-08_02,2020-04-07_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=759 spamscore=0 clxscore=1015 bulkscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 mlxscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111090121 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211109_141343_947027_EBD59E99 X-CRM114-Status: GOOD ( 27.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/9/21 4:51 PM, Steven Rostedt wrote: > On Tue, 9 Nov 2021 16:42:48 -0500 > Jason Baron wrote: > >> Yeah there is a 'parallel' thread about adding the tracing ring buffer as >> a 'back end' to the dynamic debug stuff over here: >> https://urldefense.com/v3/__https://lore.kernel.org/lkml/20211105192637.2370737-9-jim.cromie@gmail.com/__;!!GjvTz_vk!GdVm3olk4hfEx6PjfDDPg4cIbtY60aeqP0IOwu1-S0qJRBZ-OuvC5I_stkqniA$ > > As the maintainer of tracefs, why am I not Cc'd on that thread :-( > > I'll have to look at that thread later (no time now). Agreed - that's my bad. I meant to add you earlier in the discussion... > >> >> The attempt there is more generic but I realize now that it is adding the >> tracing to an 'instance' which is specific to dynamic debug which is >> being created via: trace_array_get_by_name(). I would prefer to just have >> it print to the 'main' trace buffer such that it's easier to read, >> although I guess they could still be consolidated via timestamps. >> Hmmm...I think there was a previous proposal to just add a single >> tracepoint (that takes a string) to the dynamic debug layer that could be >> called if a dynamic debug site is enabled for trace buffer output. Would >> that satisfy the ftrace level filtering requirements that you are looking >> for? > > What we are looking at there is to pass the dynamic debug descriptor to the > trace event filtering logic, where you could filter on information passed > to it. For example, on a specific file if a trace event is called by > several different files or modules. > > -- Steve Ok, Could this be done at the dynamic debug level as it can already match on specific files and line numbers currently? Thanks, -Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel