From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7466C6FA82 for ; Mon, 12 Sep 2022 16:16:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y2TLGxSDBPiCfuhUTnIM76Rif91N9fBWA6+S6B1OGSU=; b=TL4IOIVET0DbYv UJVNXQPkjLZgQWLnNo6Tfe/9JHNRl32NUbnA3r+xwdi5GvNXUS88mqh8kH4ksDMLeOTbWJUs/muiI Zh3EfCJDnoH5k4PeXW4hSAbq/19CMIrAKlgBKB7Q9b7EZuVeIJz13BeUWBKemx0RSmG7CH6PdblDX 0MPCktwHYJRpLE6ccgax+I8p0vXg0uXyrYS3o9MBOyLDyEfzUGZ9FoRrs5+mvwQQPEPPlMKGe6jcJ K885d/0jIvJIl7HAp/52pBhaaCToIIyq0rzFjEP4bIAIhE2P55MBKcYw9ZqkDCRY5LbK65eiYmVKc aBSYiwl/Uhqk2VvD94Lg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oXm5P-00BTp7-Ly; Mon, 12 Sep 2022 16:15:04 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oXm5A-00BTh5-Gc for linux-arm-kernel@lists.infradead.org; Mon, 12 Sep 2022 16:14:50 +0000 Received: by mail-wm1-x32b.google.com with SMTP id z14-20020a05600c0a0e00b003b486df42a3so2415075wmp.2 for ; Mon, 12 Sep 2022 09:14:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=p2UuUVGgNeM7cWoN9co4RiFexO2JQRrTt6fDZRT2l6Q=; b=WjrnQt4bUeUHZEbDpxtLxWOhdOwi5lTqQ099s2SU4zwqBVZeCaJ99AWi+Lje4bC1nB O3tzwj3cB/y8uJIrxyAMmpAZZiZE1oAoe+CmU6tvH6uuu7kRH4qjFLTPX3X+w5dUwOFX o8co/TSCDVVOqEY+F9a2elNlGE789+JRJGg/2swqnsMphCm5dTxSs6un8KvwqrN4el9C w0tyhgDMmpoZdlDcn3+rt2sQ0+UJNLN3YSXLC/LCoofMNzJoj+5eLDxrmnRvgtE8+/mt XEj06YGEsdvvuzfqdQzL+utyOMeqWfZy+0ykcJCPkT0Rne+IksX8EnxcGIR/uJ517dRo zh5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=p2UuUVGgNeM7cWoN9co4RiFexO2JQRrTt6fDZRT2l6Q=; b=ovUENt+0mw9ihbew2Az0IY+dZB6eFHPuNsKfq1P8dWAB43x2L6OlamH6xg5I0ZLxIt A4TaONK3Vo6eMY/T1+EhLvFUXyQ+iRoDtvKl/Y6Oqt3VWB3YUDrLpy/ZzEWBU1CcQLhh +YDs+uE0xuqmcVNXihVz2KqSAgnP0ENh4XYoFOWHxktrJvZm5oMvmHgXeI9shD8eAdZY BgSYAVIouJQyKmJ1btS9aihCWpocNHiWQ1LXapueY3Cwe8LcAutFzBfHCjMt7Z4GTv0+ YQXznYE+onvOub4FmIn3CWaTXOI0J3SWPgWVR1Gj6mbIGiIGg1QnhaRRvPv+U6NEkeY4 P4HQ== X-Gm-Message-State: ACgBeo1RVXerGMjk4awAPD+k68eCMls2FsD7B4oLGmy80IBbXAn5kQUU WFHY/F+uyh69ALfXFz8DaeE= X-Google-Smtp-Source: AA6agR6TxM9HREIppAFy4INv7lrvGZZIc1xY0Z0z6Wz7xBGrYJrUQHdC7xeeaLg8OPCnLJ3WpI/YYw== X-Received: by 2002:a05:600c:1c1f:b0:3b4:8330:5a46 with SMTP id j31-20020a05600c1c1f00b003b483305a46mr5102190wms.45.1662999285997; Mon, 12 Sep 2022 09:14:45 -0700 (PDT) Received: from jernej-laptop.localnet ([89.101.193.71]) by smtp.gmail.com with ESMTPSA id a6-20020a5d4d46000000b00228aea99efcsm7717117wru.14.2022.09.12.09.14.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Sep 2022 09:14:45 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , Samuel Holland , Kuninori Morimoto , Mikhail Rudenko Cc: Mikhail Rudenko , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ASoC: sunxi: sun4i-codec: silence misleading error in probe Date: Mon, 12 Sep 2022 18:14:44 +0200 Message-ID: <5600291.DvuYhMxLoT@jernej-laptop> In-Reply-To: <20220911145713.55199-1-mike.rudenko@gmail.com> References: <20220911145713.55199-1-mike.rudenko@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220912_091449_043772_E1E0FB76 X-CRM114-Status: GOOD ( 18.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne nedelja, 11. september 2022 ob 16:57:11 CEST je Mikhail Rudenko napisal(a): > In the case when a codec device is probed before codec analog > controls, snd_soc_register_card() returns -EPROBE_DEFER, resulting in > a misleading error message > > sun4i-codec 1c22c00.codec: Failed to register our card > > even if the device is probed successfully later. Use dev_err_probe() > to demote the above error to a debug message. > > Signed-off-by: Mikhail Rudenko Acked-by: Jernej Skrabec Best regards, Jernej > --- > sound/soc/sunxi/sun4i-codec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c > index 60712f24ade5..01b461c64d68 100644 > --- a/sound/soc/sunxi/sun4i-codec.c > +++ b/sound/soc/sunxi/sun4i-codec.c > @@ -1825,7 +1825,7 @@ static int sun4i_codec_probe(struct platform_device > *pdev) > > ret = snd_soc_register_card(card); > if (ret) { > - dev_err(&pdev->dev, "Failed to register our card\n"); > + dev_err_probe(&pdev->dev, ret, "Failed to register our card\n"); > goto err_assert_reset; > } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel