[PATCH 3/4] thermal: rcar: Add missing clock handling

Geert Uytterhoeven
2014-01-08T10:23:16Z

On Wed, Jan 8, 2014 at 2:08 AM, Kuninori Morimoto
<kuninori.morimoto.gx@gmail.com> wrote:
>> + common->clk = devm_clk_get(&pdev->dev, NULL);
>> + if (IS_ERR(common->clk)) {
>> + dev_err(&pdev->dev, "cannot get clock\n");
>> + return PTR_ERR(common->clk);
>> + }
>> +
>> + ret = clk_prepare(common->clk);
>> + if (ret < 0) {
>> + dev_err(&pdev->dev, "unable to prepare clock\n");
>> + return ret;
>> + }
>> +
>> + clk_enable(common->clk);
>> +
>> pm_runtime_enable(dev);
>> pm_runtime_get_sync(dev);
>
> And this patch seems strange for me.
> pm_runtime_xxx() is doing same things.
> If it didn't work, wrong place is not driver, clock side ?

That's an interesting observation...

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds