From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B7BCECAAA1 for ; Mon, 5 Sep 2022 06:31:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Cc:To:From:Subject:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LSfHumUKRNvjLCtJf/ylmB3flSxrqQaeqdgMOqqhBMg=; b=atETivHozSR2p+ VUL5O3BhYaxSlvMzwf+x3M7PRUff0e4nG7YwQIUHfMrUWWtVd0sx/w68eP1dppZL7scD7ac9CQ4un +BBjwaBGxCyzWlOZQebIHMnhfXUHiL1OFb6jmrOWhefyTbKvhXMawe/rSe+UiCo/MqdT2mp3wqyQP +RWKvFhP84qR+CJHfn3uBRMKleWLpiy9uUY74brVbdv+3sx6+V99D5LEtQ6C/rdHPKmYwNEu5s3pe ye0ap24KT4c+y/2YxbbiBB0LHReoz0pkWzERpqiVYaoDj/x5W3V5MjCefEMvVuj6EWkfOMp0AEgWA IjaYerjggwnR3sVqmdaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oV5c4-00CE18-DI; Mon, 05 Sep 2022 06:29:41 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oV5b2-00CCcO-VU for linux-arm-kernel@lists.infradead.org; Mon, 05 Sep 2022 06:28:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1662359317; x=1693895317; h=subject:from:to:cc:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=WfWbjVdUvWTz4RKxs2T5vp9uD5XLNpzOq3CTK7XEBs4=; b=O9hUPXaZeTFQ2Zb5ArR/XzNa8w0Cwvj5T35Go9tkabkvhI1IgmgE+MGb P42P8guzPQcTJd2W/bILhBkrKpnPMNo27Wp4YtVPCIlcmkyPgXDuh7+jl CKVDj3K/3d0Gn0AklFur9h1YHeaL0QbrChb+aKjfnU0rVrV5OzVY5SrYG mStb+LzTP2BrJyLuo44e5G470g9/fasousrA2HKcq7A/n2gSLNzcMkkwD 5Q0r8Blm6tZusvRmA9W+VadQlKiMc7SMXfVQKD5LZU+3a8496pI6j2M1l uNrBdJxMqKk6oZtQWKZm7kJytW+IHk8uBTtLLLZ31l7KAF0P0FYuwEThv w==; X-IronPort-AV: E=Sophos;i="5.93,290,1654552800"; d="scan'208";a="25976558" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 05 Sep 2022 08:28:31 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Mon, 05 Sep 2022 08:28:31 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Mon, 05 Sep 2022 08:28:31 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1662359311; x=1693895311; h=from:to:cc:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding:subject; bh=WfWbjVdUvWTz4RKxs2T5vp9uD5XLNpzOq3CTK7XEBs4=; b=JrhblJuAWuDq3sUlDItXcxuQ12THu0tTxyeYKfkICLLbFsDjfMZ9wJWb EpOLOB4qN1vfdJgUdoxnL2QBfYJKzENXjMwNNI/iOYOPqfzRKMw0zwIEm IGlIkabaTYSiosDAD751y6+AVXASSNCLeL/XxVO8PKDIbWjwCUshxlnZJ Eph8Tgz8cTeG3lTHGi/q6nnmguPuEv+OsiDt/0FDtPOmxbwGn08vZo80v yXESG7widoqWJMoUtyAeX5Cm+PSgJtL3s8teBb+5jm2sFtMEh2z4FGQV8 h/kVMHd1XD4OZiDjtTp/71SFDzniIpE1KhozPDrk1nHgmXxYbZJKmoQq4 Q==; X-IronPort-AV: E=Sophos;i="5.93,290,1654552800"; d="scan'208";a="25976557" Subject: Re: Re: [PATCH v2 1/1] arm64: dts: tqma8mpql: add USB DR support Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 05 Sep 2022 08:28:31 +0200 Received: from steina-w.localnet (unknown [10.123.49.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 82F93280056; Mon, 5 Sep 2022 08:28:31 +0200 (CEST) From: Alexander Stein To: Shawn Guo Cc: Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tim Harvey , Jun Li Date: Mon, 05 Sep 2022 08:28:29 +0200 Message-ID: <5604780.DvuYhMxLoT@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20220905022228.GB1728671@dragon> References: <20220831074606.1677052-1-alexander.stein@ew.tq-group.com> <20220905022228.GB1728671@dragon> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220904_232837_728039_E8DBF9EC X-CRM114-Status: GOOD ( 23.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Shawn, thanks for your feedback. Am Montag, 5. September 2022, 04:22:28 CEST schrieb Shawn Guo: > On Wed, Aug 31, 2022 at 09:46:06AM +0200, Alexander Stein wrote: > > Add support for USB DR on USB1 interface. Host/Device detection is done > > using the usb-role-switch connector. > > > > Signed-off-by: Alexander Stein > > --- > > Changes in v2: > > * Split from previous series > > * For now enable USB OTG only > > > > .../freescale/imx8mp-tqma8mpql-mba8mpxl.dts | 40 +++++++++++++++++++ > > 1 file changed, 40 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts > > b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts index > > d8ca52976170..b30d75b1fa47 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts > > @@ -459,6 +459,37 @@ &usdhc2 { > > > > status = "okay"; > > > > }; > > > > +&usb3_phy0 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_usb0>; > > Should the pinctrl be in USB controller instead of PHY node? That seems reasonable. I'll move this to the USB glue layer node, where also the OC and PWR polarity can be changed. > > + status = "okay"; > > +}; > > + > > +&usb3_0 { > > + fsl,over-current-active-low; > > + status = "okay"; > > +}; > > + > > +&usb_dwc3_0 { > > These nodes are not in alphabetic order. Sure, this looks wrong, I'll fix that. > > + /* dual role is implemented, but not a full featured OTG */ > > + hnp-disable; > > + srp-disable; > > + adp-disable; > > + dr_mode = "otg"; > > + usb-role-switch; > > + role-switch-default-mode = "peripheral"; > > + status = "okay"; > > + > > + connector { > > + compatible = "gpio-usb-b-connector", "usb-b-connector"; > > + type = "micro"; > > + label = "X29"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_usbcon0>; > > + id-gpios = <&gpio1 10 GPIO_ACTIVE_HIGH>; > > + }; > > +}; > > + > > > > &iomuxc { > > > > pinctrl_backlight: backlightgrp { > > > > fsl,pins = ; > > > > @@ -666,6 +697,15 @@ pinctrl_uart4: uart4grp { > > > > ; > > > > }; > > > > + pinctrl_usbcon0: usb0congrp { > > + fsl,pins = ; > > + }; > > + > > + pinctrl_usb0: usb0grp { > > pinctrl_usb0 should go before pinctrl_usbcon0? Yes, I'll fix that. Thanks and best regards, Alexander > Shawn > > > + fsl,pins = , > > + ; > > + }; > > + > > > > pinctrl_usdhc2: usdhc2grp { > > > > fsl,pins = , > > > > , _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel