* [PATCH] ARM: debug: add support for alternate 8250 register layout
@ 2015-10-02 12:12 Mans Rullgard
2015-10-02 14:14 ` Måns Rullgård
2015-10-02 14:19 ` Sergei Shtylyov
0 siblings, 2 replies; 6+ messages in thread
From: Mans Rullgard @ 2015-10-02 12:12 UTC (permalink / raw)
To: linux-arm-kernel
Some SoCs have a UART with a non-standard register layout. This
allows the debug console to work with these.
Signed-off-by: Mans Rullgard <mans@mansr.com>
---
I would have preferred a more accurate description of the UART, but I've
not managed to figure out who the vendor is.
---
arch/arm/Kconfig.debug | 4 ++++
arch/arm/include/debug/8250.S | 12 ++++++++++++
2 files changed, 16 insertions(+)
diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 0cfd7f9..8d5c837 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -1597,6 +1597,10 @@ config DEBUG_UART_8250_WORD
DEBUG_BCM_KONA_UART || DEBUG_RK32_UART2 || \
DEBUG_BRCMSTB_UART
+config DEBUG_UART_8250_AU
+ bool "8250 UART has Alchemy register layout"
+ depends on DEBUG_LL_UART_8250 || DEBUG_UART_8250
+
config DEBUG_UART_8250_FLOW_CONTROL
bool "Enable flow control for 8250 UART"
depends on DEBUG_LL_UART_8250 || DEBUG_UART_8250
diff --git a/arch/arm/include/debug/8250.S b/arch/arm/include/debug/8250.S
index 7f7446f..3c9ef68 100644
--- a/arch/arm/include/debug/8250.S
+++ b/arch/arm/include/debug/8250.S
@@ -9,6 +9,18 @@
*/
#include <linux/serial_reg.h>
+#ifdef CONFIG_DEBUG_UART_8250_AU
+
+#undef UART_TX
+#undef UART_LSR
+#undef UART_MSR
+
+#define UART_TX 1
+#define UART_LSR 7
+#define UART_MSR 8
+
+#endif
+
.macro addruart, rp, rv, tmp
ldr \rp, =CONFIG_DEBUG_UART_PHYS
ldr \rv, =CONFIG_DEBUG_UART_VIRT
--
2.5.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: debug: add support for alternate 8250 register layout
2015-10-02 12:12 [PATCH] ARM: debug: add support for alternate 8250 register layout Mans Rullgard
@ 2015-10-02 14:14 ` Måns Rullgård
2015-10-02 14:19 ` Sergei Shtylyov
1 sibling, 0 replies; 6+ messages in thread
From: Måns Rullgård @ 2015-10-02 14:14 UTC (permalink / raw)
To: linux-arm-kernel
Mans Rullgard <mans@mansr.com> writes:
> Some SoCs have a UART with a non-standard register layout. This
> allows the debug console to work with these.
>
> Signed-off-by: Mans Rullgard <mans@mansr.com>
> ---
> I would have preferred a more accurate description of the UART, but I've
> not managed to figure out who the vendor is.
I've been informed it is provided by Palmchip. I'll make a new patch.
--
M?ns Rullg?rd
mans at mansr.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: debug: add support for alternate 8250 register layout
2015-10-02 12:12 [PATCH] ARM: debug: add support for alternate 8250 register layout Mans Rullgard
2015-10-02 14:14 ` Måns Rullgård
@ 2015-10-02 14:19 ` Sergei Shtylyov
2015-10-02 14:26 ` Måns Rullgård
1 sibling, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2015-10-02 14:19 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 10/2/2015 3:12 PM, Mans Rullgard wrote:
> Some SoCs have a UART with a non-standard register layout. This
> allows the debug console to work with these.
> Signed-off-by: Mans Rullgard <mans@mansr.com>
> ---
> I would have preferred a more accurate description of the UART, but I've
> not managed to figure out who the vendor is.
You haven't seem the Alchemy datasheets? I can send you some if so.
> ---
> arch/arm/Kconfig.debug | 4 ++++
> arch/arm/include/debug/8250.S | 12 ++++++++++++
> 2 files changed, 16 insertions(+)
>
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 0cfd7f9..8d5c837 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -1597,6 +1597,10 @@ config DEBUG_UART_8250_WORD
> DEBUG_BCM_KONA_UART || DEBUG_RK32_UART2 || \
> DEBUG_BRCMSTB_UART
>
> +config DEBUG_UART_8250_AU
> + bool "8250 UART has Alchemy register layout"
> + depends on DEBUG_LL_UART_8250 || DEBUG_UART_8250
> +
So Alchemy UART got reused on ARM?
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: debug: add support for alternate 8250 register layout
2015-10-02 14:19 ` Sergei Shtylyov
@ 2015-10-02 14:26 ` Måns Rullgård
2015-10-02 14:32 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: Måns Rullgård @ 2015-10-02 14:26 UTC (permalink / raw)
To: linux-arm-kernel
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> writes:
> Hello.
>
> On 10/2/2015 3:12 PM, Mans Rullgard wrote:
>
>> Some SoCs have a UART with a non-standard register layout. This
>> allows the debug console to work with these.
>
>> Signed-off-by: Mans Rullgard <mans@mansr.com>
>> ---
>> I would have preferred a more accurate description of the UART, but I've
>> not managed to figure out who the vendor is.
>
> You haven't seem the Alchemy datasheets? I can send you some if so.
I have. They don't say where Alchemy bought the UART block.
>> ---
>> arch/arm/Kconfig.debug | 4 ++++
>> arch/arm/include/debug/8250.S | 12 ++++++++++++
>> 2 files changed, 16 insertions(+)
>>
>> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
>> index 0cfd7f9..8d5c837 100644
>> --- a/arch/arm/Kconfig.debug
>> +++ b/arch/arm/Kconfig.debug
>> @@ -1597,6 +1597,10 @@ config DEBUG_UART_8250_WORD
>> DEBUG_BCM_KONA_UART || DEBUG_RK32_UART2 || \
>> DEBUG_BRCMSTB_UART
>>
>> +config DEBUG_UART_8250_AU
>> + bool "8250 UART has Alchemy register layout"
>> + depends on DEBUG_LL_UART_8250 || DEBUG_UART_8250
>> +
>
> So Alchemy UART got reused on ARM?
The UART is actually a Palmchip IP core used by several SoC companies.
--
M?ns Rullg?rd
mans at mansr.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: debug: add support for alternate 8250 register layout
2015-10-02 14:26 ` Måns Rullgård
@ 2015-10-02 14:32 ` Sergei Shtylyov
2015-10-02 14:37 ` Måns Rullgård
0 siblings, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2015-10-02 14:32 UTC (permalink / raw)
To: linux-arm-kernel
On 10/2/2015 5:26 PM, M?ns Rullg?rd wrote:
>>> Some SoCs have a UART with a non-standard register layout. This
>>> allows the debug console to work with these.
>>
>>> Signed-off-by: Mans Rullgard <mans@mansr.com>
>>> ---
>>> I would have preferred a more accurate description of the UART, but I've
>>> not managed to figure out who the vendor is.
>>
>> You haven't seem the Alchemy datasheets? I can send you some if so.
>
> I have. They don't say where Alchemy bought the UART block.
In fact, seeing at least Au1550 databook googling for "alchemy databook".
The UART registers are described there. Perhaps, it's not accurate enought for
your needs, though...
>>> ---
>>> arch/arm/Kconfig.debug | 4 ++++
>>> arch/arm/include/debug/8250.S | 12 ++++++++++++
>>> 2 files changed, 16 insertions(+)
>>>
>>> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
>>> index 0cfd7f9..8d5c837 100644
>>> --- a/arch/arm/Kconfig.debug
>>> +++ b/arch/arm/Kconfig.debug
>>> @@ -1597,6 +1597,10 @@ config DEBUG_UART_8250_WORD
>>> DEBUG_BCM_KONA_UART || DEBUG_RK32_UART2 || \
>>> DEBUG_BRCMSTB_UART
>>>
>>> +config DEBUG_UART_8250_AU
>>> + bool "8250 UART has Alchemy register layout"
>>> + depends on DEBUG_LL_UART_8250 || DEBUG_UART_8250
>>> +
>>
>> So Alchemy UART got reused on ARM?
>
> The UART is actually a Palmchip IP core used by several SoC companies.
Hm, how have you figured out that;s Palmchip if the Alchemy databooks are
silent about that? :-)
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: debug: add support for alternate 8250 register layout
2015-10-02 14:32 ` Sergei Shtylyov
@ 2015-10-02 14:37 ` Måns Rullgård
0 siblings, 0 replies; 6+ messages in thread
From: Måns Rullgård @ 2015-10-02 14:37 UTC (permalink / raw)
To: linux-arm-kernel
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> writes:
> On 10/2/2015 5:26 PM, M?ns Rullg?rd wrote:
>
>>>> Some SoCs have a UART with a non-standard register layout. This
>>>> allows the debug console to work with these.
>>>
>>>> Signed-off-by: Mans Rullgard <mans@mansr.com>
>>>> ---
>>>> I would have preferred a more accurate description of the UART, but I've
>>>> not managed to figure out who the vendor is.
>>>
>>> You haven't seem the Alchemy datasheets? I can send you some if so.
>>
>> I have. They don't say where Alchemy bought the UART block.
>
> In fact, seeing at least Au1550 databook googling for "alchemy databook".
> The UART registers are described there. Perhaps, it's not accurate
> enought for your needs, though...
I have all the information I need about how it works.
>>>> ---
>>>> arch/arm/Kconfig.debug | 4 ++++
>>>> arch/arm/include/debug/8250.S | 12 ++++++++++++
>>>> 2 files changed, 16 insertions(+)
>>>>
>>>> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
>>>> index 0cfd7f9..8d5c837 100644
>>>> --- a/arch/arm/Kconfig.debug
>>>> +++ b/arch/arm/Kconfig.debug
>>>> @@ -1597,6 +1597,10 @@ config DEBUG_UART_8250_WORD
>>>> DEBUG_BCM_KONA_UART || DEBUG_RK32_UART2 || \
>>>> DEBUG_BRCMSTB_UART
>>>>
>>>> +config DEBUG_UART_8250_AU
>>>> + bool "8250 UART has Alchemy register layout"
>>>> + depends on DEBUG_LL_UART_8250 || DEBUG_UART_8250
>>>> +
>>>
>>> So Alchemy UART got reused on ARM?
>>
>> The UART is actually a Palmchip IP core used by several SoC companies.
>
> Hm, how have you figured out that;s Palmchip if the Alchemy
> databooks are silent about that? :-)
Someone with access to hardware design files told me.
--
M?ns Rullg?rd
mans at mansr.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-10-02 14:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-02 12:12 [PATCH] ARM: debug: add support for alternate 8250 register layout Mans Rullgard
2015-10-02 14:14 ` Måns Rullgård
2015-10-02 14:19 ` Sergei Shtylyov
2015-10-02 14:26 ` Måns Rullgård
2015-10-02 14:32 ` Sergei Shtylyov
2015-10-02 14:37 ` Måns Rullgård
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).