From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD480C2B9F7 for ; Tue, 25 May 2021 00:39:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B3CA6128D for ; Tue, 25 May 2021 00:39:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B3CA6128D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xs4all.nl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-ID:References:Subject :In-Reply-To:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6tATgdNxCDjplxwM1URjuZyriA4epZZ6a9fezLg4Mio=; b=z7j9oVDeMEanKn LQiAOjHsmyMC5GA/pepvqvO8oqBvJajoe6BCpf/+Nx03e9o9FClp+K7BvQhNfenTHaaS2H6Dk+g2M ekNqt8ulYm8OSrbIzlUTkH4VRGWgST0zNyWev5C2esJqHjviIWWdLQLB9wOT5jfYKM89e7qvGW+Ci /2/6neQx9DK6UrJKWbWr0Unc2+BgMN7mJmY/x1yTdGAHtTtNi5dec3GJV/Y3TtSZX4XkJo1u7/jnr xDakEEjcdxM21piUMbXnB+plNudaeT51iFMB54BdbQMVNjBD7tzKhcTp2vNeGebhrgylkjdzCAE4m VA+BrTqX0exMvkApjclg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llL4X-002anB-2P; Tue, 25 May 2021 00:37:25 +0000 Received: from sibelius.xs4all.nl ([83.163.83.176]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1llEV2-001Ill-0n for linux-arm-kernel@lists.infradead.org; Mon, 24 May 2021 17:36:22 +0000 Received: from localhost (bloch.sibelius.xs4all.nl [local]) by bloch.sibelius.xs4all.nl (OpenSMTPD) with ESMTPA id c4427888; Mon, 24 May 2021 19:36:10 +0200 (CEST) Date: Mon, 24 May 2021 19:36:10 +0200 (CEST) From: Mark Kettenis To: Zhen Lei Cc: shawnguo@kernel.org, leoyang.li@nxp.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, thunder.leizhen@huawei.com In-Reply-To: <20210524035244.8677-1-thunder.leizhen@huawei.com> (message from Zhen Lei on Mon, 24 May 2021 11:52:44 +0800) Subject: Re: [PATCH 1/1] arm64: dts: lx2160a: Normalize the compatible string of "arm, sbsa-uart" References: <20210524035244.8677-1-thunder.leizhen@huawei.com> Message-ID: <5612f2cad25a3041@bloch.sibelius.xs4all.nl> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_103620_415317_CCAB2B47 X-CRM114-Status: GOOD ( 16.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > From: Zhen Lei > Date: Mon, 24 May 2021 11:52:44 +0800 > Content-Type: text/plain; charset="us-ascii" > > The compatible string of ARM SBSA defined generic UART needs to contain > only "arm,sbsa-uart" and does not need to contain "arm,pl011". Otherwise, > the pl011.yaml will check it and falsely report many warnings similar to > the following: > > arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dt.yaml: > serial@21c0000: compatible:0: 'arm,pl011' was expected > serial@21c0000: compatible:1: 'arm,primecell' was expected > > Delete the redundant "arm,pl011" to fix it. According to its reference manual, the LX2160A has a full PL011 implementation. So I think this is the wrong "fix". > Signed-off-by: Zhen Lei > --- > arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > index 4fcc869c21a4..417546616d85 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > @@ -920,7 +920,7 @@ > }; > > uart0: serial@21c0000 { > - compatible = "arm,sbsa-uart","arm,pl011"; > + compatible = "arm,sbsa-uart"; > reg = <0x0 0x21c0000 0x0 0x1000>; > interrupts = ; > current-speed = <115200>; > @@ -928,7 +928,7 @@ > }; > > uart1: serial@21d0000 { > - compatible = "arm,sbsa-uart","arm,pl011"; > + compatible = "arm,sbsa-uart"; > reg = <0x0 0x21d0000 0x0 0x1000>; > interrupts = ; > current-speed = <115200>; > @@ -936,7 +936,7 @@ > }; > > uart2: serial@21e0000 { > - compatible = "arm,sbsa-uart","arm,pl011"; > + compatible = "arm,sbsa-uart"; > reg = <0x0 0x21e0000 0x0 0x1000>; > interrupts = ; > current-speed = <115200>; > @@ -944,7 +944,7 @@ > }; > > uart3: serial@21f0000 { > - compatible = "arm,sbsa-uart","arm,pl011"; > + compatible = "arm,sbsa-uart"; > reg = <0x0 0x21f0000 0x0 0x1000>; > interrupts = ; > current-speed = <115200>; > -- > 2.21.1 > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel