From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40468FA373D for ; Mon, 24 Oct 2022 08:16:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Cc:To:From:Subject:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8UooOqz711lNZc49bGaObLDATzBSjgBTQeyYdQzoMQc=; b=2ZMDuTr70v95YK smdwjGUBpy7MQ2V7X3roUqdCUOnMDoRiblH4Yg5ffR3Vq8p4p/EcIlHEgMnVdMjlFFvb+jX0SeSdG KnJHa0ELXD3nGX3xZL8D20irTPWPtDhHQad9Patm54eNenYmvbjy586fm1Rv7mnvWQ7jMX2E05Gg8 MsMRHbVTgn2hSBbmqfuOUg1DYJeeLzXuyxcur4NkS3ZTsHg8jesJ0xhxM7d9Q6VjLqO3/ldxJ9ggd tbvx9ASRYfgpoAtyKYLuJVlnXSB5Ya0WWeVYMCqRFirRcAZyNsT7ptyLANcrsj5oTyZ1aE4QcjD6P t2sIiqYtN5QAzfmXyonQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1omsca-0002UR-5u; Mon, 24 Oct 2022 08:15:44 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1omscV-0002QP-8U for linux-arm-kernel@lists.infradead.org; Mon, 24 Oct 2022 08:15:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1666599339; x=1698135339; h=subject:from:to:cc:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bXK1aob4hsgkJ/UGYit2zlsv7bO/CwXtzWh4iUKBUo0=; b=q+Rc3unsTVdz/m8oiw+wqGicse5nbX0VsajFoE9XZ9A26dc/JJmnjzG3 lFfLUtz+hFAUc5CZrx+qIGcnBAWO70QMFf6iS9d36fmwI732Z67IEffwi 3IymGfKc7LSH7obSUbEj28TYhMBFx3wH3HMjJE+ztwUPO4WYX1K+PNFxN RXLkMkITFdrolwu4jBihSCkEqYDD7beTrfZnKcLCXjiPcrZ3UiPiDwoO/ wjvVnrJ28YEozXbkAAMGPKfxMs7+WOA5uieAdGqTTJaiXiH9EQ5f8FxdP tU0Z/jRIhB/gEfnOKJrYhmVk4pE25Txc2yZXUypLg47FczwYALGXL91Xc g==; X-IronPort-AV: E=Sophos;i="5.95,207,1661810400"; d="scan'208";a="26924517" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 24 Oct 2022 10:15:33 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Mon, 24 Oct 2022 10:15:33 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Mon, 24 Oct 2022 10:15:33 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1666599333; x=1698135333; h=from:to:cc:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding:subject; bh=bXK1aob4hsgkJ/UGYit2zlsv7bO/CwXtzWh4iUKBUo0=; b=dgxuaPcQRu47kty6E1B3j72SQuvSi4SSRsULH/Re7ExY99PBtoUVF4PS 6yIsjuWWrOygfm1w7Crn2hQhrCPvrQ06dr9g5CgVTSNATzizF88jA3RJQ uz6rNeLDDTU6lNhI1PIfRA7G0CcogkATsmV1tPLL/uImrzc1mYmKwzGnd UMqJJhspkBPce2uCRb8Nbvx8z9frxvx4vh5c+ErcGKbKAcILtPqilsuhY JVCI/R5DE0qcu1ShnDoI/d69Gy1UX7WEHXOh5vlGApga95ZR0aEr6VZGm vRGyzKLxLcX6zk7pC7W/0sxhLg9rNpCWsKow1R4BAoPgAwku53fU1UIgQ g==; X-IronPort-AV: E=Sophos;i="5.95,207,1661810400"; d="scan'208";a="26924516" Subject: Re: Re: [PATCH 1/1] arm64: dts: imx8mm-tqma8mqml-mba8mx: Fix USB DR Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 24 Oct 2022 10:15:33 +0200 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 04411280056; Mon, 24 Oct 2022 10:15:33 +0200 (CEST) From: Alexander Stein To: Shawn Guo Cc: Rob Herring , Krzysztof Kozlowski , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Mon, 24 Oct 2022 10:15:28 +0200 Message-ID: <5614294.DvuYhMxLoT@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20221024013123.GV125525@dragon> References: <20220926112622.2912885-1-alexander.stein@ew.tq-group.com> <20221024013123.GV125525@dragon> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221024_011539_760130_28629508 X-CRM114-Status: GOOD ( 22.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Shawn, Am Montag, 24. Oktober 2022, 03:31:23 CEST schrieb Shawn Guo: > On Mon, Sep 26, 2022 at 01:26:22PM +0200, Alexander Stein wrote: > > extcon does not work somehow, so switch to usb-role-switch instead. > > So extcon was added without testing? It had been tested, but apparently only the USB Host case :( extcon itself does work and detects ID pin correctly. Cable states switch when a USB device (mass storage) is attached and removed, thus mass storage is detect and usable. But unfortunately this is not the case for USB device using g_serial udc driver. IMHO this seems to be a problem within chipidea usb driver. Using usb-role-switch instead, both USB host and USB device do work. Best regards, Alexander > Shawn > > > Fixes: dfcd1b6f7620 ("arm64: dts: freescale: add initial device tree for > > TQMa8MQML with i.MX8MM") Signed-off-by: Alexander Stein > > > > --- > > > > .../dts/freescale/imx8mm-tqma8mqml-mba8mx.dts | 32 +++++++++++++++---- > > 1 file changed, 26 insertions(+), 6 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dts > > b/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dts index > > bfb44630da6b..56323c989d55 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dts > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dts > > @@ -34,11 +34,25 @@ reg_usdhc2_vmmc: regulator-vmmc { > > > > off-on-delay-us = <12000>; > > > > }; > > > > - extcon_usbotg1: extcon-usbotg1 { > > - compatible = "linux,extcon-usb-gpio"; > > + connector { > > + compatible = "gpio-usb-b-connector", "usb-b-connector"; > > + type = "micro"; > > + label = "X19"; > > > > pinctrl-names = "default"; > > > > - pinctrl-0 = <&pinctrl_usb1_extcon>; > > - id-gpio = <&gpio1 10 GPIO_ACTIVE_HIGH>; > > + pinctrl-0 = <&pinctrl_usb1_connector>; > > + id-gpios = <&gpio1 10 GPIO_ACTIVE_HIGH>; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + usb_dr_connector: endpoint { > > + remote-endpoint = <&usb1_drd_sw>; > > + }; > > + }; > > + }; > > > > }; > > > > }; > > > > @@ -106,13 +120,19 @@ &usbotg1 { > > > > pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_usbotg1>; > > dr_mode = "otg"; > > > > - extcon = <&extcon_usbotg1>; > > > > srp-disable; > > hnp-disable; > > adp-disable; > > power-active-high; > > over-current-active-low; > > > > + usb-role-switch; > > > > status = "okay"; > > > > + > > + port { > > + usb1_drd_sw: endpoint { > > + remote-endpoint = <&usb_dr_connector>; > > + }; > > + }; > > > > }; > > > > &usbotg2 { > > > > @@ -242,7 +262,7 @@ pinctrl_usbotg1: usbotg1grp { > > > > ; > > > > }; > > > > - pinctrl_usb1_extcon: usb1-extcongrp { > > + pinctrl_usb1_connector: usb1-connectorgrp { > > > > fsl,pins = ; > > > > }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel