linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: nikolay@cumulusnetworks.com (Nikolay Aleksandrov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] bridge/netfilter: avoid unused label warning
Date: Tue, 6 Oct 2015 23:02:45 +0200	[thread overview]
Message-ID: <561436F5.70409@cumulusnetworks.com> (raw)
In-Reply-To: <5966552.c0Emgm27oa@wuerfel>

On 10/06/2015 09:39 PM, Arnd Bergmann wrote:
> On Tuesday 06 October 2015 21:28:29 Nikolay Aleksandrov wrote:
>> I posted a fix for this a couple of days ago, but I like your approach better.
>> Since mine is not yet applied (I sent it to netfilter-devel only, wasn't sure which
>> jurisdiction this falls into exactly) we can drop it.
>> Just for reference my patch is here:
>> http://patchwork.ozlabs.org/patch/526417/
>> Pablo, could you please drop it ?
>>
>> By the way this takes care of another warning about unused variable (nf_bridge), too.
> 
> Hmm I did not get that one, at least not in 4.3-rc4.
> 
You need to set W=1
$ git describe --abbrev=0
v4.3-rc4

net/bridge//br_netfilter_hooks.c: In function ?br_nf_dev_queue_xmit?:
net/bridge//br_netfilter_hooks.c:794:2: warning: label ?drop? defined but not used [-Wunused-label]
  drop:
  ^
net/bridge//br_netfilter_hooks.c:727:25: warning: variable ?nf_bridge? set but not used [-Wunused-but-set-variable]
  struct nf_bridge_info *nf_bridge;

Cheers,
 Nik

>> Reviewed-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> 
> Thanks and sorry for missing the Cc to the netfilter list on my patch.
> 
> 	Arnd

  reply	other threads:[~2015-10-06 21:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-06 19:22 [PATCH] bridge/netfilter: avoid unused label warning Arnd Bergmann
2015-10-06 19:28 ` Nikolay Aleksandrov
2015-10-06 19:39   ` Arnd Bergmann
2015-10-06 21:02     ` Nikolay Aleksandrov [this message]
2015-10-08 11:42 ` David Miller
2015-10-08 12:30   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561436F5.70409@cumulusnetworks.com \
    --to=nikolay@cumulusnetworks.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).