From mboxrd@z Thu Jan 1 00:00:00 1970 From: neidhard.kim@lge.com (Jongsung Kim) Date: Wed, 7 Oct 2015 12:55:08 +0900 Subject: [PATCH] ARM:mm: fix kmap_atomic_to_page In-Reply-To: References: <1444129773-12632-1-git-send-email-chanho.min@lge.com> <20151006192836.GX21513@n2100.arm.linux.org.uk> Message-ID: <5614979C.30100@lge.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Recently, we made a driver utilizing kmap_atomic_to_page. Of course, it's not mainlined. People may be using it outside mainline just like us. vmalloc has vmalloc_to_page, pkmap has kmap_to page, and fixmap has kmap_atomic_to_page. Then.. how about letting virt_to_page do them all? On 10/07/2015 10:37 AM, Nicolas Pitre wrote: > On Tue, 6 Oct 2015, Russell King - ARM Linux wrote: > >> On Tue, Oct 06, 2015 at 08:09:33PM +0900, Chanho Min wrote: >>> Since kmap_atomic returns the pkmap address without a new mapping to >>> fixmap for the page that is already mapped by kmap, It should be >>> considered for the pkmap address in kmap_atomic_to_page. >> What's the reasoning behind this change, given that I can find lots of >> definitions of kmap_atomic_to_page() in the kernel, but not a single >> user of this. >> >> If there's no users, should we be deleting this code? > I think commit 5bbeed12bdc3 provides the answer to that question. > > > Nicolas >