From: rogerq@ti.com (Roger Quadros)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] memory: omap-gpmc: expand the description of the debug facility
Date: Wed, 7 Oct 2015 10:45:50 +0300 [thread overview]
Message-ID: <5614CDAE.6070604@ti.com> (raw)
In-Reply-To: <1444162070-22034-2-git-send-email-u.kleine-koenig@pengutronix.de>
On 06/10/15 23:07, Uwe Kleine-K?nig wrote:
> Most register values for the chip select setup depend on the frequency
> of the fck clock.
> So add a hint that the values setup by the bootloader might differ from
> the right setup for Linux if the bootloader uses a different frequency.
>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> ---
> drivers/memory/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
> index c6a644b22af4..1414dd53be57 100644
> --- a/drivers/memory/Kconfig
> +++ b/drivers/memory/Kconfig
> @@ -64,6 +64,9 @@ config OMAP_GPMC_DEBUG
> Enables verbose debugging mostly to decode the bootloader provided
> timings. Enable this during development to configure devices
> connected to the GPMC bus.
> + Note that you cannot just tweak your device tree until the registers
> + setup by linux match what the bootloader did because that one might
> + use a different fck frequency influencing most register settings.
Looks like we can't know for sure the GPMC fclk used at the bootloader
else we could have just printed the GPMC fclk pre and post gpmc settings.
How about this instead?
NOTE: Apart from matching the register setup with the bootloader you also need to
match the GPMC FCLK frequency used by the bootloader else the GPMC timings
won't be identical with the bootloader timings.
Also you might need to build this patch on top of
http://article.gmane.org/gmane.linux.kernel/2054796
>
> config MVEBU_DEVBUS
> bool "Marvell EBU Device Bus Controller"
>
cheers,
-roger
next prev parent reply other threads:[~2015-10-07 7:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 20:07 [PATCH 1/2] memory: omap-gpmc: dump "before" state before first modification Uwe Kleine-König
2015-10-06 20:07 ` [PATCH 2/2] memory: omap-gpmc: expand the description of the debug facility Uwe Kleine-König
2015-10-07 7:45 ` Roger Quadros [this message]
2015-10-07 7:53 ` Uwe Kleine-König
2015-10-07 10:41 ` Tony Lindgren
2015-10-07 11:02 ` Uwe Kleine-König
2015-10-07 11:07 ` Roger Quadros
2015-10-07 13:40 ` Tony Lindgren
2015-10-07 13:55 ` Roger Quadros
2015-10-07 7:37 ` [PATCH 1/2] memory: omap-gpmc: dump "before" state before first modification Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5614CDAE.6070604@ti.com \
--to=rogerq@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).