linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: slash.tmp@free.fr (Mason)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] twd: Don't set CLOCK_EVT_FEAT_C3STOP unconditionally
Date: Thu, 8 Oct 2015 20:25:07 +0200	[thread overview]
Message-ID: <5616B503.6090408@free.fr> (raw)
In-Reply-To: <20151008175734.GH7275@leverpostej>

On 08/10/2015 19:57, Mark Rutland wrote:
>> Is it possible that twd_local_timer_common_register() would be
>> called more than once?
>>
>> twd_local_timer_register() guards against multiple invocations,
>> but twd_local_timer_of_register() doesn't (but maybe there is
>> some guarantee from OF, or it's invalid to have multiple
>> "arm,cortex-a9-twd-timer" strings in the DT).
> 
> It does appear that were you to have have two or more
> "arm,cortex-a9-twd-timer" nodes in the DT, things would go wrong. As far
> as I am aware, that would result in multiple calls to
> twd_local_timer_of_register.
> 
> I don't think it would ever be valid to have two nodes for this
> particular device, but it's probably worth having the same check as
> twd_local_timer_register does, with a warning that there was more than
> one such node logged to the console.

Hmmm, I think I'll do it in a follow-up patch, once Felipe's
revert hits mainline.

Regards.

  reply	other threads:[~2015-10-08 18:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-05  8:58 [PATCH] twd: Don't set CLOCK_EVT_FEAT_C3STOP unconditionally Marc Gonzalez
2015-10-05  9:17 ` [PATCH v2] " Marc Gonzalez
2015-10-05  9:22   ` Linus Walleij
2015-10-05  9:50     ` [PATCH v3] " Marc Gonzalez
2015-10-05 10:35       ` Mark Rutland
2015-10-05 11:53         ` [PATCH v4] " Marc Gonzalez
2015-10-05 16:37           ` Marc Gonzalez
2015-10-07 12:14             ` Marc Gonzalez
2015-10-08 17:16           ` Mark Rutland
2015-10-08 17:38             ` Mason
2015-10-08 17:43               ` Russell King - ARM Linux
2015-10-08 18:16                 ` Mason
2015-10-08 18:22                   ` Russell King - ARM Linux
2015-10-08 18:37                     ` Mason
2015-10-08 17:57               ` Mark Rutland
2015-10-08 18:25                 ` Mason [this message]
2015-10-08 18:34                   ` Mark Rutland
2015-10-09  9:29             ` Marc Gonzalez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5616B503.6090408@free.fr \
    --to=slash.tmp@free.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).