From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6468BC433E8 for ; Mon, 20 Jul 2020 07:39:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CC942073A for ; Mon, 20 Jul 2020 07:39:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OiBmqPeS"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=toradex.com header.i=@toradex.com header.b="McOBU4p2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CC942073A Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=toradex.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PUvbo2vfDMEAD5EXXj7iM/Sqw1aM0U3Xsbi38vAluxY=; b=OiBmqPeSgHiVxOv5aptXiOjjt dN2ZbRYBxsI29owihojFmfSGBxdwDgnkpwosLJS83O/hONCB5o2B4BHOcxqmAP2U/Lp7vM2R5y6SJ sc8gpPNV8jY9LcWFmREzyTP3MYlyOkqHH/sHAuzwvyT1m2Mc/wXSonF4oQxO3gENTHVLGc+VevIYk 3aG8n6XMMHrt57nQjEYyWO+t1pox3WWnA6cPgXl+4aw/dO0BrPcIQpcnI1PQ9+LjLUueR2RrysSl/ kkVVM0D0Gos0gAiCB3ux4VbZ4N/Sqto8D75gDpZioC7n2jurcOrwBMaNndH9rA466bIt2GkJ9Ay71 CnIF74BHg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxQN7-0004qR-Aw; Mon, 20 Jul 2020 07:38:01 +0000 Received: from mail-eopbgr60127.outbound.protection.outlook.com ([40.107.6.127] helo=EUR04-DB3-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxQN5-0004or-1k for linux-arm-kernel@lists.infradead.org; Mon, 20 Jul 2020 07:38:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IMVrl0haBbZvELOc4cWajlGQBHHMMW52AZ296D0+8qCl3DjBOg1K7JIW48vvEo7icK9CrrwJQZvATef2Ug2KIKRWucv1ufiqAM5+Vw0rvr9kkyONlgd5uxQuMghD56DAbg//+Yh5AZx6Co7SCG+ZmkhVICe8/CdKgd1Cao7BsT7yP9JqTklYLLZF5CJ/cKjmZxjgWvt1N4SIOXosiXa4DUjgUJEnMHqmZpBxF4ujBpjPXbR42IyFDXN3FV2wcTb6gewND35x8yeViABd/IpM3b6rMwOV4e/iRo4khvtvP1Uc00XN/+8DdyGsnIiXvXQVLR7/fBxv1Fdu1HL3mEdulw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0LU13Jc9P/E/+ipreowxqO3opi/1WjNvPqr+Nj3D2sI=; b=B8jErASusI0mpHdITecIE5FP9CBd0vI5TWLS+qvVHjmm3kqkqoFBrWTVtT1yLIRDI0uiRERZYb+2AFOOCwtiY7UL4KGyhLixNDTacMfIItj7ZbAu9M4i0bhsLzJ0Jw6SHSVEHlRhove3yBZ7OkDOENF5Qwla8lFUCE0tKuOhMpcQTZY7ayt4iQEEkYazefJuixXUNxPYn8+jFvAoFJ2AfVh3iK9rqCghfDTXGDTuxxbeEZU3Y5a9f8YB9XZCk0CBbc7TskkhYYm0Ewa9MxibG7vEtEluIFLdu2eGG0b6Q3ti4XoLWaepbAxvEzk6yRzNKGi14LY9KrUu4CYraEqcPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=toradex.com; dmarc=pass action=none header.from=toradex.com; dkim=pass header.d=toradex.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toradex.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0LU13Jc9P/E/+ipreowxqO3opi/1WjNvPqr+Nj3D2sI=; b=McOBU4p2YEDO9IWlSCHgyv0Yh1VBMX+NIqVJ6rJR7swg2mdeFtZu7FImMFpFYp2B6q/c+XxL/gLnVbz9dMyMqExmoAYHRtTg3PpEN9expnxBzvRqXwgsFfXCDBl17mzlQi4IBI6SROSy2Z+euR45F8gL8Gt3wV8WHNoeQMnNZyE= Received: from AM6PR05MB6120.eurprd05.prod.outlook.com (2603:10a6:20b:a8::25) by AM6PR05MB6376.eurprd05.prod.outlook.com (2603:10a6:20b:ba::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.18; Mon, 20 Jul 2020 07:37:48 +0000 Received: from AM6PR05MB6120.eurprd05.prod.outlook.com ([fe80::1d81:6a9b:8c26:3b7d]) by AM6PR05MB6120.eurprd05.prod.outlook.com ([fe80::1d81:6a9b:8c26:3b7d%4]) with mapi id 15.20.3195.025; Mon, 20 Jul 2020 07:37:48 +0000 From: Philippe Schenker To: "shawnguo@kernel.org" Subject: Re: [PATCH 3/3] ARM: dts: colibri-imx7: add usb dual-role switch capability Thread-Topic: [PATCH 3/3] ARM: dts: colibri-imx7: add usb dual-role switch capability Thread-Index: AQHWVr15sZvxLwnO3E+b+KcqajdLWakFR14AgAAjuQCAAU+xgIAABwcAgAkG2gCAAFsvgA== Date: Mon, 20 Jul 2020 07:37:48 +0000 Message-ID: <5616f6e189845de7c4acfd9eede540ef6e6e9eb0.camel@toradex.com> References: <20200710132423.497230-1-philippe.schenker@toradex.com> <20200710132423.497230-3-philippe.schenker@toradex.com> <73240ab0-5069-40c5-4ade-7fcc2207dfaf@pengutronix.de> <7e6f8135-120f-0831-20ad-25648ea646b8@pengutronix.de> <83b230cef109e1a413ab1036c21ad763a1d127eb.camel@toradex.com> <20200720021125.GC11560@dragon> In-Reply-To: <20200720021125.GC11560@dragon> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.3 authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=toradex.com; x-originating-ip: [31.10.206.124] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9aadc937-788c-4905-d970-08d82c7fcce7 x-ms-traffictypediagnostic: AM6PR05MB6376: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0qyIQcgXWEzqsQwutELF0M5yq2c1/5widbUTTqiXpz0rSFIZBqiFX+fBMntI8wCkE4aG1Sns9dK8OsxbrtcrBh8Iepyf2qhjQ7z1zrt9Rx6P/BeAa1qS6Zy7JzxmTm7wwbqDnb5Sljiobp9Kyn04CRfSzzDnetWzdI2psXF6hnCcombefCT1FXRqE4lvcHKNiWTHXIT8VOD+vKRGneFfXJiVJrZpYidSlVqVAuP7uDYzgK7lRaydWialf3fff4hDVSj66riHOLv9ywnf8eHi/8WfxwdILjDRiQo1yh4RZ24mTj6JFM6ok2wtDFH5TrMkmQLNK5Ep2zuPtXEQ0N+bWA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR05MB6120.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39840400004)(346002)(136003)(396003)(366004)(376002)(2906002)(53546011)(6486002)(186003)(6506007)(44832011)(5660300002)(86362001)(8676002)(54906003)(66476007)(64756008)(4326008)(8936002)(7416002)(6916009)(83380400001)(66946007)(76116006)(91956017)(66446008)(66556008)(2616005)(26005)(36756003)(71200400001)(316002)(478600001)(6512007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: +9KpE0nLEWVGP/EfjNAqeiVitepbo+HNiwfnyQeJRU9bJl7O9yl6kNWra/0AXcHDfjOyhNPIzV0uJ3mWVclmZnvM0fSqEC401bBdqiCi7A1Dy6acFIJF6fOqpZ9TbntIT793y0EOF/W3iZA8LwZYP5ZjjBCLDs2Yev5bND24C6Fu+SLjmIUhY7wRH5RrwVIaNQRqVHzFpe/ERRaCX96kqxFluT6lnezx7NFhVp6mekAkP7ZJi2FznZGPrYxphBP+m9Lm3MNYJ7IAOMz5Ak/BmHRU1eRcdpl5wIvDZ3O8wIFmquC8LZjvapdMG0d0UC2vkRq1dwC6b0YzDDfnljofEw8x5Rl4PjcxtUGhJXbMZbW7zoNPZOsvI3o3DBZznQg736gIi2bxXMQkjmM4M30v2k8r4RlGKSdtXO1b+p5rYuXhOhDPr6pPaBjCbtI2oZnT+19+VnVaJ6eB3wy2fCWOgJ3NuMqg/wltapw2JWf+tIY= x-ms-exchange-transport-forked: True Content-ID: MIME-Version: 1.0 X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR05MB6120.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9aadc937-788c-4905-d970-08d82c7fcce7 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2020 07:37:48.2700 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d9995866-0d9b-4251-8315-093f062abab4 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uerxZor4BInX8ujnVTrZY1iF0/kYyCIVXXGcaqqN7+6CtJnSj52NMRi4M1AAEwwvUT6JZ1tY+7L+3p+QASXcIRAbrglyW/mZq/5aOanvksE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB6376 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200720_033759_119374_515D2E41 X-CRM114-Status: GOOD ( 30.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "a.fatoum@pengutronix.de" , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "linux-imx@nxp.com" , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2020-07-20 at 10:11 +0800, Shawn Guo wrote: > On Tue, Jul 14, 2020 at 08:20:34AM +0000, Philippe Schenker wrote: > > On Tue, 2020-07-14 at 09:55 +0200, Ahmad Fatoum wrote: > > > Hello Philippe, > > > > > > On 7/13/20 1:53 PM, Philippe Schenker wrote: > > > > On Mon, 2020-07-13 at 11:46 +0200, Ahmad Fatoum wrote: > > > > > Hello Philippe, > > > > > > > > > > > + extcon_usbc_det: usbc_det { > > > > > > + compatible = "linux,extcon-usb-gpio"; > > > > > > > > > > According to 4602f3bff266 ("usb: common: add USB GPIO based > > > > > connection > > > > > detection driver"): > > > > > "the old way using extcon to support USB Dual-Role switch is > > > > > now > > > > > deprecated > > > > > when use Type-B connector." > > > > > > > > > > Have you considered using a compatible = "gpio-usb-b- > > > > > connector" > > > > > child > > > > > node instead? > > > > > > > > > > Cheers, > > > > > Ahmad > > > > > > > > Thanks for the Hint Ahmad, > > > > > > > > I already tried and just now tried again but it doesn't work on > > > > our > > > > hardware. Are you sure this works with chipidea driver? > > > > > > I haven't, just wanted to point its existence out in case you > > > didn't > > > know. > > > Seems we need to call of_platform_populate somewhere in the > > > driver. > > > Unsure what other changes are necessary. > > > > Yep, thanks for that! It seems like that need to be really called as > > I > > can't get a probe of the new usb connector driver. I quickly grepped > > through code and saw that tegra USB driver is calling > > of_platform_populate and they also use that gpio-usb-b-connector. > > > > > > Should this new usb-connector stuff work in general with every > > > > old > > > > driver? > > > > > > If the driver support isn't there yet, I think use of extcon is > > > fine > > > as is. > > Shouldn't we improve chipidea driver to get it work with gpio-usb-b- > connector? I know this would be nice but I don't know that code well enough to be able to make this changes in a timely manner. And I rather like to have support for USB dual-role support "the old way" now than never (we actually tried this for along time on our Colibri boards). I discovered a bug in that driver together with Peter Chen, which got now solved by him and I would like to use the host/device switching on colibri-imx6/7 boards now. > > Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel