linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card
Date: Mon, 12 Oct 2015 13:29:45 +0900	[thread overview]
Message-ID: <561B3739.4040701@samsung.com> (raw)
In-Reply-To: <1444578364-1384-1-git-send-email-linux.amoon@gmail.com>

On 12.10.2015 00:46, Anand Moon wrote:
> From: Jaehoon Chung <jh80.chung@samsung.com>
> 
> To detect sd-card use the cd-gpio method.
> It can decrease the interrupt for detecting sd-card.
> 
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> 
> ---
> Changes based on git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git v4.4-next/dt-samsung branch
> ---
>  arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> index 1af5bdc..26decbd 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> @@ -352,8 +352,10 @@
>  	samsung,dw-mshc-ciu-div = <3>;
>  	samsung,dw-mshc-sdr-timing = <0 4>;
>  	samsung,dw-mshc-ddr-timing = <0 2>;
> +	cd-gpios = <&gpc2 2 GPIO_ACTIVE_HIGH>;
> +	cd-inverted;
>  	pinctrl-names = "default";
> -	pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus1 &sd2_bus4>;
> +	pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>;

Anand,

You essentially reverted here af6ad88acbd6 ("ARM: dts: Mux XMMCnDATA[0]
pad correctly for Exynos5420 boards"). Why? There is no explanation in
the commit message about this.

Best regards,
Krzysztof

  parent reply	other threads:[~2015-10-12  4:29 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-11 15:46 [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card Anand Moon
2015-10-11 15:46 ` [PATCH 2/3] ARM: dts: use vmmc-supply of emmc/sd for exynos5422-odroidxu3 Anand Moon
2015-10-12  4:42   ` Krzysztof Kozlowski
2015-10-12  5:49     ` Krzysztof Kozlowski
2015-10-12 11:08       ` Anand Moon
2015-10-12 12:13         ` Krzysztof Kozlowski
2015-10-12 14:33           ` Anand Moon
2015-10-13  0:10             ` Krzysztof Kozlowski
2015-10-13  2:29               ` Anand Moon
2015-10-13  2:39                 ` Jaehoon Chung
2015-10-13  2:45                   ` Anand Moon
2015-10-11 15:46 ` [PATCH 3/3] ARM: dts: exynos5422-odroidxu3: Added UHS-I bus speed support Anand Moon
2015-10-12  5:44   ` Krzysztof Kozlowski
2015-10-12 10:46     ` Anand Moon
2015-10-12 10:51       ` Jaehoon Chung
2015-10-12 11:23         ` Anand Moon
2015-10-12 12:42       ` Krzysztof Kozlowski
2015-10-12 13:04         ` Jaehoon Chung
2015-10-12 13:16           ` Krzysztof Kozlowski
2015-10-13  2:28             ` Jaehoon Chung
2015-10-12 15:32     ` Anand Moon
2015-10-13  0:14       ` Krzysztof Kozlowski
2015-10-13  3:08         ` Anand Moon
2015-10-13  3:43           ` Krzysztof Kozlowski
2015-10-13  3:49             ` Anand Moon
2015-10-13 16:27             ` Anand Moon
2015-10-13 23:59               ` Krzysztof Kozlowski
2015-10-14  1:06                 ` Alim Akhtar
2015-10-14  1:15                   ` Krzysztof Kozlowski
2015-10-14  1:40                     ` Jaehoon Chung
2015-10-14  1:52                       ` Krzysztof Kozlowski
2015-10-14  2:08                         ` Alim Akhtar
2015-10-14  2:13                     ` Alim Akhtar
2015-10-14  2:20                       ` Krzysztof Kozlowski
2015-10-14  2:26                         ` Alim Akhtar
2015-10-14 22:40                   ` Doug Anderson
2015-10-19 10:11                     ` Anand Moon
2015-10-19 13:43                       ` Krzysztof Kozlowski
2015-10-19 15:11                       ` Doug Anderson
2015-10-14  3:58                 ` Anand Moon
2015-10-14  4:18                   ` Krzysztof Kozlowski
2015-10-21 10:28                   ` Jaehoon Chung
2015-10-12  4:29 ` Krzysztof Kozlowski [this message]
2015-10-12  4:43   ` [PATCH 1/3] ARM: dts: exynos5422-odroidxu3: use cd-gpio method to detect sd-card Jaehoon Chung
2015-10-12 14:47     ` Anand Moon
2015-10-13  0:12       ` Krzysztof Kozlowski
2015-10-13  2:06         ` Jaehoon Chung
2015-10-13  3:21           ` Anand Moon
2015-10-13  4:07           ` Anand Moon
2015-10-13  2:41         ` Anand Moon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561B3739.4040701@samsung.com \
    --to=k.kozlowski@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).