linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sudeep.holla@arm.com (Sudeep Holla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: change gpio-key,wakeup property to boolean
Date: Tue, 13 Oct 2015 15:26:07 +0100	[thread overview]
Message-ID: <561D147F.6090907@arm.com> (raw)
In-Reply-To: <CAL_JsqKDrvxas-x9QoLEs3yuDtEY+0u5qJZ4ZPiRQX0SrMKY2w@mail.gmail.com>



On 13/10/15 15:07, Rob Herring wrote:
> On Tue, Oct 13, 2015 at 8:32 AM, Sudeep Holla <sudeep.holla@arm.com> wrote:
>> Keyboard driver for GPIO buttons(gpio-keys) checks for the legacy
>> "gpio-key,wakeup" boolean property to enable gpio buttons as wakeup
>> source.
>>
>> Few dts files assign value "1" to gpio-key,wakeup and in one instance a
>> value "0" is assigned probably assuming it won't be enabled as a wakeup
>> source. Since the presence of the boolean property indicates it is
>> enabled, value of "0" have no value.
>>
>> This patch removes the property where value "0" is assigned and removes
>> the value "1" in most of the other cases.
>
> Why don't you just change everything to wakeup-source.
>

Agreed, I wanted to do that but was not sure if that's acceptable.
I will update it, now I know that you are fine with it.

I also plan to find all the variety of bindings we have and fix them
retaining only those which are handled in the current kernel code as
legacy support.

-- 
Regards,
Sudeep

  reply	other threads:[~2015-10-13 14:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-13 13:32 [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property Sudeep Holla
2015-10-13 13:32 ` [PATCH 2/2] ARM: dts: change gpio-key,wakeup property to boolean Sudeep Holla
2015-10-13 14:07   ` Rob Herring
2015-10-13 14:26     ` Sudeep Holla [this message]
2015-10-13 14:38   ` [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key, wakeup with wakeup-source property Sudeep Holla
2015-10-13 15:08     ` [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key,wakeup " Viresh Kumar
2015-10-13 17:52     ` [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key, wakeup " Heiko Stübner
2015-10-14  0:13 ` [PATCH 1/2] ARM: dts: fix gpio-keys " Simon Horman
2015-10-14  9:01   ` Sudeep Holla
2015-10-14 15:27 ` Sudeep Holla
2015-10-15 14:57 ` Linus Walleij
2015-10-15 15:21   ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561D147F.6090907@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).