* [PATCH] ARM: dts: am437x-gp-evm: Add wakeup interrupt source for pixcir_i2c_ts
@ 2015-10-14 5:52 Vignesh R
2015-10-14 8:46 ` Roger Quadros
0 siblings, 1 reply; 5+ messages in thread
From: Vignesh R @ 2015-10-14 5:52 UTC (permalink / raw)
To: linux-arm-kernel
On am437x-gp-evm, pixcir_i2c_ts can wakeup the system from lower power
state via pinctrl and IO daisy chain using generic wakeirq framework.
With commit 3fffd1283927 ("i2c: allow specifying separate wakeup
interrupt in device tree") i2c core allows optional wakeirq to be
specified via device tree. Add wakeup irq entry to enable pixcir_i2c_ts
to wake the system from low power state.
Signed-off-by: Vignesh R <vigneshr@ti.com>
---
arch/arm/boot/dts/am437x-gp-evm.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
index 22038f21f228..69e93af7df0d 100644
--- a/arch/arm/boot/dts/am437x-gp-evm.dts
+++ b/arch/arm/boot/dts/am437x-gp-evm.dts
@@ -581,8 +581,13 @@
attb-gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>;
+ interrupts-extended = <&gpio3 22 GPIO_ACTIVE_HIGH>,
+ <&am43xx_pinmux 0x264>;
+ interrupt-names = "tsc", "wakeup";
+
touchscreen-size-x = <1024>;
touchscreen-size-y = <600>;
+ wakeup-source;
};
ov2659 at 30 {
--
2.6.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: am437x-gp-evm: Add wakeup interrupt source for pixcir_i2c_ts
2015-10-14 5:52 [PATCH] ARM: dts: am437x-gp-evm: Add wakeup interrupt source for pixcir_i2c_ts Vignesh R
@ 2015-10-14 8:46 ` Roger Quadros
2015-10-14 9:12 ` Vignesh R
0 siblings, 1 reply; 5+ messages in thread
From: Roger Quadros @ 2015-10-14 8:46 UTC (permalink / raw)
To: linux-arm-kernel
+Dave
On 14/10/15 08:52, Vignesh R wrote:
> On am437x-gp-evm, pixcir_i2c_ts can wakeup the system from lower power
> state via pinctrl and IO daisy chain using generic wakeirq framework.
> With commit 3fffd1283927 ("i2c: allow specifying separate wakeup
> interrupt in device tree") i2c core allows optional wakeirq to be
> specified via device tree. Add wakeup irq entry to enable pixcir_i2c_ts
> to wake the system from low power state.
>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---
> arch/arm/boot/dts/am437x-gp-evm.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
> index 22038f21f228..69e93af7df0d 100644
> --- a/arch/arm/boot/dts/am437x-gp-evm.dts
> +++ b/arch/arm/boot/dts/am437x-gp-evm.dts
> @@ -581,8 +581,13 @@
>
> attb-gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>;
>
> + interrupts-extended = <&gpio3 22 GPIO_ACTIVE_HIGH>,
> + <&am43xx_pinmux 0x264>;
How does this work?
interrupts-extended property must have
1) interrupt parent
2) interrupt number
3) interrupt flags
Your change doesn't seem to comply with those requirements.
> + interrupt-names = "tsc", "wakeup";
> +
> touchscreen-size-x = <1024>;
> touchscreen-size-y = <600>;
> + wakeup-source;
> };
>
> ov2659 at 30 {
>
cheers,
-roger
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: am437x-gp-evm: Add wakeup interrupt source for pixcir_i2c_ts
2015-10-14 8:46 ` Roger Quadros
@ 2015-10-14 9:12 ` Vignesh R
2015-10-14 11:04 ` Roger Quadros
0 siblings, 1 reply; 5+ messages in thread
From: Vignesh R @ 2015-10-14 9:12 UTC (permalink / raw)
To: linux-arm-kernel
On 10/14/2015 02:16 PM, Roger Quadros wrote:
>
> On 14/10/15 08:52, Vignesh R wrote:
>> On am437x-gp-evm, pixcir_i2c_ts can wakeup the system from lower power
>> state via pinctrl and IO daisy chain using generic wakeirq framework.
>> With commit 3fffd1283927 ("i2c: allow specifying separate wakeup
>> interrupt in device tree") i2c core allows optional wakeirq to be
>> specified via device tree. Add wakeup irq entry to enable pixcir_i2c_ts
>> to wake the system from low power state.
>>
>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>> ---
>> arch/arm/boot/dts/am437x-gp-evm.dts | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
>> index 22038f21f228..69e93af7df0d 100644
>> --- a/arch/arm/boot/dts/am437x-gp-evm.dts
>> +++ b/arch/arm/boot/dts/am437x-gp-evm.dts
>> @@ -581,8 +581,13 @@
>>
>> attb-gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>;
>>
>> + interrupts-extended = <&gpio3 22 GPIO_ACTIVE_HIGH>,
>> + <&am43xx_pinmux 0x264>;
>
> How does this work?
>
> interrupts-extended property must have
> 1) interrupt parent
> 2) interrupt number
> 3) interrupt flags
>
> Your change doesn't seem to comply with those requirements.
AFAIU, interrupts-extended has two parts: interrupt parent phandle and
interrupt specifier.
The number of cells in interrupt specifier is determined by
interrupt-cells property of interrupt parent node.
In above case, gpio3 has interrupt-cells = 2 hence interrupt specifier
has interrupt number and interrupt flag field.
But in case am43xx_pinmux node, interrupt-cells is 1 hence has no
interrupt flag field.
--
Regards
Vignesh
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: am437x-gp-evm: Add wakeup interrupt source for pixcir_i2c_ts
2015-10-14 9:12 ` Vignesh R
@ 2015-10-14 11:04 ` Roger Quadros
2015-10-14 11:37 ` Vignesh R
0 siblings, 1 reply; 5+ messages in thread
From: Roger Quadros @ 2015-10-14 11:04 UTC (permalink / raw)
To: linux-arm-kernel
Vignesh,
On 14/10/15 12:12, Vignesh R wrote:
>
>
> On 10/14/2015 02:16 PM, Roger Quadros wrote:
>
>>
>> On 14/10/15 08:52, Vignesh R wrote:
>>> On am437x-gp-evm, pixcir_i2c_ts can wakeup the system from lower power
>>> state via pinctrl and IO daisy chain using generic wakeirq framework.
>>> With commit 3fffd1283927 ("i2c: allow specifying separate wakeup
>>> interrupt in device tree") i2c core allows optional wakeirq to be
>>> specified via device tree. Add wakeup irq entry to enable pixcir_i2c_ts
>>> to wake the system from low power state.
>>>
>>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>>> ---
>>> arch/arm/boot/dts/am437x-gp-evm.dts | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
>>> index 22038f21f228..69e93af7df0d 100644
>>> --- a/arch/arm/boot/dts/am437x-gp-evm.dts
>>> +++ b/arch/arm/boot/dts/am437x-gp-evm.dts
>>> @@ -581,8 +581,13 @@
>>>
>>> attb-gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>;
>>>
>>> + interrupts-extended = <&gpio3 22 GPIO_ACTIVE_HIGH>,
>>> + <&am43xx_pinmux 0x264>;
>>
>> How does this work?
>>
>> interrupts-extended property must have
>> 1) interrupt parent
>> 2) interrupt number
>> 3) interrupt flags
>>
>> Your change doesn't seem to comply with those requirements.
>
> AFAIU, interrupts-extended has two parts: interrupt parent phandle and
> interrupt specifier.
> The number of cells in interrupt specifier is determined by
> interrupt-cells property of interrupt parent node.
Got it.
> In above case, gpio3 has interrupt-cells = 2 hence interrupt specifier
> has interrupt number and interrupt flag field.
But is GPIO_ACTIVE_HIGH an interrupt flag?
> But in case am43xx_pinmux node, interrupt-cells is 1 hence has no
> interrupt flag field.
>
Understood, thanks. Might be worth adding a comment as to what 0x264 means though.
cheers,
-roger
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: am437x-gp-evm: Add wakeup interrupt source for pixcir_i2c_ts
2015-10-14 11:04 ` Roger Quadros
@ 2015-10-14 11:37 ` Vignesh R
0 siblings, 0 replies; 5+ messages in thread
From: Vignesh R @ 2015-10-14 11:37 UTC (permalink / raw)
To: linux-arm-kernel
On 10/14/2015 04:34 PM, Roger Quadros wrote:
> Vignesh,
>
> On 14/10/15 12:12, Vignesh R wrote:
>>
>>
>> On 10/14/2015 02:16 PM, Roger Quadros wrote:
>>
>>>
>>> On 14/10/15 08:52, Vignesh R wrote:
>>>> On am437x-gp-evm, pixcir_i2c_ts can wakeup the system from lower power
>>>> state via pinctrl and IO daisy chain using generic wakeirq framework.
>>>> With commit 3fffd1283927 ("i2c: allow specifying separate wakeup
>>>> interrupt in device tree") i2c core allows optional wakeirq to be
>>>> specified via device tree. Add wakeup irq entry to enable pixcir_i2c_ts
>>>> to wake the system from low power state.
>>>>
>>>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>>>> ---
>>>> arch/arm/boot/dts/am437x-gp-evm.dts | 5 +++++
>>>> 1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
>>>> index 22038f21f228..69e93af7df0d 100644
>>>> --- a/arch/arm/boot/dts/am437x-gp-evm.dts
>>>> +++ b/arch/arm/boot/dts/am437x-gp-evm.dts
>>>> @@ -581,8 +581,13 @@
>>>>
>>>> attb-gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>;
>>>>
>>>> + interrupts-extended = <&gpio3 22 GPIO_ACTIVE_HIGH>,
>>>> + <&am43xx_pinmux 0x264>;
>>>
>>> How does this work?
>>>
>>> interrupts-extended property must have
>>> 1) interrupt parent
>>> 2) interrupt number
>>> 3) interrupt flags
>>>
>>> Your change doesn't seem to comply with those requirements.
>>
>> AFAIU, interrupts-extended has two parts: interrupt parent phandle and
>> interrupt specifier.
>> The number of cells in interrupt specifier is determined by
>> interrupt-cells property of interrupt parent node.
>
> Got it.
>
>> In above case, gpio3 has interrupt-cells = 2 hence interrupt specifier
>> has interrupt number and interrupt flag field.
>
> But is GPIO_ACTIVE_HIGH an interrupt flag?
Oops.. I will change it to IRQ_TYPE_NONE as represented in interrupts
property.
>
>> But in case am43xx_pinmux node, interrupt-cells is 1 hence has no
>> interrupt flag field.
>>
> Understood, thanks. Might be worth adding a comment as to what 0x264 means though.
>
Will add a one line comment indicating its the offset of gpio3_22
padconf register from am43xx_pinmux base.
> cheers,
> -roger
>
--
Regards
Vignesh
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-10-14 11:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-14 5:52 [PATCH] ARM: dts: am437x-gp-evm: Add wakeup interrupt source for pixcir_i2c_ts Vignesh R
2015-10-14 8:46 ` Roger Quadros
2015-10-14 9:12 ` Vignesh R
2015-10-14 11:04 ` Roger Quadros
2015-10-14 11:37 ` Vignesh R
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).