* [PATCH] arm: pxa: raumfeld: make some variables static
@ 2015-10-14 9:27 Uwe Kleine-König
2015-10-14 9:29 ` Daniel Mack
0 siblings, 1 reply; 3+ messages in thread
From: Uwe Kleine-König @ 2015-10-14 9:27 UTC (permalink / raw)
To: linux-arm-kernel
This fixes the following sparse warnings:
arch/arm/mach-pxa/raumfeld.c:510:24: warning: symbol 'raumfeld_w1_gpio_device' was not declared. Should it be static?
arch/arm/mach-pxa/raumfeld.c:632:31: warning: symbol 'raumfeld_spi_platform_data' was not declared. Should it be static?
arch/arm/mach-pxa/raumfeld.c:851:28: warning: symbol 'audio_va_initdata' was not declared. Should it be static?
arch/arm/mach-pxa/raumfeld.c:883:28: warning: symbol 'audio_dummy_initdata' was not declared. Should it be static?
arch/arm/mach-pxa/raumfeld.c:931:28: warning: symbol 'max8660_v6_subdev_data' was not declared. Should it be static?
Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
---
arch/arm/mach-pxa/raumfeld.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mach-pxa/raumfeld.c b/arch/arm/mach-pxa/raumfeld.c
index 88f70c37ad0d..32ee6ef5ea4f 100644
--- a/arch/arm/mach-pxa/raumfeld.c
+++ b/arch/arm/mach-pxa/raumfeld.c
@@ -507,7 +507,7 @@ static struct w1_gpio_platform_data w1_gpio_platform_data = {
.ext_pullup_enable_pin = -EINVAL,
};
-struct platform_device raumfeld_w1_gpio_device = {
+static struct platform_device raumfeld_w1_gpio_device = {
.name = "w1-gpio",
.dev = {
.platform_data = &w1_gpio_platform_data
@@ -629,7 +629,7 @@ static void __init raumfeld_lcd_init(void)
* SPI devices
*/
-struct spi_gpio_platform_data raumfeld_spi_platform_data = {
+static struct spi_gpio_platform_data raumfeld_spi_platform_data = {
.sck = GPIO_SPI_CLK,
.mosi = GPIO_SPI_MOSI,
.miso = GPIO_SPI_MISO,
@@ -848,7 +848,7 @@ static void __init raumfeld_power_init(void)
static struct regulator_consumer_supply audio_va_consumer_supply =
REGULATOR_SUPPLY("va", "0-0048");
-struct regulator_init_data audio_va_initdata = {
+static struct regulator_init_data audio_va_initdata = {
.consumer_supplies = &audio_va_consumer_supply,
.num_consumer_supplies = 1,
.constraints = {
@@ -880,7 +880,7 @@ static struct regulator_consumer_supply audio_dummy_supplies[] = {
REGULATOR_SUPPLY("vlc", "0-0048"),
};
-struct regulator_init_data audio_dummy_initdata = {
+static struct regulator_init_data audio_dummy_initdata = {
.consumer_supplies = audio_dummy_supplies,
.num_consumer_supplies = ARRAY_SIZE(audio_dummy_supplies),
.constraints = {
@@ -928,7 +928,7 @@ static struct regulator_init_data vcc_mmc_init_data = {
.num_consumer_supplies = 1,
};
-struct max8660_subdev_data max8660_v6_subdev_data = {
+static struct max8660_subdev_data max8660_v6_subdev_data = {
.id = MAX8660_V6,
.name = "vmmc",
.platform_data = &vcc_mmc_init_data,
--
2.6.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] arm: pxa: raumfeld: make some variables static
2015-10-14 9:27 [PATCH] arm: pxa: raumfeld: make some variables static Uwe Kleine-König
@ 2015-10-14 9:29 ` Daniel Mack
2015-10-14 14:36 ` Robert Jarzmik
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Mack @ 2015-10-14 9:29 UTC (permalink / raw)
To: linux-arm-kernel
On 10/14/2015 11:27 AM, Uwe Kleine-K?nig wrote:
> This fixes the following sparse warnings:
>
> arch/arm/mach-pxa/raumfeld.c:510:24: warning: symbol 'raumfeld_w1_gpio_device' was not declared. Should it be static?
> arch/arm/mach-pxa/raumfeld.c:632:31: warning: symbol 'raumfeld_spi_platform_data' was not declared. Should it be static?
> arch/arm/mach-pxa/raumfeld.c:851:28: warning: symbol 'audio_va_initdata' was not declared. Should it be static?
> arch/arm/mach-pxa/raumfeld.c:883:28: warning: symbol 'audio_dummy_initdata' was not declared. Should it be static?
> arch/arm/mach-pxa/raumfeld.c:931:28: warning: symbol 'max8660_v6_subdev_data' was not declared. Should it be static?
>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Acked-by: Daniel Mack <daniel@zonque.org>
Thanks!
> ---
> arch/arm/mach-pxa/raumfeld.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/raumfeld.c b/arch/arm/mach-pxa/raumfeld.c
> index 88f70c37ad0d..32ee6ef5ea4f 100644
> --- a/arch/arm/mach-pxa/raumfeld.c
> +++ b/arch/arm/mach-pxa/raumfeld.c
> @@ -507,7 +507,7 @@ static struct w1_gpio_platform_data w1_gpio_platform_data = {
> .ext_pullup_enable_pin = -EINVAL,
> };
>
> -struct platform_device raumfeld_w1_gpio_device = {
> +static struct platform_device raumfeld_w1_gpio_device = {
> .name = "w1-gpio",
> .dev = {
> .platform_data = &w1_gpio_platform_data
> @@ -629,7 +629,7 @@ static void __init raumfeld_lcd_init(void)
> * SPI devices
> */
>
> -struct spi_gpio_platform_data raumfeld_spi_platform_data = {
> +static struct spi_gpio_platform_data raumfeld_spi_platform_data = {
> .sck = GPIO_SPI_CLK,
> .mosi = GPIO_SPI_MOSI,
> .miso = GPIO_SPI_MISO,
> @@ -848,7 +848,7 @@ static void __init raumfeld_power_init(void)
> static struct regulator_consumer_supply audio_va_consumer_supply =
> REGULATOR_SUPPLY("va", "0-0048");
>
> -struct regulator_init_data audio_va_initdata = {
> +static struct regulator_init_data audio_va_initdata = {
> .consumer_supplies = &audio_va_consumer_supply,
> .num_consumer_supplies = 1,
> .constraints = {
> @@ -880,7 +880,7 @@ static struct regulator_consumer_supply audio_dummy_supplies[] = {
> REGULATOR_SUPPLY("vlc", "0-0048"),
> };
>
> -struct regulator_init_data audio_dummy_initdata = {
> +static struct regulator_init_data audio_dummy_initdata = {
> .consumer_supplies = audio_dummy_supplies,
> .num_consumer_supplies = ARRAY_SIZE(audio_dummy_supplies),
> .constraints = {
> @@ -928,7 +928,7 @@ static struct regulator_init_data vcc_mmc_init_data = {
> .num_consumer_supplies = 1,
> };
>
> -struct max8660_subdev_data max8660_v6_subdev_data = {
> +static struct max8660_subdev_data max8660_v6_subdev_data = {
> .id = MAX8660_V6,
> .name = "vmmc",
> .platform_data = &vcc_mmc_init_data,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] arm: pxa: raumfeld: make some variables static
2015-10-14 9:29 ` Daniel Mack
@ 2015-10-14 14:36 ` Robert Jarzmik
0 siblings, 0 replies; 3+ messages in thread
From: Robert Jarzmik @ 2015-10-14 14:36 UTC (permalink / raw)
To: linux-arm-kernel
Daniel Mack <daniel@zonque.org> writes:
> On 10/14/2015 11:27 AM, Uwe Kleine-K?nig wrote:
>> This fixes the following sparse warnings:
>>
>> arch/arm/mach-pxa/raumfeld.c:510:24: warning: symbol 'raumfeld_w1_gpio_device' was not declared. Should it be static?
>> arch/arm/mach-pxa/raumfeld.c:632:31: warning: symbol 'raumfeld_spi_platform_data' was not declared. Should it be static?
>> arch/arm/mach-pxa/raumfeld.c:851:28: warning: symbol 'audio_va_initdata' was not declared. Should it be static?
>> arch/arm/mach-pxa/raumfeld.c:883:28: warning: symbol 'audio_dummy_initdata' was not declared. Should it be static?
>> arch/arm/mach-pxa/raumfeld.c:931:28: warning: symbol 'max8660_v6_subdev_data' was not declared. Should it be static?
>>
>> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
>
> Acked-by: Daniel Mack <daniel@zonque.org>
Queued into pxa/for-next, thanks.
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-14 14:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-14 9:27 [PATCH] arm: pxa: raumfeld: make some variables static Uwe Kleine-König
2015-10-14 9:29 ` Daniel Mack
2015-10-14 14:36 ` Robert Jarzmik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).