* [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data
@ 2015-10-13 13:44 Franklin S Cooper Jr
2015-10-13 14:02 ` Lokesh Vutla
2015-10-14 6:58 ` Roger Quadros
0 siblings, 2 replies; 5+ messages in thread
From: Franklin S Cooper Jr @ 2015-10-13 13:44 UTC (permalink / raw)
To: linux-arm-kernel
ELM address information is provided by device tree. No longer need
to include this information within hwmod.
Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
---
arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
index 562247b..ad2cc7a 100644
--- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
@@ -2566,21 +2566,11 @@ static struct omap_hwmod_ocp_if dra7xx_l3_main_1__hdmi = {
.user = OCP_USER_MPU | OCP_USER_SDMA,
};
-static struct omap_hwmod_addr_space dra7xx_elm_addrs[] = {
- {
- .pa_start = 0x48078000,
- .pa_end = 0x48078fff,
- .flags = ADDR_TYPE_RT
- },
- { }
-};
-
/* l4_per1 -> elm */
static struct omap_hwmod_ocp_if dra7xx_l4_per1__elm = {
.master = &dra7xx_l4_per1_hwmod,
.slave = &dra7xx_elm_hwmod,
.clk = "l3_iclk_div",
- .addr = dra7xx_elm_addrs,
.user = OCP_USER_MPU | OCP_USER_SDMA,
};
--
2.6.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data
2015-10-13 13:44 [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data Franklin S Cooper Jr
@ 2015-10-13 14:02 ` Lokesh Vutla
2015-10-14 6:58 ` Roger Quadros
1 sibling, 0 replies; 5+ messages in thread
From: Lokesh Vutla @ 2015-10-13 14:02 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 13 October 2015 07:14 PM, Franklin S Cooper Jr wrote:
> ELM address information is provided by device tree. No longer need
> to include this information within hwmod.
Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
Thanks and regards,
Lokesh
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index 562247b..ad2cc7a 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -2566,21 +2566,11 @@ static struct omap_hwmod_ocp_if dra7xx_l3_main_1__hdmi = {
> .user = OCP_USER_MPU | OCP_USER_SDMA,
> };
>
> -static struct omap_hwmod_addr_space dra7xx_elm_addrs[] = {
> - {
> - .pa_start = 0x48078000,
> - .pa_end = 0x48078fff,
> - .flags = ADDR_TYPE_RT
> - },
> - { }
> -};
> -
> /* l4_per1 -> elm */
> static struct omap_hwmod_ocp_if dra7xx_l4_per1__elm = {
> .master = &dra7xx_l4_per1_hwmod,
> .slave = &dra7xx_elm_hwmod,
> .clk = "l3_iclk_div",
> - .addr = dra7xx_elm_addrs,
> .user = OCP_USER_MPU | OCP_USER_SDMA,
> };
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data
2015-10-13 13:44 [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data Franklin S Cooper Jr
2015-10-13 14:02 ` Lokesh Vutla
@ 2015-10-14 6:58 ` Roger Quadros
2015-10-14 13:08 ` Franklin S Cooper Jr.
1 sibling, 1 reply; 5+ messages in thread
From: Roger Quadros @ 2015-10-14 6:58 UTC (permalink / raw)
To: linux-arm-kernel
On 13/10/15 16:44, Franklin S Cooper Jr wrote:
> ELM address information is provided by device tree. No longer need
> to include this information within hwmod.
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
Acked-by: Roger Quadros <rogerq@ti.com>
Franklin,
Can you please do the same for gpmc_addr as well?
And looks like elm_addr needs to be removed from
omap_hwmod_33xx_43xx_interconnect_data.c and omap_hwmod_44xx_data.c as well, no?
cheers,
-roger
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index 562247b..ad2cc7a 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -2566,21 +2566,11 @@ static struct omap_hwmod_ocp_if dra7xx_l3_main_1__hdmi = {
> .user = OCP_USER_MPU | OCP_USER_SDMA,
> };
>
> -static struct omap_hwmod_addr_space dra7xx_elm_addrs[] = {
> - {
> - .pa_start = 0x48078000,
> - .pa_end = 0x48078fff,
> - .flags = ADDR_TYPE_RT
> - },
> - { }
> -};
> -
> /* l4_per1 -> elm */
> static struct omap_hwmod_ocp_if dra7xx_l4_per1__elm = {
> .master = &dra7xx_l4_per1_hwmod,
> .slave = &dra7xx_elm_hwmod,
> .clk = "l3_iclk_div",
> - .addr = dra7xx_elm_addrs,
> .user = OCP_USER_MPU | OCP_USER_SDMA,
> };
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data
2015-10-14 6:58 ` Roger Quadros
@ 2015-10-14 13:08 ` Franklin S Cooper Jr.
2015-10-15 6:25 ` Paul Walmsley
0 siblings, 1 reply; 5+ messages in thread
From: Franklin S Cooper Jr. @ 2015-10-14 13:08 UTC (permalink / raw)
To: linux-arm-kernel
On 10/14/2015 01:58 AM, Roger Quadros wrote:
> On 13/10/15 16:44, Franklin S Cooper Jr wrote:
>> ELM address information is provided by device tree. No longer need
>> to include this information within hwmod.
>>
>> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> Acked-by: Roger Quadros <rogerq@ti.com>
>
> Franklin,
>
> Can you please do the same for gpmc_addr as well?
>
> And looks like elm_addr needs to be removed from
> omap_hwmod_33xx_43xx_interconnect_data.c and omap_hwmod_44xx_data.c as well, no?
Sure I'll combine the 335x and 44x elm removal with this patch and then create a separate patch for the gpmc version.
>
> cheers,
> -roger
>
>> ---
>> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 10 ----------
>> 1 file changed, 10 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
>> index 562247b..ad2cc7a 100644
>> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
>> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
>> @@ -2566,21 +2566,11 @@ static struct omap_hwmod_ocp_if dra7xx_l3_main_1__hdmi = {
>> .user = OCP_USER_MPU | OCP_USER_SDMA,
>> };
>>
>> -static struct omap_hwmod_addr_space dra7xx_elm_addrs[] = {
>> - {
>> - .pa_start = 0x48078000,
>> - .pa_end = 0x48078fff,
>> - .flags = ADDR_TYPE_RT
>> - },
>> - { }
>> -};
>> -
>> /* l4_per1 -> elm */
>> static struct omap_hwmod_ocp_if dra7xx_l4_per1__elm = {
>> .master = &dra7xx_l4_per1_hwmod,
>> .slave = &dra7xx_elm_hwmod,
>> .clk = "l3_iclk_div",
>> - .addr = dra7xx_elm_addrs,
>> .user = OCP_USER_MPU | OCP_USER_SDMA,
>> };
>>
>>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data
2015-10-14 13:08 ` Franklin S Cooper Jr.
@ 2015-10-15 6:25 ` Paul Walmsley
0 siblings, 0 replies; 5+ messages in thread
From: Paul Walmsley @ 2015-10-15 6:25 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, 14 Oct 2015, Franklin S Cooper Jr. wrote:
>
>
> On 10/14/2015 01:58 AM, Roger Quadros wrote:
> > On 13/10/15 16:44, Franklin S Cooper Jr wrote:
> >> ELM address information is provided by device tree. No longer need
> >> to include this information within hwmod.
> >>
> >> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> > Acked-by: Roger Quadros <rogerq@ti.com>
> >
> > Franklin,
> >
> > Can you please do the same for gpmc_addr as well?
> >
> > And looks like elm_addr needs to be removed from
> > omap_hwmod_33xx_43xx_interconnect_data.c and omap_hwmod_44xx_data.c as well, no?
> Sure I'll combine the 335x and 44x elm removal with this patch and then create a separate patch for the gpmc version.
OK, holding off on this until you update the patch.
- Paul
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-10-15 6:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-13 13:44 [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data Franklin S Cooper Jr
2015-10-13 14:02 ` Lokesh Vutla
2015-10-14 6:58 ` Roger Quadros
2015-10-14 13:08 ` Franklin S Cooper Jr.
2015-10-15 6:25 ` Paul Walmsley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).