From mboxrd@z Thu Jan 1 00:00:00 1970 From: hare@suse.de (Hannes Reinecke) Date: Thu, 15 Oct 2015 14:06:15 +0200 Subject: [PATCH] scsi: advansys needs ISA dma api for ISA support In-Reply-To: <5081546.QjQ32dGX2L@wuerfel> References: <5081546.QjQ32dGX2L@wuerfel> Message-ID: <561F96B7.4050300@suse.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/12/2015 05:10 PM, Arnd Bergmann wrote: > The advansys drvier uses the request_dma function that is used on ISA > machines for the internal DMA controller, which causes build errors > on platforms that have ISA slots but do not provide the ISA DMA API: > > drivers/scsi/advansys.c: In function 'advansys_board_found': > drivers/scsi/advansys.c:11300:10: error: implicit declaration of function 'request_dma' [-Werror=implicit-function-declaration] > > The problem now showed up in ARM randconfig builds after commit > 6571fb3f8b7f ("advansys: Update to version 3.5 and remove compilation > warning") made it possible to build on platforms that have neither > VIRT_TO_BUS nor ISA_DMA_API but that do have ISA. > > This adds the missing dependency. > > Signed-off-by: Arnd Bergmann > > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig > index d2f480b04a52..d4aa6a1a806c 100644 > --- a/drivers/scsi/Kconfig > +++ b/drivers/scsi/Kconfig > @@ -499,6 +499,7 @@ config SCSI_ADVANSYS > tristate "AdvanSys SCSI support" > depends on SCSI > depends on ISA || EISA || PCI > + depends on ISA_DMA_API || !ISA > help > This is a driver for all SCSI host adapters manufactured by > AdvanSys. It is documented in the kernel source in > Sorry to chime in again, but wouldn't this allow to build on platforms which have neither ISA_DMA_API nor ISA, like oldish sparc systems with proprietary S-BUS? Why not ISA_DMA_API || EISA || PCI ? Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare at suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: J. Hawn, J. Guild, F. Imend?rffer, HRB 16746 (AG N?rnberg)