From: caesar.upstream@gmail.com (Caesar Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] soc: rockchip: power-domain: don't try to print the clock name in error case
Date: Fri, 16 Oct 2015 09:19:34 +0800 [thread overview]
Message-ID: <562050A6.7080002@gmail.com> (raw)
In-Reply-To: <1764593.eLkUiZigaK@diego>
Heiko,
Thanks to fix it.
? 2015?10?15? 21:22, Heiko St?bner ??:
> When we never got the the clock-reference, i.e. when IS_ERR(clk) is true,
> don't try to print the clock name via %pC as this of course produces a
> null-pointer-dereference in __clk_get_name().
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Look good to me, you can free add that.
Reviewed-by: Caesar Wang <wxt@rock-chips.com>
> ---
> drivers/soc/rockchip/pm_domains.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/rockchip/pm_domains.c b/drivers/soc/rockchip/pm_domains.c
> index 8268d5d..534c589 100644
> --- a/drivers/soc/rockchip/pm_domains.c
> +++ b/drivers/soc/rockchip/pm_domains.c
> @@ -265,8 +265,8 @@ static int rockchip_pm_add_one_domain(struct rockchip_pmu *pmu,
> if (IS_ERR(clk)) {
> error = PTR_ERR(clk);
> dev_err(pmu->dev,
> - "%s: failed to get clk %pC (index %d): %d\n",
> - node->name, clk, i, error);
> + "%s: failed to get clk at index %d: %d\n",
> + node->name, i, error);
> goto err_out;
> }
>
>
> --
> Thanks,
> Caesar
next prev parent reply other threads:[~2015-10-16 1:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 13:22 [PATCH] soc: rockchip: power-domain: don't try to print the clock name in error case Heiko Stübner
2015-10-16 1:19 ` Caesar Wang [this message]
2015-10-16 8:17 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562050A6.7080002@gmail.com \
--to=caesar.upstream@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).