* [PATCH] ARM: at91: pm: at91_pm_suspend_in_sram() must be 8-byte aligned
@ 2015-10-16 10:39 Alexandre Belloni
2015-10-16 11:22 ` Sylvain Rochet
0 siblings, 1 reply; 3+ messages in thread
From: Alexandre Belloni @ 2015-10-16 10:39 UTC (permalink / raw)
To: linux-arm-kernel
From: Patrick Doyle <pdoyle@irobot.com>
fncpy() requires that the source and the destination are both 8-byte
aligned.
Signed-off-by: Patrick Doyle <pdoyle@irobot.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
arch/arm/mach-at91/pm_suspend.S | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S
index 0d95f488b47a..a25defda3d22 100644
--- a/arch/arm/mach-at91/pm_suspend.S
+++ b/arch/arm/mach-at91/pm_suspend.S
@@ -80,6 +80,8 @@ tmp2 .req r5
* @r2: base address of second SDRAM Controller or 0 if not present
* @r3: pm information
*/
+/* at91_pm_suspend_in_sram must be 8-byte aligned per the requirements of fncpy() */
+ .align 3
ENTRY(at91_pm_suspend_in_sram)
/* Save registers on stack */
stmfd sp!, {r4 - r12, lr}
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] ARM: at91: pm: at91_pm_suspend_in_sram() must be 8-byte aligned
2015-10-16 10:39 [PATCH] ARM: at91: pm: at91_pm_suspend_in_sram() must be 8-byte aligned Alexandre Belloni
@ 2015-10-16 11:22 ` Sylvain Rochet
2015-10-16 11:31 ` Nicolas Ferre
0 siblings, 1 reply; 3+ messages in thread
From: Sylvain Rochet @ 2015-10-16 11:22 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Fri, Oct 16, 2015 at 12:39:05PM +0200, Alexandre Belloni wrote:
> From: Patrick Doyle <pdoyle@irobot.com>
>
> fncpy() requires that the source and the destination are both 8-byte
> aligned.
>
> Signed-off-by: Patrick Doyle <pdoyle@irobot.com>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Additional tags:
Fixes: d94e688cae56 ("ARM: at91/pm: move the copying the sram function to the sram initialization phase")
Cc: <stable@vger.kernel.org> # 4.1+
Sylvain
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] ARM: at91: pm: at91_pm_suspend_in_sram() must be 8-byte aligned
2015-10-16 11:22 ` Sylvain Rochet
@ 2015-10-16 11:31 ` Nicolas Ferre
0 siblings, 0 replies; 3+ messages in thread
From: Nicolas Ferre @ 2015-10-16 11:31 UTC (permalink / raw)
To: linux-arm-kernel
Le 16/10/2015 13:22, Sylvain Rochet a ?crit :
> Hi,
>
> On Fri, Oct 16, 2015 at 12:39:05PM +0200, Alexandre Belloni wrote:
>> From: Patrick Doyle <pdoyle@irobot.com>
>>
>> fncpy() requires that the source and the destination are both 8-byte
>> aligned.
>>
>> Signed-off-by: Patrick Doyle <pdoyle@irobot.com>
>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>
> Additional tags:
>
> Fixes: d94e688cae56 ("ARM: at91/pm: move the copying the sram function to the sram initialization phase")
> Cc: <stable@vger.kernel.org> # 4.1+
Absolutely: thanks Sylvain.
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thank you to Patrick for having found this issue.
Best regards,
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-16 11:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-16 10:39 [PATCH] ARM: at91: pm: at91_pm_suspend_in_sram() must be 8-byte aligned Alexandre Belloni
2015-10-16 11:22 ` Sylvain Rochet
2015-10-16 11:31 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).