From: Nathan_Lynch@mentor.com (Nathan Lynch)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] ARM: fix vdsomunge not to depend on glibc specific byteswap.h
Date: Fri, 16 Oct 2015 09:02:54 -0500 [thread overview]
Message-ID: <5621038E.9080406@mentor.com> (raw)
In-Reply-To: <4436b0dbf72aa409613ec4c7407b017d085e40ac.1444977518.git.hns@goldelico.com>
On 10/16/2015 01:38 AM, H. Nikolaus Schaller wrote:
> diff --git a/arch/arm/vdso/vdsomunge.c b/arch/arm/vdso/vdsomunge.c
> index aedec81..0cebd98 100644
> --- a/arch/arm/vdso/vdsomunge.c
> +++ b/arch/arm/vdso/vdsomunge.c
> @@ -45,7 +45,6 @@
> * it does.
> */
>
> -#include <byteswap.h>
> #include <elf.h>
> #include <errno.h>
> #include <fcntl.h>
> @@ -59,6 +58,16 @@
> #include <sys/types.h>
> #include <unistd.h>
>
> +#define swab16(x) \
> + ((((x) & 0x00ff) << 8) | \
> + (((x) & 0xff00) >> 8))
> +
> +#define swab32(x) \
> + ((((x) & 0x000000ff) << 24) | \
> + (((x) & 0x0000ff00) << 8) | \
> + (((x) & 0x00ff0000) >> 8) | \
> + (((x) & 0xff000000) << 24))
> +
> #if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
> #define HOST_ORDER ELFDATA2LSB
> #elif __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__
> @@ -104,17 +113,17 @@ static void cleanup(void)
>
> static Elf32_Word read_elf_word(Elf32_Word word, bool swap)
> {
> - return swap ? bswap_32(word) : word;
> + return swap ? swab32(word) : word;
> }
>
> static Elf32_Half read_elf_half(Elf32_Half half, bool swap)
> {
> - return swap ? bswap_16(half) : half;
> + return swap ? swab16(half) : half;
> }
>
> static void write_elf_word(Elf32_Word val, Elf32_Word *dst, bool swap)
> {
> - *dst = swap ? bswap_32(val) : val;
> + *dst = swap ? swab32(val) : val;
> }
I think this looks good now and it checks out in my local testing.
Thanks for your persistence.
Assuming Russell has no further comments I'll put this in his patch
system later today.
prev parent reply other threads:[~2015-10-16 14:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 6:38 [PATCH v4] ARM: fix vdsomunge not to depend on glibc specific byteswap.h H. Nikolaus Schaller
2015-10-16 14:02 ` Nathan Lynch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5621038E.9080406@mentor.com \
--to=nathan_lynch@mentor.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).