From mboxrd@z Thu Jan 1 00:00:00 1970 From: alim.akhtar@samsung.com (Alim Akhtar) Date: Mon, 19 Oct 2015 15:53:51 +0530 Subject: [PATCH 7/7] ARM: EXYNOS: Remove code for restart and poweroff for exynos SoCs In-Reply-To: <5624BE39.7020605@osg.samsung.com> References: <1445234635-3950-1-git-send-email-alim.akhtar@samsung.com> <1445234635-3950-8-git-send-email-alim.akhtar@samsung.com> <562494F8.6070003@samsung.com> <5624BE39.7020605@osg.samsung.com> Message-ID: <5624C4B7.30507@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/19/2015 03:26 PM, Javier Martinez Canillas wrote: > Hello, > > On 10/19/2015 09:00 AM, Krzysztof Kozlowski wrote: >> On 19.10.2015 15:03, Alim Akhtar wrote: >>> Now we can use the generic syscon-{reboot/poweroff} drivers, >>> so we don't need special handling for reboot/poweroff in >>> exynos pmu driver. This patch remove the same. >>> >>> Signed-off-by: Alim Akhtar >>> --- >>> arch/arm/mach-exynos/pmu.c | 43 ------------------------------------------- >>> 1 file changed, 43 deletions(-) >> >> I think that removal of this stuff will effectively remove the >> restart/poweroff handlers from: >> 1. Other defconfigs, like multi_v7 >> 2. Custom configs. >> > > This will also break old DTBs that don't have a "syscon-poweroff" device > node that contains the necessary PMU regmap, offset and mask information. > >> Previously this code was always compiled in for ARCH_EXYNOS. Now it is >> not so I am thinking about selecting necessary drivers from main exynos >> Kconfig symbol. That could be tricky though, because "select" should be >> used only for non-visible symbols. >> >> Any ideas how to solve that? >> > > Is true that select should only be used for non-visible symbols but there > are others user visible symbols that are selected by ARCH_EXYNOS such as > EXYNOS_THERMAL. So I think selecting the regmap syscon reset stuff there > is a sensible option. > Yes, another example is MFD_SYSYCON which is selected from Kconfig. Also CONFIG_POWER_RESET_SYSCON is enable in arch/arm64/config/defconfig. So both approaches are taken here. will go with maintainer suggestion here. >> Best regards, >> Krzysztof >> > > Best regards, >