linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: m-karicheri2@ti.com (Murali Karicheri)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH linux-next] soc: ti: use request_firmware_direct() as acc firmware is optional
Date: Mon, 19 Oct 2015 11:28:19 -0400	[thread overview]
Message-ID: <56250C13.708@ti.com> (raw)
In-Reply-To: <5621030D.4090800@ti.com>

On 10/16/2015 10:00 AM, Murali Karicheri wrote:
> On 10/15/2015 02:59 PM, Murali Karicheri wrote:
>> When firmware image for PDSP firmware is absent in the file system
>> the kernel boot with ramfs/nfs is stuck for 60 seconds being the
>> the default timeout. request_firmware_direct() is to take care of
>> such optional firmware loading and hence replace the call in the
>> driver with this API.
>>
>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>> ---
>>   drivers/soc/ti/knav_qmss_queue.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/soc/ti/knav_qmss_queue.c
>> b/drivers/soc/ti/knav_qmss_queue.c
>> index f3a0b6a..89789e2 100644
>> --- a/drivers/soc/ti/knav_qmss_queue.c
>> +++ b/drivers/soc/ti/knav_qmss_queue.c
>> @@ -1519,9 +1519,9 @@ static int knav_queue_load_pdsp(struct
>> knav_device *kdev,
>>
>>       for (i = 0; i < ARRAY_SIZE(knav_acc_firmwares); i++) {
>>           if (knav_acc_firmwares[i]) {
>> -            ret = request_firmware(&fw,
>> -                           knav_acc_firmwares[i],
>> -                           kdev->dev);
>> +            ret = request_firmware_direct(&fw,
>> +                              knav_acc_firmwares[i],
>> +                              kdev->dev);
>>               if (!ret) {
>>                   found = true;
>>                   break;
>>
> Santosh,
>
> If this looks good, could you please send this to linux-next?  Without
> this, Linux boot will see a pause for about 60 seconds if qmss acc
> firmware is not present in the file system. So this is a must for next.
>
Santosh,

A Gentle ping....

Murali

-- 
Murali Karicheri
Linux Kernel, Keystone

  reply	other threads:[~2015-10-19 15:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-15 18:59 [PATCH linux-next] soc: ti: use request_firmware_direct() as acc firmware is optional Murali Karicheri
2015-10-16 14:00 ` Murali Karicheri
2015-10-19 15:28   ` Murali Karicheri [this message]
2015-10-19 15:29     ` santosh shilimkar
2015-10-19 17:02       ` Murali Karicheri
2015-10-19 17:07         ` santosh shilimkar
2015-10-19 17:56           ` Murali Karicheri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56250C13.708@ti.com \
    --to=m-karicheri2@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).