[PATCH linux-next] soc: ti: use request_firmware_direct() as acc firmware is optional

[PATCH linux-next] soc: ti: use request_firmware_direct() as acc firmware is optional

[Murali Karicheri]

When firmware image for PDSP firmware is absent in the file system
the kernel boot with ramfs/nfs is stuck for 60 seconds being the
the default timeout. request_firmware_direct() is to take care of
such optional firmware loading and hence replace the call in the
driver with this API.

Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
---
 drivers/soc/ti/knav_qmss_queue.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
index f3a0b6a..89789e2 100644
--- a/drivers/soc/ti/knav_qmss_queue.c
+++ b/drivers/soc/ti/knav_qmss_queue.c
@@ -1519,9 +1519,9 @@ static int knav_queue_load_pdsp(struct knav_device *kdev,
 
 	for (i = 0; i < ARRAY_SIZE(knav_acc_firmwares); i++) {
 		if (knav_acc_firmwares[i]) {
-			ret = request_firmware(&fw,
-					       knav_acc_firmwares[i],
-					       kdev->dev);
+			ret = request_firmware_direct(&fw,
+						      knav_acc_firmwares[i],
+						      kdev->dev);
 			if (!ret) {
 				found = true;
 				break;
-- 
1.9.1

[PATCH linux-next] soc: ti: use request_firmware_direct() as acc firmware is optional

[Murali Karicheri]

On 10/15/2015 02:59 PM, Murali Karicheri wrote:
> When firmware image for PDSP firmware is absent in the file system
> the kernel boot with ramfs/nfs is stuck for 60 seconds being the
> the default timeout. request_firmware_direct() is to take care of
> such optional firmware loading and hence replace the call in the
> driver with this API.
>
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> ---
>   drivers/soc/ti/knav_qmss_queue.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
> index f3a0b6a..89789e2 100644
> --- a/drivers/soc/ti/knav_qmss_queue.c
> +++ b/drivers/soc/ti/knav_qmss_queue.c
> @@ -1519,9 +1519,9 @@ static int knav_queue_load_pdsp(struct knav_device *kdev,
>
>   	for (i = 0; i < ARRAY_SIZE(knav_acc_firmwares); i++) {
>   		if (knav_acc_firmwares[i]) {
> -			ret = request_firmware(&fw,
> -					       knav_acc_firmwares[i],
> -					       kdev->dev);
> +			ret = request_firmware_direct(&fw,
> +						      knav_acc_firmwares[i],
> +						      kdev->dev);
>   			if (!ret) {
>   				found = true;
>   				break;
>
Santosh,

If this looks good, could you please send this to linux-next?  Without 
this, Linux boot will see a pause for about 60 seconds if qmss acc 
firmware is not present in the file system. So this is a must for next.

-- 
Murali Karicheri
Linux Kernel, Keystone

[PATCH linux-next] soc: ti: use request_firmware_direct() as acc firmware is optional

[Murali Karicheri]

On 10/16/2015 10:00 AM, Murali Karicheri wrote:
> On 10/15/2015 02:59 PM, Murali Karicheri wrote:
>> When firmware image for PDSP firmware is absent in the file system
>> the kernel boot with ramfs/nfs is stuck for 60 seconds being the
>> the default timeout. request_firmware_direct() is to take care of
>> such optional firmware loading and hence replace the call in the
>> driver with this API.
>>
>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>> ---
>>   drivers/soc/ti/knav_qmss_queue.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/soc/ti/knav_qmss_queue.c
>> b/drivers/soc/ti/knav_qmss_queue.c
>> index f3a0b6a..89789e2 100644
>> --- a/drivers/soc/ti/knav_qmss_queue.c
>> +++ b/drivers/soc/ti/knav_qmss_queue.c
>> @@ -1519,9 +1519,9 @@ static int knav_queue_load_pdsp(struct
>> knav_device *kdev,
>>
>>       for (i = 0; i < ARRAY_SIZE(knav_acc_firmwares); i++) {
>>           if (knav_acc_firmwares[i]) {
>> -            ret = request_firmware(&fw,
>> -                           knav_acc_firmwares[i],
>> -                           kdev->dev);
>> +            ret = request_firmware_direct(&fw,
>> +                              knav_acc_firmwares[i],
>> +                              kdev->dev);
>>               if (!ret) {
>>                   found = true;
>>                   break;
>>
> Santosh,
>
> If this looks good, could you please send this to linux-next?  Without
> this, Linux boot will see a pause for about 60 seconds if qmss acc
> firmware is not present in the file system. So this is a must for next.
>
Santosh,

A Gentle ping....

Murali

-- 
Murali Karicheri
Linux Kernel, Keystone

[PATCH linux-next] soc: ti: use request_firmware_direct() as acc firmware is optional

[santosh shilimkar]

On 10/19/2015 8:28 AM, Murali Karicheri wrote:
> On 10/16/2015 10:00 AM, Murali Karicheri wrote:
>> On 10/15/2015 02:59 PM, Murali Karicheri wrote:
>>> When firmware image for PDSP firmware is absent in the file system
>>> the kernel boot with ramfs/nfs is stuck for 60 seconds being the
>>> the default timeout. request_firmware_direct() is to take care of
>>> such optional firmware loading and hence replace the call in the
>>> driver with this API.
>>>
>>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>>> ---
>>>   drivers/soc/ti/knav_qmss_queue.c | 6 +++---
>>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/soc/ti/knav_qmss_queue.c
>>> b/drivers/soc/ti/knav_qmss_queue.c
>>> index f3a0b6a..89789e2 100644
>>> --- a/drivers/soc/ti/knav_qmss_queue.c
>>> +++ b/drivers/soc/ti/knav_qmss_queue.c
>>> @@ -1519,9 +1519,9 @@ static int knav_queue_load_pdsp(struct
>>> knav_device *kdev,
>>>
>>>       for (i = 0; i < ARRAY_SIZE(knav_acc_firmwares); i++) {
>>>           if (knav_acc_firmwares[i]) {
>>> -            ret = request_firmware(&fw,
>>> -                           knav_acc_firmwares[i],
>>> -                           kdev->dev);
>>> +            ret = request_firmware_direct(&fw,
>>> +                              knav_acc_firmwares[i],
>>> +                              kdev->dev);
>>>               if (!ret) {
>>>                   found = true;
>>>                   break;
>>>
>> Santosh,
>>
>> If this looks good, could you please send this to linux-next?  Without
>> this, Linux boot will see a pause for about 60 seconds if qmss acc
>> firmware is not present in the file system. So this is a must for next.
>>
> Santosh,
>
> A Gentle ping....
>
Yes I have seen it but it has to wait now. I plan to send that as a fix
as part of 4.4-rcx fixes.

[PATCH linux-next] soc: ti: use request_firmware_direct() as acc firmware is optional

[Murali Karicheri]

On 10/19/2015 11:29 AM, santosh shilimkar wrote:
> On 10/19/2015 8:28 AM, Murali Karicheri wrote:
>> On 10/16/2015 10:00 AM, Murali Karicheri wrote:
>>> On 10/15/2015 02:59 PM, Murali Karicheri wrote:
>>>> When firmware image for PDSP firmware is absent in the file system
>>>> the kernel boot with ramfs/nfs is stuck for 60 seconds being the
>>>> the default timeout. request_firmware_direct() is to take care of
>>>> such optional firmware loading and hence replace the call in the
>>>> driver with this API.
>>>>
>>>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>>>> ---
>>>>   drivers/soc/ti/knav_qmss_queue.c | 6 +++---
>>>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/drivers/soc/ti/knav_qmss_queue.c
>>>> b/drivers/soc/ti/knav_qmss_queue.c
>>>> index f3a0b6a..89789e2 100644
>>>> --- a/drivers/soc/ti/knav_qmss_queue.c
>>>> +++ b/drivers/soc/ti/knav_qmss_queue.c
>>>> @@ -1519,9 +1519,9 @@ static int knav_queue_load_pdsp(struct
>>>> knav_device *kdev,
>>>>
>>>>       for (i = 0; i < ARRAY_SIZE(knav_acc_firmwares); i++) {
>>>>           if (knav_acc_firmwares[i]) {
>>>> -            ret = request_firmware(&fw,
>>>> -                           knav_acc_firmwares[i],
>>>> -                           kdev->dev);
>>>> +            ret = request_firmware_direct(&fw,
>>>> +                              knav_acc_firmwares[i],
>>>> +                              kdev->dev);
>>>>               if (!ret) {
>>>>                   found = true;
>>>>                   break;
>>>>
>>> Santosh,
>>>
>>> If this looks good, could you please send this to linux-next?  Without
>>> this, Linux boot will see a pause for about 60 seconds if qmss acc
>>> firmware is not present in the file system. So this is a must for next.
>>>
>> Santosh,
>>
>> A Gentle ping....
>>
> Yes I have seen it but it has to wait now. I plan to send that as a fix
> as part of 4.4-rcx fixes.
Santosh,

Not sure what the reason is. Can't this be sent to linux-next as should 
be the case if something is broken on that branch AFAIK. For us, this 
would help to merge to ti kernel based on 4.1.y if this is already part 
of an upstream branch. Otherwise, I will have to wait merge of the qmss 
accumulator series to ti kernel until this one is merged to upstream 
which will block the release. So I prefer you send this one to 
linux-next sooner than late.

Thanks and regards,

Murali
>
>


-- 
Murali Karicheri
Linux Kernel, Keystone

[PATCH linux-next] soc: ti: use request_firmware_direct() as acc firmware is optional

[santosh shilimkar]

On 10/19/2015 10:02 AM, Murali Karicheri wrote:
> On 10/19/2015 11:29 AM, santosh shilimkar wrote:
>> On 10/19/2015 8:28 AM, Murali Karicheri wrote:
>>> On 10/16/2015 10:00 AM, Murali Karicheri wrote:
>>>> On 10/15/2015 02:59 PM, Murali Karicheri wrote:
>>>>> When firmware image for PDSP firmware is absent in the file system
>>>>> the kernel boot with ramfs/nfs is stuck for 60 seconds being the
>>>>> the default timeout. request_firmware_direct() is to take care of
>>>>> such optional firmware loading and hence replace the call in the
>>>>> driver with this API.
>>>>>
>>>>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>>>>> ---
>>>>>   drivers/soc/ti/knav_qmss_queue.c | 6 +++---
>>>>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>>>>
>>>>> diff --git a/drivers/soc/ti/knav_qmss_queue.c
>>>>> b/drivers/soc/ti/knav_qmss_queue.c
>>>>> index f3a0b6a..89789e2 100644
>>>>> --- a/drivers/soc/ti/knav_qmss_queue.c
>>>>> +++ b/drivers/soc/ti/knav_qmss_queue.c
>>>>> @@ -1519,9 +1519,9 @@ static int knav_queue_load_pdsp(struct
>>>>> knav_device *kdev,
>>>>>
>>>>>       for (i = 0; i < ARRAY_SIZE(knav_acc_firmwares); i++) {
>>>>>           if (knav_acc_firmwares[i]) {
>>>>> -            ret = request_firmware(&fw,
>>>>> -                           knav_acc_firmwares[i],
>>>>> -                           kdev->dev);
>>>>> +            ret = request_firmware_direct(&fw,
>>>>> +                              knav_acc_firmwares[i],
>>>>> +                              kdev->dev);
>>>>>               if (!ret) {
>>>>>                   found = true;
>>>>>                   break;
>>>>>
>>>> Santosh,
>>>>
>>>> If this looks good, could you please send this to linux-next?  Without
>>>> this, Linux boot will see a pause for about 60 seconds if qmss acc
>>>> firmware is not present in the file system. So this is a must for next.
>>>>
>>> Santosh,
>>>
>>> A Gentle ping....
>>>
>> Yes I have seen it but it has to wait now. I plan to send that as a fix
>> as part of 4.4-rcx fixes.
> Santosh,
>
> Not sure what the reason is. Can't this be sent to linux-next as should
> be the case if something is broken on that branch AFAIK. For us, this
> would help to merge to ti kernel based on 4.1.y if this is already part
> of an upstream branch. Otherwise, I will have to wait merge of the qmss
> accumulator series to ti kernel until this one is merged to upstream
> which will block the release. So I prefer you send this one to
> linux-next sooner than late.
>
Ahh... You request was for linux-next. Thats no problem. My response was
when I plan to send that for upstream merge and that will be as part of 
the 4.4-rcx fixes.

Will add in my queue so that it will start showing up in linux-next
soon.

Regards,
Santosh

[PATCH linux-next] soc: ti: use request_firmware_direct() as acc firmware is optional

[Murali Karicheri]

On 10/19/2015 01:07 PM, santosh shilimkar wrote:
> On 10/19/2015 10:02 AM, Murali Karicheri wrote:
>> On 10/19/2015 11:29 AM, santosh shilimkar wrote:
>>> On 10/19/2015 8:28 AM, Murali Karicheri wrote:
>>>> On 10/16/2015 10:00 AM, Murali Karicheri wrote:
>>>>> On 10/15/2015 02:59 PM, Murali Karicheri wrote:
>>>>>> When firmware image for PDSP firmware is absent in the file system
>>>>>> the kernel boot with ramfs/nfs is stuck for 60 seconds being the
>>>>>> the default timeout. request_firmware_direct() is to take care of
>>>>>> such optional firmware loading and hence replace the call in the
>>>>>> driver with this API.
>>>>>>
>>>>>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>>>>>> ---
>>>>>>   drivers/soc/ti/knav_qmss_queue.c | 6 +++---
>>>>>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>>>>>
>>>>>> diff --git a/drivers/soc/ti/knav_qmss_queue.c
>>>>>> b/drivers/soc/ti/knav_qmss_queue.c
>>>>>> index f3a0b6a..89789e2 100644
>>>>>> --- a/drivers/soc/ti/knav_qmss_queue.c
>>>>>> +++ b/drivers/soc/ti/knav_qmss_queue.c
>>>>>> @@ -1519,9 +1519,9 @@ static int knav_queue_load_pdsp(struct
>>>>>> knav_device *kdev,
>>>>>>
>>>>>>       for (i = 0; i < ARRAY_SIZE(knav_acc_firmwares); i++) {
>>>>>>           if (knav_acc_firmwares[i]) {
>>>>>> -            ret = request_firmware(&fw,
>>>>>> -                           knav_acc_firmwares[i],
>>>>>> -                           kdev->dev);
>>>>>> +            ret = request_firmware_direct(&fw,
>>>>>> +                              knav_acc_firmwares[i],
>>>>>> +                              kdev->dev);
>>>>>>               if (!ret) {
>>>>>>                   found = true;
>>>>>>                   break;
>>>>>>
>>>>> Santosh,
>>>>>
>>>>> If this looks good, could you please send this to linux-next?  Without
>>>>> this, Linux boot will see a pause for about 60 seconds if qmss acc
>>>>> firmware is not present in the file system. So this is a must for
>>>>> next.
>>>>>
>>>> Santosh,
>>>>
>>>> A Gentle ping....
>>>>
>>> Yes I have seen it but it has to wait now. I plan to send that as a fix
>>> as part of 4.4-rcx fixes.
>> Santosh,
>>
>> Not sure what the reason is. Can't this be sent to linux-next as should
>> be the case if something is broken on that branch AFAIK. For us, this
>> would help to merge to ti kernel based on 4.1.y if this is already part
>> of an upstream branch. Otherwise, I will have to wait merge of the qmss
>> accumulator series to ti kernel until this one is merged to upstream
>> which will block the release. So I prefer you send this one to
>> linux-next sooner than late.
>>
> Ahh... You request was for linux-next. Thats no problem. My response was
> when I plan to send that for upstream merge and that will be as part of
> the 4.4-rcx fixes.
>
> Will add in my queue so that it will start showing up in linux-next
> soon.

Thanks Santosh, that helps!

Murali
>
> Regards,
> Santosh
>
>


-- 
Murali Karicheri
Linux Kernel, Keystone