linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: michal.simek@xilinx.com (Michal Simek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 2/3] ARM: zynq: dt: Updated devicetree for Zynq 7000 platform.
Date: Tue, 20 Oct 2015 13:15:11 +0200	[thread overview]
Message-ID: <5626223F.6040008@xilinx.com> (raw)
In-Reply-To: <20151019182416.GL12756@jcartwri.amer.corp.natinst.com>

On 10/19/2015 08:24 PM, Josh Cartwright wrote:
> On Mon, Oct 19, 2015 at 04:09:09PM +0200, Michal Simek wrote:
>> On 10/18/2015 07:53 PM, Josh Cartwright wrote:
>>> On Fri, Oct 16, 2015 at 03:42:29PM -0700, Moritz Fischer wrote:
> [..]
>>>> @@ -294,6 +294,11 @@
>>>>  		devcfg: devcfg at f8007000 {
>>>>  			compatible = "xlnx,zynq-devcfg-1.0";
>>>>  			reg = <0xf8007000 0x100>;
>>>> +			interrupt-parent = <&intc>;
>>>
>>> You shouldn't need interrupt-parent here.  In fact, I suspect it can be
>>> removed from all sibling nodes as well.
>>
>> Correct. But I tend to do it vice-versa. To remove it from amba node and
>> keep it in every IP here. The reason is simple to let everybody know
>> that setting up right interrupt controller is something what they have
>> to care. If you have more interrupt controllers in the system it can be
>> messy.
> 
> If you like that, then you'd like the interrupt-extended properly even
> better (I think).

yep. That works for me too.

Thanks,
Michal

  reply	other threads:[~2015-10-20 11:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-16 22:42 [PATCHv2 0/3] Adding FPGA Manager support for Xilinx Zynq Moritz Fischer
2015-10-16 22:42 ` [PATCHv2 1/3] ARM: dt: fpga: Added binding docs for Xilinx Zynq FPGA manager Moritz Fischer
2015-10-18 17:51   ` Josh Cartwright
2015-10-19  2:24     ` Sören Brinkmann
2015-10-16 22:42 ` [PATCHv2 2/3] ARM: zynq: dt: Updated devicetree for Zynq 7000 platform Moritz Fischer
2015-10-18 17:53   ` Josh Cartwright
2015-10-19 14:09     ` Michal Simek
2015-10-19 18:24       ` Josh Cartwright
2015-10-20 11:15         ` Michal Simek [this message]
2015-10-16 22:42 ` [PATCHv2 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000 Moritz Fischer
2015-10-18 18:02   ` Josh Cartwright
2015-10-19 16:28     ` Moritz Fischer
2015-10-22 17:56   ` atull
2015-10-22 18:38     ` Moritz Fischer
2015-10-18 19:08 ` [PATCHv2 0/3] Adding FPGA Manager support for Xilinx Zynq Josh Cartwright
2015-10-19 14:12   ` Michal Simek
2015-10-19 16:25     ` Moritz Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5626223F.6040008@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).