linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFT] ARM: bcm2835: enable all bcm2835-relevant in defconfig
Date: Tue, 20 Oct 2015 20:32:20 -0600	[thread overview]
Message-ID: <5626F934.6090706@wwwdotorg.org> (raw)
In-Reply-To: <1444942061-23085-1-git-send-email-stefan.wahren@i2se.com>

On 10/15/2015 02:47 PM, Stefan Wahren wrote:
> Rebuild bcm2835_defconfig using "make bcm2835_defconfig;
> make savedefconfig", and add the following features:
> 
> * Enable all bcm2835-relevant drivers (MBOX, WDT, DMA,
>   PWM, SND)
> * Re-enable some features to keep the current settings
>   (stackprotector, LED GPIO, LED triggers)

Can you explain that second bullet a bit more?

When regenerating defconfig files, it is quite common for entries not
related to your changes to appear or disappear due to other changes in
the kernel or some of the remove options being selected by some of the
new options you enabled.

To check what's going on, I usually do the following when editing defconfig:

1) Rebuild bcm2835_defconfig without editing the .config file at all
(make bcm2835_defconfig; make savedefconfig; mv defconfig
arch/arm/configs/bcm2835_defconfig; git commit). This allows me to see
all the unrelated changes that will happen simply due to rebuilding the
defconfig. You should double-check these, but likely ignore them.

2) Now edit the .config (e.g. make menuconfig) and re-generate the
defconfig and commit. This change should now only include changes that
are a direct result of your .config edits.

To submit the patch, I often squash the two together after the separate
validation.

  reply	other threads:[~2015-10-21  2:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-15 20:47 [PATCH RFT] ARM: bcm2835: enable all bcm2835-relevant in defconfig Stefan Wahren
2015-10-21  2:32 ` Stephen Warren [this message]
2015-10-21 16:16   ` Stefan Wahren
2015-10-21 16:45     ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5626F934.6090706@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).