From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4105DC43381 for ; Sat, 16 Mar 2019 20:00:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1516221019 for ; Sat, 16 Mar 2019 20:00:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qxI1pSAz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1516221019 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fEcxdZ1mRQIazL0jnuzBKye7W8fLPrR+Ly6H51qrqhE=; b=qxI1pSAzTcVpoz 4IzYzaDmR3SminHQFtBBaiQZ2OL21lbajqB2Jn3Z2mO+FYE1GSTPRNmDRnByN+tGpCId7txb91L/w 4JTt5TX+TtxTfvIwR97QbhlpXlXWM3vDBKs8YdeoUqu5BmHZ72s5EiszydFxrcFVMNYFJ7ncqH/BP k9hJfayAuu4g0R5/YWq2cQeyexHAXwsNGQxCqdvZNHcYl37jLo/kA8LjYKqxE9hMB8tWYeWzsMCk6 pGz02eS7GOa/ds5CcdT9417W2ihvd4BgGq62hvjbQGk05yrg8krKjbEGSw0I3MlayXud8A0py3U5q uTmOAQuyqvN6i09Ye49A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5FTx-0004kf-1O; Sat, 16 Mar 2019 20:00:37 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5FTn-0004US-Im; Sat, 16 Mar 2019 20:00:28 +0000 Received: from ip5f5a6320.dynamic.kabel-deutschland.de ([95.90.99.32] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1h5FTl-0000bA-O9; Sat, 16 Mar 2019 21:00:25 +0100 From: Heiko Stuebner To: Peter Geis Subject: Re: [PATCH] arm64: dts: rockchip: fix rk3328 rgmii high tx error rate Date: Sat, 16 Mar 2019 21:00:24 +0100 Message-ID: <5627989.CJK7gzyIMr@phil> In-Reply-To: <20190313184535.15759-1-pgwipeout@gmail.com> References: <20190313184535.15759-1-pgwipeout@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190316_130027_972523_46087770 X-CRM114-Status: GOOD ( 12.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rockchip@lists.infradead.org, Robin Murphy , linux-arm-kernel@lists.infradead.org, "Leonidas P . Papadakos" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Mittwoch, 13. M=E4rz 2019, 19:45:36 CET schrieb Peter Geis: > Resubmitting, after further research, review, comments, and suggestions. > = > Several rk3328 based boards experience high rgmii tx error rates. > This is due to several pins in the rk3328.dtsi rgmii pinmux that are > missing a defined pull strength setting. > This causes the pinmux driver to default to 2ma (bit mask 00). > = > These pins are only defined in the rk3328.dtsi, and are not listed in > the rk3328 specification. > The TRM only lists them as "Reserved" > (RK3328 TRM V1.1, 3.3.3 Detail Register Description, GRF_GPIO0B_IOMUX, > GRF_GPIO0C_IOMUX, GRF_GPIO0D_IOMUX). > However, removal of these pins from the rgmii pinmux definition causes > the interface to fail to transmit. > = > Also, the rgmii tx and rx pins defined in the dtsi are not consistent > with the rk3328 specification, with tx pins currently set to 12ma and > rx pins set to 2ma. > = > Fix this by setting tx pins to 8ma and the rx pins to 4ma, consistent > with the specification. > Defining the drive strength for the undefined pins eliminated the high > tx packet error rate observed under heavy data transfers. > Aligning the drive strength to the TRM values eliminated the occasional > packet retry errors under iperf3 testing. > This allows much higher data rates with no recorded tx errors. > = > Tested on the rk3328-roc-cc board. > = > Signed-off-by: Peter Geis applied as fix for 5.1 after adding Fixes and Cc-stable-tags Thanks Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel