linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: slash.tmp@free.fr (Mason)
To: linux-arm-kernel@lists.infradead.org
Subject: pmu: armv7_a9_pmu_init() fails with -ENXIO
Date: Wed, 21 Oct 2015 17:44:10 +0200	[thread overview]
Message-ID: <5627B2CA.4030005@free.fr> (raw)
In-Reply-To: <5627A0DB.5030304@arm.com>

On 21/10/2015 16:27, Sudeep Holla wrote:

> On 21/10/15 14:46, Mason wrote:
> 
>> I also looked more closely at of_pmu_irq_cfg()
>>
>> platform_get_irq(pdev, 0); returns -6
> 
> Won't it return here ?
> Though you must first check why is that returning error.
> 
>          irq = platform_get_irq(pdev, 0);
>          if (irq >= 0 && irq_is_percpu(irq))
>                  return 0;

Thanks for prodding me in the right direction.
platform_get_irq() was failing because I hadn't properly defined
the node's interrupt-parent...

I've added
  interrupt-parent = <&gic>;
at the root of my DT, and things now work as expected.
(Haven't tested actually using the counters yet.)

[    0.090058] irq=212 irqs=e7603400 pdev->num_resources=2
[    0.090091] hw perfevents: Failed to parse /pmu/interrupt-affinity[0]
[    0.090103] armv7_a9_pmu_init: ret=0
[    0.090145] hw perfevents: enabled with armv7_cortex_a9 PMU driver, 7 counters available

Thanks again.

Regards.

  reply	other threads:[~2015-10-21 15:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-21 13:01 pmu: armv7_a9_pmu_init() fails with -ENXIO Mason
2015-10-21 13:46 ` Mason
2015-10-21 14:27   ` Sudeep Holla
2015-10-21 15:44     ` Mason [this message]
2015-10-21 16:26       ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5627B2CA.4030005@free.fr \
    --to=slash.tmp@free.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).