linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFT] ARM: bcm2835: enable all bcm2835-relevant in defconfig
Date: Wed, 21 Oct 2015 10:45:09 -0600	[thread overview]
Message-ID: <5627C115.1050305@wwwdotorg.org> (raw)
In-Reply-To: <5627BA5F.104@lategoodbye.de>

On 10/21/2015 10:16 AM, Stefan Wahren wrote:
> Am 21.10.2015 um 04:32 schrieb Stephen Warren:
>> On 10/15/2015 02:47 PM, Stefan Wahren wrote:
>>> Rebuild bcm2835_defconfig using "make bcm2835_defconfig;
>>> make savedefconfig", and add the following features:
>>>
>>> * Enable all bcm2835-relevant drivers (MBOX, WDT, DMA,
>>>    PWM, SND)
>>> * Re-enable some features to keep the current settings
>>>    (stackprotector, LED GPIO, LED triggers)
>>
>> Can you explain that second bullet a bit more?
>
> Yes, the last update to bcm2835_defconfig was on 25th September 2014.
> So a little bit changed in the configs like renaming of options.
> After saving the defconfig i noticed that we "lost" 2 features with
> the new defconfig:
>
> * CONFIG_CC_STACKPROTECTOR because of renaming to
> CONFIG_CC_STACKPROTECTOR_REGULAR
>
> * CONFIG_LEDS_TRIGGER_HEARTBEAT because of the following new dependencies
>    * CONFIG_NEW_LEDS
>    * CONFIG_LEDS_CLASS
>    * CONFIG_LEDS_TRIGGERS

Ah OK. It'd be nice to have that in the patch description.

> Do you want 2 separate patches (first update with re-enable and second
> with new bcm2835 stuff)?

It's probably fine as a single patch so long as all the changes (and 
reason why they're made) are described there.

      reply	other threads:[~2015-10-21 16:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-15 20:47 [PATCH RFT] ARM: bcm2835: enable all bcm2835-relevant in defconfig Stefan Wahren
2015-10-21  2:32 ` Stephen Warren
2015-10-21 16:16   ` Stefan Wahren
2015-10-21 16:45     ` Stephen Warren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5627C115.1050305@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).