From: timur@codeaurora.org (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Revert "serial: amba-pl011: fix incorrect integer size in pl011_fifo_to_tty()"
Date: Fri, 23 Oct 2015 07:35:06 -0500 [thread overview]
Message-ID: <562A297A.9030204@codeaurora.org> (raw)
In-Reply-To: <20151023103056.GI4801@e103592.cambridge.arm.com>
Dave Martin wrote:
>> >The commit 71a5cd8a4 makes the console hang for some times.
>> >This reverts commit 71a5cd8a4a2602a6e9010b557a23af0a54df87b6.
> What hangs? Input? Output? Both?
>
> Is CREAD set on the terminal? If only input hangs, it's possible CREAD
> is not set and we were previously getting away with it, though I can't
> easily see why it should be unset...
Dave is right, the revert doesn't make any sense. Huang has a user-space
bug. Please check to see if CREAD is set. I'm pretty sure it isn't.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
next prev parent reply other threads:[~2015-10-23 12:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 10:00 [PATCH] Revert "serial: amba-pl011: fix incorrect integer size in pl011_fifo_to_tty()" Huang Shijie
2015-10-23 10:31 ` Dave Martin
2015-10-23 12:35 ` Timur Tabi [this message]
2015-10-23 13:34 ` Dave P Martin
2015-10-23 15:37 ` Timur Tabi
2015-10-23 16:02 ` Dave P Martin
2015-10-23 16:38 ` Timur Tabi
2015-10-23 17:49 ` Peter Hurley
2015-10-26 1:58 ` Huang Shijie
2015-10-26 2:13 ` Huang Shijie
2015-10-26 5:47 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562A297A.9030204@codeaurora.org \
--to=timur@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).