linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: eric.auger@linaro.org (Eric Auger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 6/7] vfio: platform: use list of registered reset function
Date: Fri, 23 Oct 2015 16:11:08 +0200	[thread overview]
Message-ID: <562A3FFC.4050504@linaro.org> (raw)
In-Reply-To: <4934120.DeNtNjTIFs@wuerfel>

Hi Arnd,
On 10/23/2015 03:12 PM, Arnd Bergmann wrote:
> On Friday 23 October 2015 14:37:14 Eric Auger wrote:
>> Remove the static lookup table and use the dynamic list of registered
>> reset functions instead. Also load the reset module through its alias.
>> The reset struct module pointer is stored in vfio_platform_device.
>>
>> We also remove the useless struct device pointer parameter in
>> vfio_platform_get_reset.
>>
>> This patch fixes the issue related to the usage of __symbol_get, which
>> besides from being moot, prevented compilation with CONFIG_MODULES
>> disabled.
>>
>> Also usage of MODULE_ALIAS makes possible to add a new reset module
>> without needing to update the framework. This was suggested by Arnd.
>>
>> Signed-off-by: Eric Auger <eric.auger@linaro.org>
>> Reported-by: Arnd Bergmann <arnd@arndb.de>
>>
>>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> 
> but doesn't this need to come before patch 4/7?
Well I don't think so. In [4] we introduce the dynamic registration
method but until this patch we still use the old lookup method in the
static table. I tested and the reset lookup still works in [4].
If we put this one before the registration, the functionality will be
lost here.

Eric

> 	Arnd
> 

  reply	other threads:[~2015-10-23 14:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-23 12:37 [PATCH v3 0/7] VFIO platform reset module rework Eric Auger
2015-10-23 12:37 ` [PATCH v3 1/7] vfio: platform: introduce vfio-platform-base module Eric Auger
2015-10-23 13:04   ` Arnd Bergmann
2015-10-23 12:37 ` [PATCH v3 2/7] vfio: platform: add capability to register a reset function Eric Auger
2015-10-23 13:07   ` Arnd Bergmann
2015-10-23 14:15     ` Eric Auger
2015-10-23 12:37 ` [PATCH v3 3/7] vfio: platform: introduce module_vfio_reset_handler macro Eric Auger
2015-10-23 13:09   ` Arnd Bergmann
2015-10-23 14:10     ` Eric Auger
2015-10-23 12:37 ` [PATCH v3 4/7] vfio: platform: reset: calxedaxgmac: add reset function registration Eric Auger
2015-10-23 13:09   ` Arnd Bergmann
2015-10-23 12:37 ` [PATCH v3 5/7] vfio: platform: add compat in vfio_platform_device Eric Auger
2015-10-23 12:37 ` [PATCH v3 6/7] vfio: platform: use list of registered reset function Eric Auger
2015-10-23 13:12   ` Arnd Bergmann
2015-10-23 14:11     ` Eric Auger [this message]
2015-10-23 14:23       ` Arnd Bergmann
2015-10-23 15:15         ` Eric Auger
2015-10-23 12:37 ` [PATCH v3 7/7] vfio: platform: add dev_info on device reset Eric Auger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562A3FFC.4050504@linaro.org \
    --to=eric.auger@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).