From: timur@tabi.org (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Revert "serial: amba-pl011: fix incorrect integer size in pl011_fifo_to_tty()"
Date: Fri, 23 Oct 2015 10:37:49 -0500 [thread overview]
Message-ID: <562A544D.7080506@tabi.org> (raw)
In-Reply-To: <20151023133403.GI4796@e103592.cambridge.arm.com>
On 10/23/2015 08:34 AM, Dave P Martin wrote:
> Well, I'm not saying there's definitely no kernel bug, but I can't see
> how the patch should cause it. It may be triggering a latent bug
> somewhere else in the driver than hasn't been biting us before, however.
Fair enough.
> !CREAD is the most obvious cause, so that should definitely be ruled
> out first. If CREAD is clear, we need to figure out why...
So I tested this by booting to my console, and then typing in:
stty -cread
and when I did that, the console ignored all input.
I do admit that since !CREAD has been ignored for so many reason, it
could be that a lot of userspaces will suddenly have broken consoles.
next prev parent reply other threads:[~2015-10-23 15:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 10:00 [PATCH] Revert "serial: amba-pl011: fix incorrect integer size in pl011_fifo_to_tty()" Huang Shijie
2015-10-23 10:31 ` Dave Martin
2015-10-23 12:35 ` Timur Tabi
2015-10-23 13:34 ` Dave P Martin
2015-10-23 15:37 ` Timur Tabi [this message]
2015-10-23 16:02 ` Dave P Martin
2015-10-23 16:38 ` Timur Tabi
2015-10-23 17:49 ` Peter Hurley
2015-10-26 1:58 ` Huang Shijie
2015-10-26 2:13 ` Huang Shijie
2015-10-26 5:47 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562A544D.7080506@tabi.org \
--to=timur@tabi.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).