[PATCH soc/next] ARM: bcm2835: add mutual inclusion protection

[PATCH soc/next] ARM: bcm2835: add mutual inclusion protection

[Alexander Aring]

This patch adds mutual inclusion protection for the rpi firmware header.

Cc: Eric Anholt <eric@anholt.net>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Signed-off-by: Alexander Aring <alex.aring@gmail.com>
---
This patch is for "soc/next" and depends on Eric Anholt's patch ("ARM: bcm2835:
Add the Raspberry Pi firmware driver"), see:

http://lists.infradead.org/pipermail/linux-rpi-kernel/2015-October/002434.html

I think the patch is already applied but not pushed, so please fixup use this
as fixup or simple apply this patch after the patch to add the firmware driver.

 include/soc/bcm2835/raspberrypi-firmware.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/soc/bcm2835/raspberrypi-firmware.h b/include/soc/bcm2835/raspberrypi-firmware.h
index 9d9efb7..c07d74a 100644
--- a/include/soc/bcm2835/raspberrypi-firmware.h
+++ b/include/soc/bcm2835/raspberrypi-firmware.h
@@ -6,6 +6,9 @@
  * published by the Free Software Foundation.
  */
 
+#ifndef __SOC_RASPBERRY_FIRMWARE_H__
+#define __SOC_RASPBERRY_FIRMWARE_H__
+
 #include <linux/types.h>
 #include <linux/of_device.h>
 
@@ -113,3 +116,5 @@ int rpi_firmware_property(struct rpi_firmware *fw,
 int rpi_firmware_property_list(struct rpi_firmware *fw,
 			       void *data, size_t tag_size);
 struct rpi_firmware *rpi_firmware_get(struct device_node *firmware_node);
+
+#endif /* __SOC_RASPBERRY_FIRMWARE_H__ */
-- 
2.6.1

[PATCH soc/next] ARM: bcm2835: add mutual inclusion protection

[Eric Anholt]

Alexander Aring <alex.aring@gmail.com> writes:

> This patch adds mutual inclusion protection for the rpi firmware header.
>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> ---
> This patch is for "soc/next" and depends on Eric Anholt's patch ("ARM: bcm2835:
> Add the Raspberry Pi firmware driver"), see:
>
> http://lists.infradead.org/pipermail/linux-rpi-kernel/2015-October/002434.html
>
> I think the patch is already applied but not pushed, so please fixup use this
> as fixup or simple apply this patch after the patch to add the firmware driver.

Looks like Florian pulled this in to his pull request and it's in the
arm-soc tree.

Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151026/6d78cd2f/attachment.sig>

[PATCH soc/next] ARM: bcm2835: add mutual inclusion protection

[Florian Fainelli]

On 26/10/15 11:27, Eric Anholt wrote:
> Alexander Aring <alex.aring@gmail.com> writes:
> 
>> This patch adds mutual inclusion protection for the rpi firmware header.
>>
>> Cc: Eric Anholt <eric@anholt.net>
>> Cc: Stephen Warren <swarren@wwwdotorg.org>
>> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
>> ---
>> This patch is for "soc/next" and depends on Eric Anholt's patch ("ARM: bcm2835:
>> Add the Raspberry Pi firmware driver"), see:
>>
>> http://lists.infradead.org/pipermail/linux-rpi-kernel/2015-October/002434.html
>>
>> I think the patch is already applied but not pushed, so please fixup use this
>> as fixup or simple apply this patch after the patch to add the firmware driver.
> 
> Looks like Florian pulled this in to his pull request and it's in the
> arm-soc tree.

Yes I did apply this, sorry for not mentioning that (I usually do).
-- 
Florian

[PATCH soc/next] ARM: bcm2835: add mutual inclusion protection

[Lee Jones]

On Thu, 22 Oct 2015, Alexander Aring wrote:

> This patch adds mutual inclusion protection for the rpi firmware header.
> 
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Stephen Warren <swarren@wwwdotorg.org>

Looks like these didn't work.  You might want to look into that.

You either have --no-signed-off-by-cc set, or you're not using `git
send-email`.

>From the man page:

--[no-]signed-off-by-cc
    If this is set, add emails found in Signed-off-by: or Cc: lines to
    the cc list. Default is the value of sendemail.signedoffbycc
    configuration value; if that is unspecified, default to
    --signed-off-by-cc.

> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> ---
> This patch is for "soc/next" and depends on Eric Anholt's patch ("ARM: bcm2835:
> Add the Raspberry Pi firmware driver"), see:
> 
> http://lists.infradead.org/pipermail/linux-rpi-kernel/2015-October/002434.html
> 
> I think the patch is already applied but not pushed, so please fixup use this
> as fixup or simple apply this patch after the patch to add the firmware driver.
> 
>  include/soc/bcm2835/raspberrypi-firmware.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/include/soc/bcm2835/raspberrypi-firmware.h b/include/soc/bcm2835/raspberrypi-firmware.h
> index 9d9efb7..c07d74a 100644
> --- a/include/soc/bcm2835/raspberrypi-firmware.h
> +++ b/include/soc/bcm2835/raspberrypi-firmware.h
> @@ -6,6 +6,9 @@
>   * published by the Free Software Foundation.
>   */
>  
> +#ifndef __SOC_RASPBERRY_FIRMWARE_H__
> +#define __SOC_RASPBERRY_FIRMWARE_H__
> +
>  #include <linux/types.h>
>  #include <linux/of_device.h>
>  
> @@ -113,3 +116,5 @@ int rpi_firmware_property(struct rpi_firmware *fw,
>  int rpi_firmware_property_list(struct rpi_firmware *fw,
>  			       void *data, size_t tag_size);
>  struct rpi_firmware *rpi_firmware_get(struct device_node *firmware_node);
> +
> +#endif /* __SOC_RASPBERRY_FIRMWARE_H__ */

[PATCH soc/next] ARM: bcm2835: add mutual inclusion protection

[Alexander Aring]

Hi,

On Tue, Oct 27, 2015 at 05:00:03PM +0000, Lee Jones wrote:
> On Thu, 22 Oct 2015, Alexander Aring wrote:
> 
> > This patch adds mutual inclusion protection for the rpi firmware header.
> > 
> > Cc: Eric Anholt <eric@anholt.net>
> > Cc: Stephen Warren <swarren@wwwdotorg.org>
> 
> Looks like these didn't work.  You might want to look into that.
> 
> You either have --no-signed-off-by-cc set, or you're not using `git
> send-email`.
> 

I am using git send-email without "--no-signed-off-by-cc".

> From the man page:
> 
> --[no-]signed-off-by-cc
>     If this is set, add emails found in Signed-off-by: or Cc: lines to
>     the cc list. Default is the value of sendemail.signedoffbycc
>     configuration value; if that is unspecified, default to
>     --signed-off-by-cc.
> 

I wonder if this is really not working.

Stephen Warren, Eric Anholt did you receive my mail? I saw everybody
(except you) has these two in cc when they replied.

- Alex

[PATCH soc/next] ARM: bcm2835: add mutual inclusion protection

[Lee Jones]

On Tue, 27 Oct 2015, Alexander Aring wrote:
> On Tue, Oct 27, 2015 at 05:00:03PM +0000, Lee Jones wrote:
> > On Thu, 22 Oct 2015, Alexander Aring wrote:
> > 
> > > This patch adds mutual inclusion protection for the rpi firmware header.
> > > 
> > > Cc: Eric Anholt <eric@anholt.net>
> > > Cc: Stephen Warren <swarren@wwwdotorg.org>
> > 
> > Looks like these didn't work.  You might want to look into that.
> > 
> > You either have --no-signed-off-by-cc set, or you're not using `git
> > send-email`.
> > 
> 
> I am using git send-email without "--no-signed-off-by-cc".
> 
> > From the man page:
> > 
> > --[no-]signed-off-by-cc
> >     If this is set, add emails found in Signed-off-by: or Cc: lines to
> >     the cc list. Default is the value of sendemail.signedoffbycc
> >     configuration value; if that is unspecified, default to
> >     --signed-off-by-cc.
> > 
> 
> I wonder if this is really not working.
> 
> Stephen Warren, Eric Anholt did you receive my mail? I saw everybody
> (except you) has these two in cc when they replied.

That would be very peculiar.

Here's the header of the mail I received from you:

Date: Thu, 22 Oct 2015 20:46:05 +0200
From: Alexander Aring <alex.aring@gmail.com>
To: f.fainelli at gmail.com
Cc: linux-rpi-kernel at lists.infradead.org, linux-arm-kernel at lists.infradead.org
Subject: [PATCH soc/next] ARM: bcm2835: add mutual inclusion protection

No sign of Eric or Stephen.

[PATCH soc/next] ARM: bcm2835: add mutual inclusion protection

[Stephen Warren]

On 10/27/2015 11:42 AM, Alexander Aring wrote:
> Hi,
> 
> On Tue, Oct 27, 2015 at 05:00:03PM +0000, Lee Jones wrote:
>> On Thu, 22 Oct 2015, Alexander Aring wrote:
>>
>>> This patch adds mutual inclusion protection for the rpi firmware header.
>>>
>>> Cc: Eric Anholt <eric@anholt.net>
>>> Cc: Stephen Warren <swarren@wwwdotorg.org>
>>
>> Looks like these didn't work.  You might want to look into that.
>>
>> You either have --no-signed-off-by-cc set, or you're not using `git
>> send-email`.
>>
> 
> I am using git send-email without "--no-signed-off-by-cc".
> 
>> From the man page:
>>
>> --[no-]signed-off-by-cc
>>     If this is set, add emails found in Signed-off-by: or Cc: lines to
>>     the cc list. Default is the value of sendemail.signedoffbycc
>>     configuration value; if that is unspecified, default to
>>     --signed-off-by-cc.
>>
> 
> I wonder if this is really not working.
> 
> Stephen Warren, Eric Anholt did you receive my mail? I saw everybody
> (except you) has these two in cc when they replied.

I received two copies of the original email; one directly and one via
the ARM kernel mailing list. Both have both Eric and myself in CC.