From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] Tegra: DT: add device tree binding doc for QSPI
Date: Mon, 26 Oct 2015 15:04:11 -0600 [thread overview]
Message-ID: <562E954B.5070604@wwwdotorg.org> (raw)
In-Reply-To: <1445891676-3262-1-git-send-email-twarren@nvidia.com>
On 10/26/2015 02:34 PM, Tom Warren wrote:
> This patch adds the device tree binding doc for the Tegra
> QSPI controller on Tegra210.
> diff --git a/Documentation/devicetree/bindings/spi/nvidia,tegra210-qspi.txt b/Documentation/devicetree/bindings/spi/nvidia,tegra210-qspi.txt
> +- clock-names : Must include the following entries:
> + - qspi
> +- resets : Must contain an entry for each entry in reset-names.
> + See ../reset/reset.txt for details.
> +- reset-names : Must include the following entries:
> + - qspi
> +- clocks : Must contain an entry for each entry in clock-names.
> + See ../clocks/clock-bindings.txt for details.
Let's keep clocks and clock-names next to each-other in the doc. I don't
know why they aren't in the eixsting Tegra SPI doc.
With this issue fixed, this patch looks good to me.
Note: I don't see the devicetree mailing list in the CC list. You should
probably replace the U-Boot mailing list with it.
> +Optional properties:
> +- dmas : Must contain an entry for each entry in clock-names.
> + See ../dma/dma.txt for details.
> +- dma-names : Must include the following entries:
> + - rx
> + - tx
Eventually, we should have a property that describes the SPI bus width
(x1, x2, x4 I assume). However, we can assume that unless otherwise
specified, the width is x1, and add a property to specify the width
later as/when we need it if you want.
next prev parent reply other threads:[~2015-10-26 21:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 20:34 [PATCH v3] Tegra: DT: add device tree binding doc for QSPI Tom Warren
2015-10-26 21:04 ` Stephen Warren [this message]
2015-10-26 21:36 ` Tom Warren
2015-10-26 21:49 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562E954B.5070604@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).