linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: brijeshkumar.singh@amd.com (Brijesh Singh)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] EDAC: Add ARM64 EDAC
Date: Tue, 27 Oct 2015 15:01:59 -0500	[thread overview]
Message-ID: <562FD837.50505@amd.com> (raw)
In-Reply-To: <20151027190832.GN19782@codeaurora.org>

Thanks for review Steve.

On 10/27/2015 02:08 PM, Stephen Boyd wrote:
>> +config EDAC_CORTEX_ARM64
>> +	tristate "ARM Cortex A57/A53"
>> +	depends on EDAC_MM_EDAC && ARM64
>> +	default n
> 
> n is the default so this can be removed.
> 
noted

>> +	.driver = {
>> +		.name = DRV_NAME,
>> +		.owner = THIS_MODULE,
> 
> This line can be removed. THIS_MODULE is assigned by
> platform_driver_register().
noted. 

> 
>> +		.of_match_table = cortex_arm64_edac_of_match,
>> +	},
>> +};
>> +
>> +static int __init cortex_arm64_edac_init(void)
>> +{
>> +	return platform_driver_register(&cortex_arm64_edac_driver);
>> +}
>> +module_init(cortex_arm64_edac_init);
>> +
>> +static void __exit cortex_arm64_edac_exit(void)
>> +{
>> +	platform_driver_unregister(&cortex_arm64_edac_driver);
>> +}
>> +module_exit(cortex_arm64_edac_exit);
> 
> This can be module_platform_driver(cortex_arm64_edac_driver) now.
> 
noted.

-Brijesh

      reply	other threads:[~2015-10-27 20:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27 17:29 [PATCH v3] EDAC: Add ARM64 EDAC Brijesh Singh
2015-10-27 19:08 ` Stephen Boyd
2015-10-27 20:01   ` Brijesh Singh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562FD837.50505@amd.com \
    --to=brijeshkumar.singh@amd.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).