From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option
Date: Tue, 03 Nov 2015 09:30:56 +0900 [thread overview]
Message-ID: <56380040.3080600@samsung.com> (raw)
In-Reply-To: <1446469011-22710-20-git-send-email-daniel.lezcano@linaro.org>
On 02.11.2015 21:56, Daniel Lezcano wrote:
> Let the platform's Kconfig to select the clock instead of having a reverse
> dependency from the driver to the platform options.
Selecting user-visible symbols is rather discouraged so why not
something like this:
- def_bool y if ARCH_EXYNOS
- depends on !ARM64
+ bool "Exynos multi core timer driver"
+ depends on ARCH_EXYNOS || (COMPILE_TEST && ARM)
Best regards,
Krzysztof
>
> Add the COMPILE_TEST option for the compilation test coverage. Due to the
> non portable 'delay' code, this driver is only compilable on ARM.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> arch/arm/mach-exynos/Kconfig | 1 +
> drivers/clocksource/Kconfig | 4 ++--
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
> index 3a10f1a..ff10539 100644
> --- a/arch/arm/mach-exynos/Kconfig
> +++ b/arch/arm/mach-exynos/Kconfig
> @@ -27,6 +27,7 @@ menuconfig ARCH_EXYNOS
> select SRAM
> select THERMAL
> select MFD_SYSCON
> + select CLKSRC_EXYNOS_MCT
> help
> Support for SAMSUNG EXYNOS SoCs (EXYNOS4/5)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 916c36d..d829cbe 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -213,8 +213,8 @@ config CLKSRC_METAG_GENERIC
> This option enables support for the Meta per-thread timers.
>
> config CLKSRC_EXYNOS_MCT
> - def_bool y if ARCH_EXYNOS
> - depends on !ARM64
> + bool "Exynos multi core timer driver" if COMPILE_TEST
> + depends on ARM
> help
> Support for Multi Core Timer controller on Exynos SoCs.
>
>
next prev parent reply other threads:[~2015-11-03 0:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1446469011-22710-1-git-send-email-daniel.lezcano@linaro.org>
2015-11-02 12:56 ` [PATCH 02/22] clocksource/drivers/mediatek: Add the COMPILE_TEST option Daniel Lezcano
2015-11-02 12:56 ` [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible Daniel Lezcano
2015-11-02 15:33 ` Arnd Bergmann
2015-11-02 16:32 ` Daniel Lezcano
2015-11-02 21:44 ` Arnd Bergmann
2015-11-02 12:56 ` [PATCH 13/22] clocksource/drivers/vt8500: Remove unneeded header Daniel Lezcano
2015-11-02 12:56 ` [PATCH 19/22] clocksource/drivers/prcmu: Fix Kconfig and add COMPILE_TEST option Daniel Lezcano
2015-11-02 14:40 ` Linus Walleij
2015-11-02 14:57 ` Daniel Lezcano
2015-11-02 12:56 ` [PATCH 20/22] clocksource/drivers/exynos_mct: " Daniel Lezcano
2015-11-03 0:30 ` Krzysztof Kozlowski [this message]
2015-11-03 0:59 ` Krzysztof Kozlowski
2015-11-03 8:40 ` Daniel Lezcano
2015-11-03 10:02 ` Arnd Bergmann
2015-11-03 11:08 ` Daniel Lezcano
2015-11-03 12:01 ` Krzysztof Kozlowski
2015-11-03 12:04 ` Daniel Lezcano
2015-11-03 15:18 ` John Stultz
2015-11-03 0:54 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56380040.3080600@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).