From mboxrd@z Thu Jan 1 00:00:00 1970 From: tn@semihalf.com (Tomasz Nowicki) Date: Tue, 3 Nov 2015 15:39:36 +0100 Subject: [PATCH V1 11/11] arm64, pci, acpi: Support for ACPI based PCI hostbridge init In-Reply-To: <20151103141512.GC3574@red-moon> References: <1445963922-22711-1-git-send-email-tn@semihalf.com> <1445963922-22711-12-git-send-email-tn@semihalf.com> <5631180D.2000902@codeaurora.org> <20151103141512.GC3574@red-moon> Message-ID: <5638C728.2020503@semihalf.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03.11.2015 15:15, Lorenzo Pieralisi wrote: > On Wed, Oct 28, 2015 at 02:46:37PM -0400, Sinan Kaya wrote: > > [...] > >>> -int raw_pci_write(unsigned int domain, unsigned int bus, >>> - unsigned int devfn, int reg, int len, u32 val) >>> +struct pci_ops pci_root_ops = { >>> + .map_bus = pci_mcfg_dev_base, >>> + .read = pci_generic_config_read, >>> + .write = pci_generic_config_write, >> >> >> Can you change these with pci_generic_config_read32 and >> pci_generic_config_write32? We have some targets that can only do 32 >> bits PCI config space access. > > No. > > http://www.spinics.net/lists/linux-pci/msg44869.html > > Can you be a bit more specific please ? > > Sigh. Looks like we have to start adding platform specific quirks even > before we merged the generic ACPI PCIe host controller implementation. > The sad reality... But my next version will be still generic. Once that one appear to be in good shape then we can add quirks. Regards, Tomasz