wrong value in kirkwood-ts219.dtsi

wrong value in kirkwood-ts219.dtsi

[Helmut Klein]

Hallo,

the line "reg = <0x12000 0x100>;" in the section "poweroff at 12100" is not 
correct

The base address of uart1, which is connected to the pic controller is 
0x12100 and not 0x12000

kernel v4.3 runs perfectly on my qnap ts110. I setup a minimal kernel 
configuration.
Otherwise i use debian unstable.

thanks a lot for still supporting my hardware. qnap dropped it severals 
years ago.

regards
Helmut Klein

wrong value in kirkwood-ts219.dtsi

[Andrew Lunn]

On Tue, Nov 03, 2015 at 07:59:12PM +0100, Helmut Klein wrote:
> Hallo,
> 
> the line "reg = <0x12000 0x100>;" in the section "poweroff at 12100" is
> not correct
> 
> The base address of uart1, which is connected to the pic controller
> is 0x12100 and not 0x12000

Yes, it is wrong.

Do you want to produce a proper patch for this?

Thanks
	Andrew

wrong value in kirkwood-ts219.dtsi

[Helmut Klein]

Hallo Andrew,

here is the patch (created with diff -up and then compressed with xz)

regards
Helmut

On 03.11.2015 21:36, Andrew Lunn wrote:
> On Tue, Nov 03, 2015 at 07:59:12PM +0100, Helmut Klein wrote:
>> Hallo,
>>
>> the line "reg = <0x12000 0x100>;" in the section "poweroff at 12100" is
>> not correct
>>
>> The base address of uart1, which is connected to the pic controller
>> is 0x12100 and not 0x12000
>
> Yes, it is wrong.
>
> Do you want to produce a proper patch for this?
>
> Thanks
> 	Andrew
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-kirkwood-ts219.dtsi.xz
Type: application/x-xz
Size: 288 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151104/2fd74ab2/attachment-0001.xz>

wrong value in kirkwood-ts219.dtsi

[Andrew Lunn]

On Wed, Nov 04, 2015 at 12:29:45PM +0100, Helmut Klein wrote:
> Hallo Andrew,
> 
> here is the patch (created with diff -up and then compressed with xz)

Thanks.

But unfortunately, there is a lot more process involved.  Please could
you take a look at Documentation/SubmittingPatches in the kernel
sources.

	Andrew

wrong value in kirkwood-ts219.dtsi

[Helmut Klein]

Hallo Andrew,

i've appended a text, which might be a "canonical patch".

regards
Helmut


Subject: arm: make QNAP power-off work for ts219 with an appended dt blob

the "reg" entry in the "poweroff" section of "kirkwood-ts219.dtsi"
addressed the wrong uart (0 = console). this patch changes the address to
select uart 1. this is the uart connected to the pic microcontroller,
which can switch the device off.
Signed-off-by: Helmut Klein <hgkr.klein@gmail.com>
---
--- linux-4.3/arch/arm/boot/dts/kirkwood-ts219.dtsi.orig
+++ linux-4.3/arch/arm/boot/dts/kirkwood-ts219.dtsi
@@ -40,7 +40,7 @@
};
poweroff at 12100 {
compatible = "qnap,power-off";
- reg = <0x12000 0x100>;
+ reg = <0x12100 0x100>;
clocks = <&gate_clk 7>;
};
spi at 10600 {


On 04.11.2015 16:12, Andrew Lunn wrote:
> On Wed, Nov 04, 2015 at 12:29:45PM +0100, Helmut Klein wrote:
>> Hallo Andrew,
>>
>> here is the patch (created with diff -up and then compressed with xz)
>
> Thanks.
>
> But unfortunately, there is a lot more process involved.  Please could
> you take a look at Documentation/SubmittingPatches in the kernel
> sources.
>
> 	Andrew
>