linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: zhongkaihua@huawei.com (Zhong Kaihua)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] dt-bindings: gpio: Documentation for Hi6220 gpio driver
Date: Thu, 5 Nov 2015 11:01:49 +0800	[thread overview]
Message-ID: <563AC69D.3070606@huawei.com> (raw)
In-Reply-To: <CAL_JsqK1HJ1aDRWMj+7SVXz_zBbD_qbBZ79cbWCnLeKT2++bbw@mail.gmail.com>

On 2015/11/2 23:09, Rob Herring wrote:
> On Fri, Oct 30, 2015 at 9:24 PM, Zhong Kaihua <zhongkaihua@huawei.com> wrote:
>> dt-bindings: gpio: Documentation for Hi6220 gpio driver
>>
>> Signed-off-by: Zhong Kaihua <zhongkaihua@huawei.com>
>> ---
>>  .../devicetree/bindings/gpio/gpio-hi6220.txt       | 23 ++++++++++++++++++++++
>>  1 file changed, 23 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
>>
>> diff --git a/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
>> new file mode 100644
>> index 0000000..76a8932
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
>> @@ -0,0 +1,23 @@
>> +Hisilicon Hi6220 GPIO controller bindings
>> +
>> +Required properties:
>> +  - compatible:        "arm,pl061", "arm,primecell"
>> +  - gpio-controller: Marks the device node as a        GPIO controller.
>> +  - #gpio-cells: Should        be 2. See gpio.txt in this directory for a
> 
> Some strange spacing in here. Otherwise,
> 
> Acked-by: Rob Herring <robh@kernel.org>

Style problems have been fixed in V2 patch.

Rearrange the document patch to the first of patch set.

> 
>> +                description of the cells format.
>> +  - interrupt-controller: Mark the device node as an interrupt controller
>> +
>> +Example:
>> +
>> +       gpio0: gpio at f8011000 {
>> +               compatible = "arm,pl061", "arm,primecell";
>> +               reg = <0x0 0xf8011000 0x0 0x1000>;
>> +               interrupts = <0 52 0x4>;
>> +               gpio-controller;
>> +               #gpio-cells = <2>;
>> +               interrupt-controller;
>> +               #interrupt-cells = <2>;
>> +               clocks = <&ao_ctrl 2>;
>> +               clock-names = "apb_pclk";
>> +               status = "ok";
>> +       };
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo at vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> .
> 

  reply	other threads:[~2015-11-05  3:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-31  2:24 [PATCH 1/3] arm64: dts: Add Hi6220 gpio configuration nodes Zhong Kaihua
2015-10-31  2:24 ` [PATCH 2/3] dt-bindings: gpio: Documentation for Hi6220 gpio driver Zhong Kaihua
2015-11-02 15:09   ` Rob Herring
2015-11-05  3:01     ` Zhong Kaihua [this message]
2015-10-31  2:24 ` [PATCH 3/3] arm64: dts: add Hi6220 pinctrl configuration nodes Zhong Kaihua

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563AC69D.3070606@huawei.com \
    --to=zhongkaihua@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).