linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] arm64: dts: exynos7: Add pmic s2mps15 device tree node
Date: Fri, 06 Nov 2015 08:55:08 +0900	[thread overview]
Message-ID: <563BEC5C.9040707@samsung.com> (raw)
In-Reply-To: <1446724341-3568-1-git-send-email-alim.akhtar@samsung.com>

On 05.11.2015 20:52, Alim Akhtar wrote:
> This patch add pmic (s2mps15) node of espresso board,
> which includes addition of regulators and pmic-clk sub-nodes.

My comment for fixing capital letters was ignored. Do you disagree with it?

> 
> This patch also adds {vmmc,vqmmc}-supply properties for mmc2 node.
> 
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> Changes since v1:
> * Addressed Javier and Krzysztof review comments.
> * Removed unused ldo/buck nodes.
> * Removed always-on properties from ldo/buck to disable them
> * Added a consumer of pmic supply (like mmc)
> 
>  arch/arm64/boot/dts/exynos/exynos7-espresso.dts |  280 +++++++++++++++++++++++
>  1 file changed, 280 insertions(+)
> 

Rest looks good, so with the fix above:

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

  parent reply	other threads:[~2015-11-05 23:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05 11:52 [PATCH v2 1/2] arm64: dts: exynos7: Add pmic s2mps15 device tree node Alim Akhtar
2015-11-05 11:52 ` [PATCH v2 2/2] arm64: dts: exynos7: Enable HS200 mode operation Alim Akhtar
2015-11-05 23:56   ` Krzysztof Kozlowski
2015-11-05 23:55 ` Krzysztof Kozlowski [this message]
2015-11-06  0:28   ` [PATCH v2 1/2] arm64: dts: exynos7: Add pmic s2mps15 device tree node Alim Akhtar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563BEC5C.9040707@samsung.com \
    --to=k.kozlowski@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).