From: yoann@printk.fr (Yoann Sculo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] ARM: dts: kirkwood: add Seagate GoFlex Home
Date: Fri, 6 Nov 2015 17:05:55 +0100 [thread overview]
Message-ID: <563CCFE3.7080603@printk.fr> (raw)
In-Reply-To: <00000150d49a8745-1c2bc8d4-1333-46bb-bf0e-5508ef988c73-000000@email.amazonses.com>
Hi Luka,
I tested your patch on the GoFlex Home.
> + gpio-leds {
> + compatible = "gpio-leds";
> +
> + health {
> + label = "status:green:health";
> + gpios = <&gpio1 14 1>;
> + linux,default-trigger = "default-on";
> + };
> + fault {
> + label = "status:orange:fault";
> + gpios = <&gpio1 15 1>;
> + };
> + misc {
> + label = "status:white:misc";
> + gpios = <&gpio1 8 1>;
> + linux,default-trigger = "ide-disk";
> + };
> + };
I noticed green and orange leds were working fine (0 == off, 1 == on).
But white led polarity is inverted (1 == off, 0 == on).
> + partition at 500000 {
> + label = "pogoplug";
> + reg = <0x0500000 0x2000000>;
> + };
I don't think pogoplug is the proper label for this partition. It seems
duplicated from "kirkwood-goflexnet.dts" I guess you could label it
"data" for instance.
Tested-by: Yoann Sculo <yoann@printk.fr>
Yoann
next prev parent reply other threads:[~2015-11-06 16:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1446675888-24495-1-git-send-email-luka.perkov@sartura.hr>
2015-11-04 22:25 ` [PATCH 2/4] ARM: dts: kirkwood: add Linksys EA3500 Luka Perkov
2015-11-04 23:38 ` Andrew Lunn
2015-11-05 0:27 ` Andrew Lunn
2015-11-05 11:00 ` Imre Kaloz
2015-11-04 22:25 ` [PATCH 3/4] ARM: dts: kirkwood: add Seagate GoFlex Home Luka Perkov
2015-11-05 0:23 ` Andrew Lunn
2015-11-05 9:20 ` Simon Guinot
2015-11-06 16:05 ` Yoann Sculo [this message]
2015-12-18 9:32 ` Yoann Sculo
2015-11-04 22:25 ` [PATCH 4/4] ARM: dts: kirkwood: add ZyXEL NSA310s Luka Perkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563CCFE3.7080603@printk.fr \
--to=yoann@printk.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).