linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hgkr.klein@gmail.com (Helmut Klein)
To: linux-arm-kernel@lists.infradead.org
Subject: wrong value in kirkwood-ts219.dtsi
Date: Sun, 8 Nov 2015 12:16:57 +0100	[thread overview]
Message-ID: <563F2F29.8040005@gmail.com> (raw)
In-Reply-To: <20151104151227.GA3316@lunn.ch>

Hallo Andrew,

i've appended a text, which might be a "canonical patch".

regards
Helmut


Subject: arm: make QNAP power-off work for ts219 with an appended dt blob

the "reg" entry in the "poweroff" section of "kirkwood-ts219.dtsi"
addressed the wrong uart (0 = console). this patch changes the address to
select uart 1. this is the uart connected to the pic microcontroller,
which can switch the device off.
Signed-off-by: Helmut Klein <hgkr.klein@gmail.com>
---
--- linux-4.3/arch/arm/boot/dts/kirkwood-ts219.dtsi.orig
+++ linux-4.3/arch/arm/boot/dts/kirkwood-ts219.dtsi
@@ -40,7 +40,7 @@
};
poweroff at 12100 {
compatible = "qnap,power-off";
- reg = <0x12000 0x100>;
+ reg = <0x12100 0x100>;
clocks = <&gate_clk 7>;
};
spi at 10600 {


On 04.11.2015 16:12, Andrew Lunn wrote:
> On Wed, Nov 04, 2015 at 12:29:45PM +0100, Helmut Klein wrote:
>> Hallo Andrew,
>>
>> here is the patch (created with diff -up and then compressed with xz)
>
> Thanks.
>
> But unfortunately, there is a lot more process involved.  Please could
> you take a look at Documentation/SubmittingPatches in the kernel
> sources.
>
> 	Andrew
>

      reply	other threads:[~2015-11-08 11:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03 18:59 wrong value in kirkwood-ts219.dtsi Helmut Klein
2015-11-03 20:36 ` Andrew Lunn
2015-11-04 11:29   ` Helmut Klein
2015-11-04 15:12     ` Andrew Lunn
2015-11-08 11:16       ` Helmut Klein [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563F2F29.8040005@gmail.com \
    --to=hgkr.klein@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).