From mboxrd@z Thu Jan 1 00:00:00 1970 From: okaya@codeaurora.org (Sinan Kaya) Date: Mon, 9 Nov 2015 23:51:35 -0500 Subject: [PATCH V2 2/3] scsi: fix compiler warning for sg In-Reply-To: <564163F7.2020109@codeaurora.org> References: <1447034266-28003-1-git-send-email-okaya@codeaurora.org> <1447034266-28003-3-git-send-email-okaya@codeaurora.org> <564162AB.6080803@codeaurora.org> <564163F7.2020109@codeaurora.org> Message-ID: <564177D7.7070103@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/9/2015 10:26 PM, Timur Tabi wrote: > Sinan Kaya wrote: >> >> I created this patch back in March with an older version of the compiler >> and older kernel (3.19). I'm no longer able to reproduce this with this >> compiler and linux-next. >> >> Thread model: posix >> gcc version 4.8.3 20140401 (prerelease) (crosstool-NG >> linaro-1.13.1-4.8-2014.04 - Linaro GCC 4.8-2014.04) >> >> I'll drop this patch. > > Are you sure the compiler handles the old macro correctly? Maybe it's > just quiescing the error message, but it's still broken? > The code says it is using these macros for small integers only which can't overflow. I was trying to get rid of compiler warning and it seems to have disappeared. -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project